Arch Linux User Repository

I think that tcl/tk are small dependencies and can be included as normal dependencies.

In case other maintainers of this package want to move back tcl/tk to optdepends then it needs to be added to makedepends, I have no hard feelings about what is right in this case here.

tk is needed for xhfs.

tcl is needed for xhfs and hfssh.

Whoops that on me for testing only without TCL/TK, I will push fix soon + apply changes that VorpalWay suggested. In meanwhile you can add this before ./configure to fix:

CFLAGS="$CFLAGS -Wno-error=incompatible-pointer-types"

hi, i'm getting these kind of errors when trying to compile hfsutils 3.2.6_p16-1

tclhfs.c:193:26: error: passing argument 2 of ‘Tcl_Merge’ from incompatible pointer type [-Wincompatible-pointer-types]
  193 |   return Tcl_Merge(argc, argv);
      |                          ^~~~
      |                          |
      |                          char **

...

tclhfs.c:1480:38: error: passing argument 3 of ‘Tcl_CreateCommand’ from incompatible pointer type [-Wincompatible-pointer-types]
 1480 |   Tcl_CreateCommand(interp, "hfs",   cmd_hfs,   0, 0);
      |                                      ^~~~~~~
      |                                      |
      |                                      int (*)(void *, Tcl_Interp *, int,  char **)
/usr/include/tclDecls.h:303:67: note: expected ‘int (*)(void *, Tcl_Interp *, int,  const char **)’ but argument is of type ‘int (*)(void *, Tcl_Interp *, int,  char **)’
  303 |                                 const char *cmdName, Tcl_CmdProc *proc,
      |                                                      ~~~~~~~~~~~~~^~~~
tclhfs.c:1481:38: error: passing argument 3 of ‘Tcl_CreateCommand’ from incompatible pointer type [-Wincompatible-pointer-types]
 1481 |   Tcl_CreateCommand(interp, "exit",  cmd_exit,  0, 0);
      |                                      ^~~~~~~~
      |                                      |
      |                                      int (*)(void *, Tcl_Interp *, int,  char **)

...

make: *** [<builtin>: tclhfs.o] Error 1

The latest update breaks building in minimal chroots (e.g. with aurutils), since the optdep will never be installed in the chroot. You need to add tcl/tk in makedepends still for that use case.

And the other alternative is to always build with --with-tcl --with-tk with tk/tcl being in both make and optdepends, many packages also do this approach.

It would still be 1 package. Here is what I mean, splitting like this

pkgbase=hfsutils
pkgname=('hfsutils' 'hfsutils-tcltk')

Then in build you would only have:

build() {
    cd "${pkgname}-${pkgver%_p*}"
    autoreconf -fi
    ./configure --with-tcl --with-tk
    make prefix=/usr
    make -C hfsck prefix=/usr
}

And package would be split into 2 section with:

package_hfsutils() {
}

package_hfsutils-tcltk() {
depends=('tcl' 'tk')
}

I suppose that we could split it, but then it's 2 packages to maintain. The TCL/TK interface is actually rather useful, or I wouldn't bother.

I mean to only build 1 variant, with --with. This way you need it in makedeps to build it. Alternatively a split package with programs that require tcl/tk just like debian does.

I already added them to optdepends. The problem is that the configure script isn’t smart enough to use tcl and tk without the —with logic.

I think it would be better to add tcl,tk to makedepends and optdepends instead of relying on this logic.