Arch Linux User Repository

Hi @dreieck

Thank you for the patch and the update.

It seems that v1.2.3 is building without the patch you included, I suppose the patch was included in v1.2.3? I updated the license as requested.

Ahoj,

• Upstream has updated their package.
• Upstream requires that you add the "cardware" stance to the LICENSE file.

The email I got from upstream:

Hi again,

I have updated my pkcrack package:
https://www.unix-ag.uni-kl.de/~conrad/krypto/pkcrack/pkcrack-1.2.3.tar.gz

Also, I noticed that the LICENSE in the archlinux package does not include the "cardware" requirement from the README. Please add the following:

I have decided to release this program as *CardWare*. I don't remember
who coined that term, but its meaning is simple:

  If you like the program, send me a postcard. Picture postcards from
  the area where you live are preferred. On the card you may write
  anything you like, e. g. how much you like the program, what a great
  person I am, or whatever comes to your mind. Be creative! :-)
  Electronic postcards don't count.

My snail mail address is:

    Peter Conrad
    Am Heckenberg 1
    56727 Mayen

    Germany

Thanks,
Peter

You need to add the following to build(), otherwise build fails with GCC 14.1.1:

• To source, add
  "Makefile_honour_preset_CC_and_CFLAGS.patch::https://pastebin.com/raw/eZ3APfqH"
• To sha256sums, add
  '5cfe9f0215443268c3cfbfde788ff71f16e27429079cbbdcad267757787f8f9e'
• Add prepare() function:

prepare() {
  cd "${pkgname}-${pkgver}"

  patch -Np1 --follow-symlinks -i "${srcdir}/Makefile_honour_preset_CC_and_CFLAGS.patch"
}

• To build(), add

  _FIXGCC_WERROR="-Wno-error=implicit-function-declaration"
  _SILENCEWARNINGS="-Wno-implicit-function-declaration -Wno-unused-variable -Wno-format -Wno-builtin-declaration-mismatch -Wno-main -Wno-maybe-uninitialized "
  _CFLAGSADDITIONS=" ${_FIXGCC_WERROR} ${_SILENCEWARNINGS}"
  CFLAGS+="${_CFLAGSADDITIONS}"
  CXXFLAGS+="${_CFLAGSADDITIONS}"
  export CFLAGS
  export CXXFLAGS

(_SILENCEWARNINGS is optional and additionally silences warnings.)

Error message otherwise:

[...]
mktmptbl.c: In function ‘preCompTemp’:
mktmptbl.c:58:5: error: implicit declaration of function ‘memset’ [-Wimplicit-function-declaration]
   58 |     memset(numEntries, 0, sizeof(numEntries));
      |     ^~~~~~
[...]

(I have reported this to upstream via Email.)

Regards and thanks for maintaining!

This is failing to install for me when trying to download the .tar.gz file. It looks like curl isn't trusting the HTTPS cert for reasons I don't fully understand (chromium does trust it):

curl -vvv https://www.unix-ag.uni-kl.de/
*   Trying 131.246.124.83:443...
* Connected to www.unix-ag.uni-kl.de (131.246.124.83) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

Some Googling leads to believe that this is a misconfiguration on www.unix-ag.uni-kl.de related to an incomplete certificate chain. Note the "B" level score on ssllabs.com: https://www.ssllabs.com/ssltest/analyze.html?d=www.unix%2dag.uni%2dkl.de&s=131.246.124.83

I worked around this by adding this (dangerous!) line to the top of the PKGBUILD file:

DLAGENTS=("https::/usr/bin/curl -k -o %o %u")

Conflicts with package libextractor:
Both provide the file /usr/bin/extract.

Please update conflicts entry.