diff options
author | Robin Lange | 2021-11-27 10:10:55 +1100 |
---|---|---|
committer | Robin Lange | 2021-11-27 10:10:55 +1100 |
commit | b3040ac5c2f67dd764324beb0d1eca09fd7e4514 (patch) | |
tree | b0076823f1193564b2263ab30eb25d569014e8ce /0002-pam-arch-Drop-pam_faillock-counting-from-fingerprint.patch | |
parent | b2642d0a42fe117edd76c8c8da7fc120f4412e63 (diff) | |
download | aur-b3040ac5c2f67dd764324beb0d1eca09fd7e4514.tar.gz |
Update to 41.0+r15+g23ebe617
Diffstat (limited to '0002-pam-arch-Drop-pam_faillock-counting-from-fingerprint.patch')
-rw-r--r-- | 0002-pam-arch-Drop-pam_faillock-counting-from-fingerprint.patch | 73 |
1 files changed, 73 insertions, 0 deletions
diff --git a/0002-pam-arch-Drop-pam_faillock-counting-from-fingerprint.patch b/0002-pam-arch-Drop-pam_faillock-counting-from-fingerprint.patch new file mode 100644 index 000000000000..ce6d5539376f --- /dev/null +++ b/0002-pam-arch-Drop-pam_faillock-counting-from-fingerprint.patch @@ -0,0 +1,73 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: "Jan Alexander Steffens (heftig)" <heftig@archlinux.org> +Date: Tue, 31 Aug 2021 21:51:46 +0000 +Subject: [PATCH] pam-arch: Drop pam_faillock counting from fingerprint and + smartcard + +As mentioned in an [fprintd issue comment][1], we need to make sure that +the stack's error status is taken from the main auth module, i.e. +pam_fprintd, otherwise GDM will not behave correctly. + +Still use pam_faillock preauth so that we test whether the account is +locked, but don't use authfail/authsucc to log a failure/success so this +stack doesn't participate in triggering the lock. + +Ideally we would check which return values we actually want to treat as +a reason to lock the account (e.g. fingerprint mismatch) and which are +neutral (e.g. no fingerprints enrolled), but that's much more effort. + +Should fix [FS#71750][2]. + +[1]: https://gitlab.freedesktop.org/libfprint/fprintd/-/issues/112#note_1016191 +[2]: https://bugs.archlinux.org/task/71750 +--- + data/pam-arch/gdm-fingerprint.pam | 10 ++-------- + data/pam-arch/gdm-smartcard.pam | 10 ++-------- + 2 files changed, 4 insertions(+), 16 deletions(-) + +diff --git a/data/pam-arch/gdm-fingerprint.pam b/data/pam-arch/gdm-fingerprint.pam +index cc660d9a90ba..2aaf9f6c88a0 100644 +--- a/data/pam-arch/gdm-fingerprint.pam ++++ b/data/pam-arch/gdm-fingerprint.pam +@@ -2,16 +2,10 @@ + + auth required pam_shells.so + auth requisite pam_nologin.so +-auth required pam_faillock.so preauth +-# Optionally use requisite above if you do not want to prompt for the fingerprint +-# on locked accounts. +-auth [success=1 default=ignore] pam_fprintd.so +-auth [default=die] pam_faillock.so authfail ++auth requisite pam_faillock.so preauth ++auth required pam_fprintd.so + auth optional pam_permit.so + auth required pam_env.so +-auth required pam_faillock.so authsucc +-# If you drop the above call to pam_faillock.so the lock will be done also +-# on non-consecutive authentication failures. + auth [success=ok default=1] pam_gdm.so + auth optional pam_gnome_keyring.so + +diff --git a/data/pam-arch/gdm-smartcard.pam b/data/pam-arch/gdm-smartcard.pam +index e6ec129948a7..6d7333bf4204 100644 +--- a/data/pam-arch/gdm-smartcard.pam ++++ b/data/pam-arch/gdm-smartcard.pam +@@ -2,16 +2,10 @@ + + auth required pam_shells.so + auth requisite pam_nologin.so +-auth required pam_faillock.so preauth +-# Optionally use requisite above if you do not want to prompt for the smartcard +-# on locked accounts. +-auth [success=1 default=ignore] pam_pkcs11.so wait_for_card card_only +-auth [default=die] pam_faillock.so authfail ++auth requisite pam_faillock.so preauth ++auth required pam_pkcs11.so wait_for_card card_only + auth optional pam_permit.so + auth required pam_env.so +-auth required pam_faillock.so authsucc +-# If you drop the above call to pam_faillock.so the lock will be done also +-# on non-consecutive authentication failures. + auth [success=ok default=1] pam_gdm.so + auth optional pam_gnome_keyring.so + |