Don't use eval

1 files changed, 6 insertions, 8 deletions

diff --git a/PKGBUILD b/PKGBUILD
index f394d7e76881..917acc2c84a3 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -47,8 +47,6 @@ export KBUILD_BUILD_HOST=archlinux
 export KBUILD_BUILD_USER=$pkgbase
 export KBUILD_BUILD_TIMESTAMP="$(date -Ru${SOURCE_DATE_EPOCH:+d @$SOURCE_DATE_EPOCH})"
 
-LOCAL_MAKE_FLAGS="LLVM=1"
-
 prepare() {
   cd $_srcname
 
@@ -68,16 +66,16 @@ prepare() {
 
   echo "Setting config..."
   cp ../config .config
-  eval ${LOCAL_MAKE_FLAGS} make -j$(nproc) olddefconfig
+  make LLVM=1 -j$(nproc) olddefconfig
 
-  eval ${LOCAL_MAKE_FLAGS} make -j$(nproc) -s kernelrelease > version
+  make LLVM=1 -j$(nproc) -s kernelrelease > version
   echo "Prepared $pkgbase version $(<version)"
 }
 
 build() {
   cd $_srcname
-  eval ${LOCAL_MAKE_FLAGS} make -j$(nproc) all
-  eval ${LOCAL_MAKE_FLAGS} make -j$(nproc) htmldocs
+  make LLVM=1 -j$(nproc) all
+  make LLVM=1 -j$(nproc) htmldocs
 }
 
 _package() {
@@ -95,13 +93,13 @@ _package() {
   echo "Installing boot image..."
   # systemd expects to find the kernel here to allow hibernation
   # https://github.com/systemd/systemd/commit/edda44605f06a41fb86b7ab8128dcf99161d2344
-  install -Dm644 "$(${LOCAL_MAKE_FLAGS} make -j$(nproc) -s image_name)" "$modulesdir/vmlinuz"
+  install -Dm644 "$(make LLVM=1 -j$(nproc) -s image_name)" "$modulesdir/vmlinuz"
 
   # Used by mkinitcpio to name the kernel
   echo "$pkgbase" | install -Dm644 /dev/stdin "$modulesdir/pkgbase"
 
   echo "Installing modules..."
-  eval ${LOCAL_MAKE_FLAGS} make -j$(nproc) INSTALL_MOD_PATH="$pkgdir/usr" INSTALL_MOD_STRIP=1 modules_install
+  make LLVM=1 -j$(nproc) INSTALL_MOD_PATH="$pkgdir/usr" INSTALL_MOD_STRIP=1 modules_install
 
   # remove build and source links
   rm "$modulesdir"/{source,build}