Fixed bug with asm volatile

3 files changed, 325 insertions, 4 deletions

diff --git a/.SRCINFO b/.SRCINFO
index 9f253585854f..57d9f09d04fc 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = qt4
 	pkgdesc = A cross-platform application and UI framework
 	pkgver = 4.8.7
-	pkgrel = 28
+	pkgrel = 29
 	url = https://www.qt.io
 	arch = x86_64
 	license = GPL3
@@ -54,6 +54,7 @@ pkgbase = qt4
 	source = l-qclipboard_fix_recursive.patch
 	source = l-qclipboard_delay.patch
 	source = qt4-gcc6.patch
+	source = qt4-gcc8.patch
 	source = qt4-glibc-2.25.patch
 	source = qt4-icu59.patch
 	source = qt4-openssl-1.1.patch
@@ -72,6 +73,7 @@ pkgbase = qt4
 	sha256sums = 5db36cbb0686b8a503941779c821febc4a0330dc260e51d603f7aa1e4d8860ad
 	sha256sums = af3648ddb2372333b0e428788fd2ffbcfe571653fb46f898a55ae5a202f7e242
 	sha256sums = 51da49e41edac66559d3ec8dd0a152995a51a53e5d1f63f09fa089a8af7e3112
+	sha256sums = 0497411e54a0461f76ffa204236f5146a2ed0d272ae66afcfabd74090459208b
 	sha256sums = e6555f4a681227447e94e9f14e11626d50b7e5108aad06088311e87063bc0347
 	sha256sums = 61d6bf45649c728dec5f8d22be5b496ed9d40f52c2c70102696d07133cd1750d
 	sha256sums = ff3ddb5428cd2ff243558dc0c75b35f470077e9204bbc989ddcba04c866c1b68
diff --git a/PKGBUILD b/PKGBUILD
index d50cde7c2fcd..c8715668e16e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,10 +1,11 @@
-# Maintainer: Felix Yan <felixonmars@archlinux.org>
+# Maintainer: Viktor Drobot (aka dviktor) linux776 [at] gmail [dot] com
+# Contributor: Felix Yan <felixonmars@archlinux.org>
 # Contributor: Andrea Scarpino <andrea@archlinux.org>
 # Contributor: Pierre Schmitz <pierre@archlinux.de>
 
 pkgname=qt4
 pkgver=4.8.7
-pkgrel=28
+pkgrel=29
 arch=('x86_64')
 url='https://www.qt.io'
 license=('GPL3' 'LGPL' 'FDL' 'custom')
@@ -36,7 +37,7 @@ source=("https://download.qt.io/archive/qt/4.8/${pkgver}/${_pkgfqn}.tar.gz"
         'disable-sslv3.patch'
         'l-qclipboard_fix_recursive.patch'
         'l-qclipboard_delay.patch'
-        'qt4-gcc6.patch' 'qt4-glibc-2.25.patch' 'qt4-icu59.patch' 'qt4-openssl-1.1.patch')
+        'qt4-gcc6.patch' 'qt4-gcc8.patch' 'qt4-glibc-2.25.patch' 'qt4-icu59.patch' 'qt4-openssl-1.1.patch')
 sha256sums=('e2882295097e47fe089f8ac741a95fef47e0a73a3f3cdf21b56990638f626ea0'
             '157eb47865f0b43e4717819783823c569127a2e9fc48309982ca0f2b753517a1'
             'd63f22858174489068c30a12b9115d1b4e23ade00c31c117513212e9a225c1ce'
@@ -52,6 +53,7 @@ sha256sums=('e2882295097e47fe089f8ac741a95fef47e0a73a3f3cdf21b56990638f626ea0'
             '5db36cbb0686b8a503941779c821febc4a0330dc260e51d603f7aa1e4d8860ad'
             'af3648ddb2372333b0e428788fd2ffbcfe571653fb46f898a55ae5a202f7e242'
             '51da49e41edac66559d3ec8dd0a152995a51a53e5d1f63f09fa089a8af7e3112'
+            '0497411e54a0461f76ffa204236f5146a2ed0d272ae66afcfabd74090459208b'
             'e6555f4a681227447e94e9f14e11626d50b7e5108aad06088311e87063bc0347'
             '61d6bf45649c728dec5f8d22be5b496ed9d40f52c2c70102696d07133cd1750d'
             'ff3ddb5428cd2ff243558dc0c75b35f470077e9204bbc989ddcba04c866c1b68')
@@ -93,6 +95,9 @@ prepare() {
   # Fix build with GCC6 (Fedora)
   patch -p1 -i "$srcdir"/qt4-gcc6.patch
 
+  # Fix build with GCC-8.3
+  patch -Np0 -i "$srcdir"/qt4-gcc8.patch
+
   # Fix build of Qt4 applications with glibc 2.25 (Fedora)
   patch -p1 -i "$srcdir"/qt4-glibc-2.25.patch
 
diff --git a/qt4-gcc8.patch b/qt4-gcc8.patch
new file mode 100644
index 000000000000..8ccb84dff47f
--- /dev/null
+++ b/qt4-gcc8.patch
@@ -0,0 +1,314 @@
+--- src/3rdparty/javascriptcore/JavaScriptCore/jit/JITStubs.cpp	2015-05-07 17:14:48.000000000 +0300
++++ src/3rdparty/javascriptcore/JavaScriptCore/jit/JITStubs.cpp	2019-05-04 13:10:49.491856288 +0300
+@@ -114,11 +114,11 @@
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, code) % 16 == 0x0, JITStackFrame_maintains_16byte_stack_alignment);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, savedEBX) == 0x3c, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x58, JITStackFrame_callFrame_offset_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x50, JITStackFrame_code_offset_matches_ctiTrampoline);
+ 
+-asm volatile (
++asm (
+ ".text\n"
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ SYMBOL_STRING(ctiTrampoline) ":" "\n"
+     "pushl %ebp" "\n"
+@@ -136,11 +136,11 @@
+     "popl %esi" "\n"
+     "popl %ebp" "\n"
+     "ret" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+ #if !USE(JIT_STUB_ARGUMENT_VA_LIST)
+     "movl %esp, %ecx" "\n"
+@@ -152,11 +152,11 @@
+     "popl %esi" "\n"
+     "popl %ebp" "\n"
+     "ret" "\n"
+ );
+     
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+ HIDE_SYMBOL(ctiOpThrowNotCaught) "\n"
+ SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
+     "addl $0x3c, %esp" "\n"
+     "popl %ebx" "\n"
+@@ -177,11 +177,11 @@
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, code) % 32 == 0x0, JITStackFrame_maintains_32byte_stack_alignment);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, savedRBX) == 0x48, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x90, JITStackFrame_callFrame_offset_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x80, JITStackFrame_code_offset_matches_ctiTrampoline);
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ SYMBOL_STRING(ctiTrampoline) ":" "\n"
+     "pushq %rbp" "\n"
+     "movq %rsp, %rbp" "\n"
+@@ -204,11 +204,11 @@
+     "popq %r12" "\n"
+     "popq %rbp" "\n"
+     "ret" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+     "movq %rsp, %rdi" "\n"
+     "call " SYMBOL_STRING_RELOCATION(cti_vm_throw) "\n"
+@@ -220,11 +220,11 @@
+     "popq %r12" "\n"
+     "popq %rbp" "\n"
+     "ret" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+ HIDE_SYMBOL(ctiOpThrowNotCaught) "\n"
+ SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
+     "addq $0x48, %rsp" "\n"
+     "popq %rbx" "\n"
+@@ -240,11 +240,11 @@
+ 
+ #if USE(JIT_STUB_ARGUMENT_VA_LIST)
+ #error "JIT_STUB_ARGUMENT_VA_LIST not supported on ARMv7."
+ #endif
+ 
+-asm volatile (
++asm (
+ ".text" "\n"
+ ".align 2" "\n"
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ ".thumb" "\n"
+@@ -267,11 +267,11 @@
+     "ldr lr, [sp, #0x20]" "\n"
+     "add sp, sp, #0x3c" "\n"
+     "bx lr" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".text" "\n"
+ ".align 2" "\n"
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ ".thumb" "\n"
+@@ -285,11 +285,11 @@
+     "ldr lr, [sp, #0x20]" "\n"
+     "add sp, sp, #0x3c" "\n"
+     "bx lr" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".text" "\n"
+ ".align 2" "\n"
+ ".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+ HIDE_SYMBOL(ctiOpThrowNotCaught) "\n"
+ ".thumb" "\n"
+@@ -303,11 +303,11 @@
+     "bx lr" "\n"
+ );
+ 
+ #elif COMPILER(GCC) && CPU(ARM_TRADITIONAL)
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ SYMBOL_STRING(ctiTrampoline) ":" "\n"
+     "stmdb sp!, {r1-r3}" "\n"
+     "stmdb sp!, {r4-r8, lr}" "\n"
+@@ -321,11 +321,11 @@
+     "ldmia sp!, {r4-r8, lr}" "\n"
+     "add sp, sp, #12" "\n"
+     "mov pc, lr" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+     "mov r0, sp" "\n"
+     "bl " SYMBOL_STRING(cti_vm_throw) "\n"
+@@ -416,11 +416,11 @@
+ // need to change the assembly trampolines below to match.
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x38, JITStackFrame_callFrame_offset_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x30, JITStackFrame_code_offset_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, savedEBX) == 0x1c, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
+ 
+-asm volatile (
++asm (
+ ".text\n"
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ SYMBOL_STRING(ctiTrampoline) ":" "\n"
+     "pushl %ebp" "\n"
+@@ -438,11 +438,11 @@
+     "popl %esi" "\n"
+     "popl %ebp" "\n"
+     "ret" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+ #if !USE(JIT_STUB_ARGUMENT_VA_LIST)
+     "movl %esp, %ecx" "\n"
+@@ -454,11 +454,11 @@
+     "popl %esi" "\n"
+     "popl %ebp" "\n"
+     "ret" "\n"
+ );
+     
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+ HIDE_SYMBOL(ctiOpThrowNotCaught) "\n"
+ SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
+     "addl $0x1c, %esp" "\n"
+     "popl %ebx" "\n"
+@@ -478,11 +478,11 @@
+ // need to change the assembly trampolines below to match.
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x58, JITStackFrame_callFrame_offset_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x48, JITStackFrame_code_offset_matches_ctiTrampoline);
+ COMPILE_ASSERT(offsetof(struct JITStackFrame, savedRBX) == 0x78, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
+ 
+-asm volatile (
++asm (
+ ".text\n"
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ SYMBOL_STRING(ctiTrampoline) ":" "\n"
+     "pushq %rbp" "\n"
+@@ -513,11 +513,11 @@
+     "popq %r12" "\n"
+     "popq %rbp" "\n"
+     "ret" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+     "movq %rsp, %rdi" "\n"
+     "call " SYMBOL_STRING_RELOCATION(cti_vm_throw) "\n"
+@@ -529,11 +529,11 @@
+     "popq %r12" "\n"
+     "popq %rbp" "\n"
+     "ret" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+ HIDE_SYMBOL(ctiOpThrowNotCaught) "\n"
+ SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
+     "addq $0x78, %rsp" "\n"
+     "popq %rbx" "\n"
+@@ -549,11 +549,11 @@
+ 
+ #if USE(JIT_STUB_ARGUMENT_VA_LIST)
+ #error "JIT_STUB_ARGUMENT_VA_LIST not supported on ARMv7."
+ #endif
+ 
+-asm volatile (
++asm (
+ ".text" "\n"
+ ".align 2" "\n"
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ ".thumb" "\n"
+@@ -576,11 +576,11 @@
+     "ldr lr, [sp, #0x20]" "\n"
+     "add sp, sp, #0x40" "\n"
+     "bx lr" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".text" "\n"
+ ".align 2" "\n"
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ ".thumb" "\n"
+@@ -594,11 +594,11 @@
+     "ldr lr, [sp, #0x20]" "\n"
+     "add sp, sp, #0x40" "\n"
+     "bx lr" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".text" "\n"
+ ".align 2" "\n"
+ ".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+ HIDE_SYMBOL(ctiOpThrowNotCaught) "\n"
+ ".thumb" "\n"
+@@ -612,11 +612,11 @@
+     "bx lr" "\n"
+ );
+ 
+ #elif COMPILER(GCC) && CPU(ARM_TRADITIONAL)
+ 
+-asm volatile (
++asm (
+ ".text\n"
+ ".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+ HIDE_SYMBOL(ctiTrampoline) "\n"
+ SYMBOL_STRING(ctiTrampoline) ":" "\n"
+     "stmdb sp!, {r1-r3}" "\n"
+@@ -630,11 +630,11 @@
+     "ldmia sp!, {r4-r8, lr}" "\n"
+     "add sp, sp, #12" "\n"
+     "mov pc, lr" "\n"
+ );
+ 
+-asm volatile (
++asm (
+ ".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+ HIDE_SYMBOL(ctiVMThrowTrampoline) "\n"
+ SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+     "mov r0, sp" "\n"
+     "bl " SYMBOL_STRING_RELOCATION(cti_vm_throw) "\n"
+@@ -1022,11 +1022,11 @@
+ 
+ #define DEFINE_STUB_FUNCTION(rtype, op) \
+     extern "C" { \
+         rtype JITStubThunked_##op(STUB_ARGS_DECLARATION); \
+     }; \
+-    asm volatile ( \
++    asm ( \
+         ".text" "\n" \
+         ".align 2" "\n" \
+         ".globl " SYMBOL_STRING(cti_##op) "\n" \
+         HIDE_SYMBOL(cti_##op) "\n"             \
+         ".thumb" "\n" \
+@@ -1051,11 +1051,11 @@
+ 
+ #define DEFINE_STUB_FUNCTION(rtype, op) \
+     extern "C" { \
+         rtype JITStubThunked_##op(STUB_ARGS_DECLARATION); \
+     }; \
+-    asm volatile ( \
++    asm ( \
+         ".globl " SYMBOL_STRING(cti_##op) "\n" \
+         HIDE_SYMBOL(cti_##op) "\n"             \
+         SYMBOL_STRING(cti_##op) ":" "\n" \
+         "str lr, [sp, #" STRINGIZE_VALUE_OF(THUNK_RETURN_ADDRESS_OFFSET) "]" "\n" \
+         "bl " SYMBOL_STRING(JITStubThunked_##op) "\n" \