Add pkgdesc, fix variable quoting, 'cd ... || exit' because why not

1 files changed, 18 insertions, 18 deletions

diff --git a/PKGBUILD b/PKGBUILD
index 085e93a93a40..dd2b0d83e061 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -6,7 +6,8 @@
 pkgname=davinci-resolve
 _pkgname=resolve
 pkgver=12.5.5
-pkgrel=1
+pkgrel=2
+pkgdesc='Professional A/V post-production software suite'
 arch=('x86_64')
 url="https://www.blackmagicdesign.com/"
 license=('Commercial')
@@ -17,23 +18,22 @@ source=("local://DaVinci_Resolve_${pkgver}_Linux.zip")
 sha256sums=('d0235480f400f531729ceec2e5daf5334191d1a59d3c32c5e0d8b32c69f88b38')
 
 package() {
-	mkdir -p ${pkgdir}/opt/${_pkgname}/configs
+	mkdir -p "${pkgdir}/opt/${_pkgname}/{bin,configs}"
 
 	msg2 "Extracting from bundle..."
-	cd ${srcdir}
-	./DaVinci_Resolve_${pkgver}_Linux.sh --tar xf -C ${pkgdir}/opt/${_pkgname}
+	cd "${srcdir}" || exit
+	./DaVinci_Resolve_${pkgver}_Linux.sh --tar xf -C "${pkgdir}/opt/${_pkgname}"
 
 	msg2 "Extracting library archives..."
-	cd ${pkgdir}/opt/${_pkgname}/
+	cd "${pkgdir}/opt/${_pkgname}/" || exit
 	gunzip -f LUT/trim_lut0.dpx.gz
 	for archive in libs/*tgz; do
-		tar xf ${archive} -C libs/
-		rm ${archive}
+		tar xf "${archive}" -C libs/
+		rm -f "${archive}"
 	done
 
 	msg2 "Relocate binaries and config..."
-	cd ${pkgdir}/opt/${_pkgname}/
-	mkdir -p bin
+	cd "${pkgdir}/opt/${_pkgname}/" || exit
 	local _binaries=(
 		BMDPanelFirmware
 		DPDecoder
@@ -47,22 +47,22 @@ package() {
 		qt.conf
 	)
 	for binary in "${_binaries[@]}"; do
-		mv rsf/${binary} bin/${binary}
+		mv "rsf/${binary}" "bin/${binary}"
 	done
 	mv resolve bin/resolve
 	mv rsf/Control Control
 	cp rsf/default-config-linux.dat configs/config.dat
 
 	msg2 "Add lib symlinks..."
-	cd ${pkgdir}/opt/${_pkgname}/
+	cd "${pkgdir}/opt/${_pkgname}/" || exit
 	ln -s /usr/lib/libcrypto.so libs/libcrypto.so.10
 	ln -s /usr/lib/libssl.so    libs/libssl.so.10
 	ln -s /usr/lib/libgstbase-1.0.so   libs/libgstbase-0.10.so.0
 	ln -s /usr/lib/libgstreamer-1.0.so libs/libgstreamer-0.10.so.0
 
 	msg2 "Creating launchers..."
-	cd ${srcdir}
-	cat > ${srcdir}/DaVinci\ Resolve.desktop << EOF
+	cd "${srcdir}" || exit
+	cat > "${srcdir}/DaVinci Resolve.desktop" << EOF
 #!/usr/bin/env xdg-open
 [Desktop Entry]
 Type=Application
@@ -73,20 +73,20 @@ Icon=/opt/${_pkgname}/rsf/DV_Resolve.png
 Terminal=false
 Categories=Multimedia;AudioVideo;Application;
 EOF
-	install -Dm644 DaVinci\ Resolve.desktop ${pkgdir}/usr/share/applications/DaVinci\ Resolve.desktop
+	install -Dm644 DaVinci\ Resolve.desktop "${pkgdir}/usr/share/applications/DaVinci Resolve.desktop"
 
-	cat > ${srcdir}/start-resolve << EOF
+	cat > "${srcdir}/start-resolve" << EOF
 #!/bin/sh
 export LD_LIBRARY_PATH=/opt/${_pkgname}/libs
 exec /opt/${_pkgname}/bin/resolve "\$@"
 EOF
-	install -Dm755 start-resolve ${pkgdir}/opt/${_pkgname}/bin/start-resolve
+	install -Dm755 start-resolve "${pkgdir}/opt/${_pkgname}/bin/start-resolve"
 
 	msg2 "Making sure file ownership is correct..."
-	chown -R root:root ${pkgdir}/opt
+	chown -R root:root "${pkgdir}/opt"
 
 	msg2 "Any final tweaks..."
-	ln -s /tmp ${pkgdir}/opt/${_pkgname}/logs
+	ln -s /tmp "${pkgdir}/opt/${_pkgname}/logs"
 
 	msg2 "Done!"
 }