summarylogtreecommitdiffstats
path: root/i915-vga-arbiter.patch
diff options
context:
space:
mode:
authorShayne Hartford2019-04-10 10:49:38 -0400
committerShayne Hartford2019-04-10 10:49:38 -0400
commit53faef76c4becc8e1030d1616db191a70e3b9e9f (patch)
treef0d0071c26748242d52eb4061beac695af67f5fb /i915-vga-arbiter.patch
downloadaur-53faef76c4becc8e1030d1616db191a70e3b9e9f.tar.gz
Added kernel
Diffstat (limited to 'i915-vga-arbiter.patch')
-rw-r--r--i915-vga-arbiter.patch185
1 files changed, 185 insertions, 0 deletions
diff --git a/i915-vga-arbiter.patch b/i915-vga-arbiter.patch
new file mode 100644
index 000000000000..c2e147ae060c
--- /dev/null
+++ b/i915-vga-arbiter.patch
@@ -0,0 +1,185 @@
+From a95d3e5bab8d9d6482e81f1c3ea24c16acb2cb42 Mon Sep 17 00:00:00 2001
+From: Mark Weiman <mark.weiman@markzz.com>
+Date: Wed, 12 Dec 2018 10:31:24 -0500
+Subject: [PATCH] i915: Add module option to support VGA arbiter on HD devices
+ (4.19)
+
+This is an updated version of Alex Williamson's patch from:
+https://lkml.org/lkml/2014/5/9/517
+I don't have i915 graphics, so this is completely untested.
+
+Original commit message follows:
+---
+Commit 81b5c7bc found that the current VGA arbiter support in i915
+only works for ancient GMCH-based IGD devices and attempted to update
+support for newer HD devices. Unfortunately newer devices cannot
+completely opt-out of VGA arbitration like the old devices could.
+The VGA I/O space cannot be disabled internally. The only way to
+route VGA I/O elsewhere is by disabling I/O at the device PCI command
+register. This means that with commit 81b5c7bc and multiple VGA
+adapters, the VGA arbiter will report that multiple VGA devices are
+participating in arbitration, Xorg will notice this and disable DRI.
+Therefore, 81b5c7bc was reverted because DRI is more important than
+being correct.
+
+There is however an actual need for i915 to correctly participate in
+VGA arbitration; VGA device assignment. If we want to use VFIO to
+assign a VGA device to a virtual machine, we need to be able to
+access the VGA resources of that device. By adding an i915 module
+option we can allow i915 to continue with its charade by default, but
+also allow an easy path for users who require working VGA arbitration.
+Hopefully Xorg can someday be taught to behave better with multiple
+VGA devices.
+
+This also rolls in reverted commit 6e1b4fda, which corrected an
+ordering issue with 81b5c7bc by delaying the disabling of VGA memory
+until after vgacon->fbcon handoff.
+---
+ drivers/gpu/drm/i915/i915_drv.c | 23 +++++++++++++++----
+ drivers/gpu/drm/i915/i915_params.c | 3 +++
+ drivers/gpu/drm/i915/i915_params.h | 1 +
+ drivers/gpu/drm/i915/intel_display.c | 33 ++++++++++++++++++++++++++++
+ drivers/gpu/drm/i915/intel_drv.h | 1 +
+ 5 files changed, 57 insertions(+), 4 deletions(-)
+
+diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
+index f8cfd16be534..f5ba210d7b00 100644
+--- a/drivers/gpu/drm/i915/i915_drv.c
++++ b/drivers/gpu/drm/i915/i915_drv.c
+@@ -650,11 +650,20 @@ static int i915_load_modeset_init(struct drm_device *dev)
+ * If we are a secondary display controller (!PCI_DISPLAY_CLASS_VGA),
+ * then we do not take part in VGA arbitration and the
+ * vga_client_register() fails with -ENODEV.
++ *
++ * NB. The set_decode callback here actually works on GMCH
++ * devices, on newer HD devices we can only disable VGA MMIO space.
++ * Disabling VGA I/O space requires disabling I/O in the PCI command
++ * register. Nonetheless, we like to pretend that we participate in
++ * VGA arbitration and can dynamically disable VGA I/O space because
++ * this makes X happy, even though it's a complete lie.
+ */
+- ret = vga_client_register(pdev, dev_priv, NULL, i915_vga_set_decode);
+- if (ret && ret != -ENODEV)
+- goto out;
+-
++ if (!i915_modparams.enable_hd_vgaarb || !HAS_PCH_SPLIT(dev_priv)) {
++ ret = vga_client_register(pdev, dev, NULL,
++ i915_vga_set_decode);
++ if (ret && ret != -ENODEV)
++ goto out;
++ }
+ intel_register_dsm_handler();
+
+ ret = vga_switcheroo_register_client(pdev, &i915_switcheroo_ops, false);
+@@ -693,6 +702,12 @@ static int i915_load_modeset_init(struct drm_device *dev)
+ if (ret)
+ goto cleanup_gem;
+
++ /*
++ * Must do this after fbcon init so that
++ * vgacon_save_screen() works during the handover.
++ */
++ i915_disable_vga_mem(dev_priv);
++
+ /* Only enable hotplug handling once the fbdev is fully set up. */
+ intel_hpd_init(dev_priv);
+
+diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
+index 295e981e4a39..243edeee97dd 100644
+--- a/drivers/gpu/drm/i915/i915_params.c
++++ b/drivers/gpu/drm/i915/i915_params.c
+@@ -126,6 +126,9 @@ i915_param_named_unsafe(invert_brightness, int, 0600,
+ i915_param_named(disable_display, bool, 0400,
+ "Disable display (default: false)");
+
++i915_param_named(enable_hd_vgaarb, bool, 0444,
++ "Enable support for VGA arbitration on Intel HD IGD. (default: false)");
++
+ i915_param_named(mmio_debug, int, 0600,
+ "Enable the MMIO debug code for the first N failures (default: off). "
+ "This may negatively affect performance.");
+diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
+index 6c4d4a21474b..72b9bca3cc14 100644
+--- a/drivers/gpu/drm/i915/i915_params.h
++++ b/drivers/gpu/drm/i915/i915_params.h
+@@ -57,6 +57,7 @@ struct drm_printer;
+ param(unsigned int, inject_load_failure, 0) \
+ /* leave bools at the end to not create holes */ \
+ param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
++ param(bool, enable_hd_vgaarb, false) \
+ param(bool, enable_hangcheck, true) \
+ param(bool, fastboot, false) \
+ param(bool, prefault_disable, false) \
+diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
+index 3bd44d042a1d..b1aaa966679b 100644
+--- a/drivers/gpu/drm/i915/intel_display.c
++++ b/drivers/gpu/drm/i915/intel_display.c
+@@ -15025,6 +15025,36 @@ static void i915_disable_vga(struct drm_i915_private *dev_priv)
+ POSTING_READ(vga_reg);
+ }
+
++static void i915_enable_vga_mem(struct drm_i915_private *dev_priv)
++{
++ struct pci_dev *pdev = dev_priv->drm.pdev;
++
++ /* Enable VGA memory on Intel HD */
++ if (i915_modparams.enable_hd_vgaarb && HAS_PCH_SPLIT(dev_priv)) {
++ vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
++ outb(inb(VGA_MSR_READ) | VGA_MSR_MEM_EN, VGA_MSR_WRITE);
++ vga_set_legacy_decoding(pdev, VGA_RSRC_LEGACY_IO |
++ VGA_RSRC_LEGACY_MEM |
++ VGA_RSRC_NORMAL_IO |
++ VGA_RSRC_NORMAL_MEM);
++ vga_put(pdev, VGA_RSRC_LEGACY_IO);
++ }
++}
++
++void i915_disable_vga_mem(struct drm_i915_private *dev_priv)
++{
++ struct pci_dev *pdev = dev_priv->drm.pdev;
++ /* Disable VGA memory on Intel HD */
++ if (i915_modparams.enable_hd_vgaarb && HAS_PCH_SPLIT(dev_priv)) {
++ vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
++ outb(inb(VGA_MSR_READ) & ~VGA_MSR_MEM_EN, VGA_MSR_WRITE);
++ vga_set_legacy_decoding(pdev, VGA_RSRC_LEGACY_IO |
++ VGA_RSRC_NORMAL_IO |
++ VGA_RSRC_NORMAL_MEM);
++ vga_put(pdev, VGA_RSRC_LEGACY_IO);
++ }
++}
++
+ void intel_modeset_init_hw(struct drm_device *dev)
+ {
+ struct drm_i915_private *dev_priv = to_i915(dev);
+@@ -15540,6 +15570,7 @@ void i915_redisable_vga_power_on(struct drm_i915_private *dev_priv)
+ if (!(I915_READ(vga_reg) & VGA_DISP_DISABLE)) {
+ DRM_DEBUG_KMS("Something enabled VGA plane, disabling it\n");
+ i915_disable_vga(dev_priv);
++ i915_disable_vga_mem(dev_priv);
+ }
+ }
+
+@@ -15946,6 +15977,8 @@ void intel_modeset_cleanup(struct drm_device *dev)
+ {
+ struct drm_i915_private *dev_priv = to_i915(dev);
+
++ i915_enable_vga_mem(dev_priv);
++
+ flush_workqueue(dev_priv->modeset_wq);
+
+ flush_work(&dev_priv->atomic_helper.free_work);
+diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
+index 8fc61e96754f..c1271e41e592 100644
+--- a/drivers/gpu/drm/i915/intel_drv.h
++++ b/drivers/gpu/drm/i915/intel_drv.h
+@@ -1486,6 +1486,7 @@ int vlv_get_cck_clock_hpll(struct drm_i915_private *dev_priv,
+ const char *name, u32 reg);
+ void lpt_disable_pch_transcoder(struct drm_i915_private *dev_priv);
+ void lpt_disable_iclkip(struct drm_i915_private *dev_priv);
++extern void i915_disable_vga_mem(struct drm_i915_private *dev_priv);
+ void intel_init_display_hooks(struct drm_i915_private *dev_priv);
+ unsigned int intel_fb_xy_to_linear(int x, int y,
+ const struct intel_plane_state *state,
+--
+2.20.0
+