Better code courtesy of /r/linux

1 files changed, 9 insertions, 17 deletions

diff --git a/new_folder_with_selection.sh b/new_folder_with_selection.sh
index 9b392b702304..4d5194e31046 100755
--- a/new_folder_with_selection.sh
+++ b/new_folder_with_selection.sh
@@ -1,21 +1,13 @@
-#!/bin/bash
+#!/bin/sh
 
-SAVEIFS=$IFS
-IFS=$(echo -en "\n\b")
+dirname="$(kdialog \
+  --inputbox "Folder to be created" "New Folder" \
+  --title "Create New Folder with selection" \
+  --caption "Dolphin" --icon "dolphin" \
+  )" &&
 
-foldname=`kdialog --inputbox "Folder to be created" "New Folder" --title "Create New Folder with Selection" --caption "Dolphin" --icon "dolphin"`
+mkdir -p -- "$dirname" &&
 
-if [ $? = 0 ]; then
-	dir=`dirname $1`
-	mkdir "$dir"/"$foldname"
+mv --target-directory="$dirname" -- "$@" ||
 
-if [ $? = 1 ]; then
-	kdialog --error "Invalid Name"
-	else
-	for file in ${@} ; do
-	mv "$file" -t "$dir"/"$foldname"
-	done
-fi
-fi
-
-IFS=$SAVEIFS
+kdialog --error "Something went wrong"