diff options
author | Mark Weiman | 2017-03-16 13:57:36 -0400 |
---|---|---|
committer | Mark Weiman | 2017-03-16 13:57:36 -0400 |
commit | baec09cbd7b32c856a5d5875fff29b85e20c0dc3 (patch) | |
tree | b9c656826ce28cfb1329d239d262d14ef7605435 /override_for_missing_acs_capabilities.patch | |
parent | c3a4ce7ddb1cd7bdff4565f70262d1baede02cfb (diff) | |
download | aur-baec09cbd7b32c856a5d5875fff29b85e20c0dc3.tar.gz |
Update to 4.9.15-1
Diffstat (limited to 'override_for_missing_acs_capabilities.patch')
-rw-r--r-- | override_for_missing_acs_capabilities.patch | 138 |
1 files changed, 93 insertions, 45 deletions
diff --git a/override_for_missing_acs_capabilities.patch b/override_for_missing_acs_capabilities.patch index 1c0b02cc2377..c0d72e4d0fd5 100644 --- a/override_for_missing_acs_capabilities.patch +++ b/override_for_missing_acs_capabilities.patch @@ -1,29 +1,83 @@ -diff -rupN linux-3.15.old/Documentation/kernel-parameters.txt linux-3.15/Documentation/kernel-parameters.txt ---- linux-3.15.old/Documentation/kernel-parameters.txt 2014-06-08 15:19:54.000000000 -0300 -+++ linux-3.15/Documentation/kernel-parameters.txt 2014-06-09 18:05:31.744055580 -0300 -@@ -2554,6 +2554,16 @@ bytes respectively. Such letter suffixes - nomsi Do not use MSI for native PCIe PME signaling (this makes - all PCIe root ports use INTx for all services). +From 866f4c5de45ae13aa590de0d40819a0c38f3f682 Mon Sep 17 00:00:00 2001 +From: Mark Weiman <mark.weiman@markzz.com> +Date: Sun, 23 Oct 2016 12:57:37 -0400 +Subject: [PATCH] pci: Enable overrides for missing ACS capabilities (4.8+) + +This an updated version of Alex Williamson's patch from: +https://lkml.org/lkml/2013/5/30/513 + +Original commit message follows: +--- +PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that +allows us to control whether transactions are allowed to be redirected +in various subnodes of a PCIe topology. For instance, if two +endpoints are below a root port or downsteam switch port, the +downstream port may optionally redirect transactions between the +devices, bypassing upstream devices. The same can happen internally +on multifunction devices. The transaction may never be visible to the +upstream devices. + +One upstream device that we particularly care about is the IOMMU. If +a redirection occurs in the topology below the IOMMU, then the IOMMU +cannot provide isolation between devices. This is why the PCIe spec +encourages topologies to include ACS support. Without it, we have to +assume peer-to-peer DMA within a hierarchy can bypass IOMMU isolation. + +Unfortunately, far too many topologies do not support ACS to make this +a steadfast requirement. Even the latest chipsets from Intel are only +sporadically supporting ACS. We have trouble getting interconnect +vendors to include the PCIe spec required PCIe capability, let alone +suggested features. + +Therefore, we need to add some flexibility. The pcie_acs_override= +boot option lets users opt-in specific devices or sets of devices to +assume ACS support. The "downstream" option assumes full ACS support +on root ports and downstream switch ports. The "multifunction" +option assumes the subset of ACS features available on multifunction +endpoints and upstream switch ports are supported. The "id:nnnn:nnnn" +option enables ACS support on devices matching the provided vendor +and device IDs, allowing more strategic ACS overrides. These options +may be combined in any order. A maximum of 16 id specific overrides +are available. It's suggested to use the most limited set of options +necessary to avoid completely disabling ACS across the topology. +Note to hardware vendors, we have facilities to permanently quirk +specific devices which enforce isolation but not provide an ACS +capability. Please contact me to have your devices added and save +your customers the hassle of this boot option. + +Signed-off-by: Mark Weiman <mark.weiman@markzz.com> +--- + Documentation/kernel-parameters.txt | 9 ++++ + drivers/pci/quirks.c | 101 ++++++++++++++++++++++++++++++++++++ + 2 files changed, 110 insertions(+) + +diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt +index a4f4d69..d68cfab 100644 +--- a/Documentation/kernel-parameters.txt ++++ b/Documentation/kernel-parameters.txt +@@ -2928,6 +2928,15 @@ bytes respectively. Such letter suffixes can also be entirely omitted. + nomsi [MSI] If the PCI_MSI kernel config parameter is + enabled, this kernel boot option can be used to + disable the use of MSI interrupts system-wide. ++ pci_acs_override = ++ [PCIE] Override missing PCIe ACS support for: ++ downstream ++ All downstream ports - full ACS capabilities ++ multfunction ++ All multifunction devices - multifunction ACS subset ++ id:nnnn:nnnn ++ Specfic device - full ACS capabilities ++ Specified as vid:did (vendor/device ID) in hex + noioapicquirk [APIC] Disable all boot interrupt quirks. + Safety option to keep boot IRQs enabled. This + should never be necessary. +diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c +index 44e0ff3..32016cb 100644 +--- a/drivers/pci/quirks.c ++++ b/drivers/pci/quirks.c +@@ -3487,6 +3487,106 @@ static int __init pci_apply_final_quirks(void) -+ pcie_acs_override = -+ [PCIE] Override missing PCIe ACS support for: -+ downstream -+ All downstream ports - full ACS capabilties -+ multifunction -+ All multifunction devices - multifunction ACS subset -+ id:nnnn:nnnn -+ Specfic device - full ACS capabilities -+ Specified as vid:did (vendor/device ID) in hex -+ - pcmv= [HW,PCMCIA] BadgePAD 4 - - pd_ignore_unused -diff -rupN linux-3.15.old/drivers/pci/quirks.c linux-3.15/drivers/pci/quirks.c ---- linux-3.15.old/drivers/pci/quirks.c 2014-06-08 15:19:54.000000000 -0300 -+++ linux-3.15/drivers/pci/quirks.c 2014-06-09 18:06:36.688743183 -0300 -@@ -3384,6 +3384,107 @@ struct pci_dev *pci_get_dma_source(struc - return pci_dev_get(dev); - } + fs_initcall_sync(pci_apply_final_quirks); +static bool acs_on_downstream; +static bool acs_on_multifunction; @@ -53,7 +107,7 @@ diff -rupN linux-3.15.old/drivers/pci/quirks.c linux-3.15/drivers/pci/quirks.c + + if (max_acs_id >= NUM_ACS_IDS - 1) { + pr_warn("Out of PCIe ACS override slots (%d)\n", -+ NUM_ACS_IDS); ++ NUM_ACS_IDS); + goto next; + } + @@ -67,7 +121,7 @@ diff -rupN linux-3.15.old/drivers/pci/quirks.c linux-3.15/drivers/pci/quirks.c + acs_on_ids[max_acs_id].vendor = val; + + p += strcspn(p, ":"); -+ if (*p != ':') { ++ if (*p != ';') { + pr_warn("PCIe ACS invalid ID\n"); + goto next; + } @@ -101,13 +155,13 @@ diff -rupN linux-3.15.old/drivers/pci/quirks.c linux-3.15/drivers/pci/quirks.c + + /* Never override ACS for legacy devices or devices with ACS caps */ + if (!pci_is_pcie(dev) || -+ pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS)) -+ return -ENOTTY; ++ pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS)) ++ return -ENOTTY; + + for (i = 0; i < max_acs_id; i++) + if (acs_on_ids[i].vendor == dev->vendor && -+ acs_on_ids[i].device == dev->device) -+ return 1; ++ acs_on_ids[i].device == dev->device) ++ return 1; + + switch (pci_pcie_type(dev)) { + case PCI_EXP_TYPE_DOWNSTREAM: @@ -125,23 +179,17 @@ diff -rupN linux-3.15.old/drivers/pci/quirks.c linux-3.15/drivers/pci/quirks.c + + return -ENOTTY; +} -+ /* - * AMD has indicated that the devices below do not support peer-to-peer - * in any system where they are found in the southbridge with an AMD -@@ -3483,6 +3584,7 @@ static int pci_quirk_intel_pch_acs(struc - return acs_flags & ~flags ? 0 : 1; - } - -+ - static const struct pci_dev_acs_enabled { - u16 vendor; - u16 device; -@@ -3495,6 +3597,7 @@ static const struct pci_dev_acs_enabled - { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_pch_acs }, - { 0x19a2, 0x710, pci_quirk_mf_endpoint_acs }, /* Emulex BE3-R */ + * Followings are device-specific reset methods which can be used to + * reset a single function if other methods (e.g. FLR, PM D0->D3) are +@@ -4160,6 +4260,7 @@ static const struct pci_dev_acs_enabled { { 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R */ + /* Cavium ThunderX */ + { PCI_VENDOR_ID_CAVIUM, PCI_ANY_ID, pci_quirk_cavium_acs }, + { PCI_ANY_ID, PCI_ANY_ID, pcie_acs_overrides }, { 0 } }; +-- +2.10.1 + |