selinux-alpm-hook 0.1-3 update

Call restorecon in batches in order to improve performance. It it not
possible to pipe the list of package files into "| xargs restorecon -F"
because restorecon could fail sometimes (for example when there is an
invalid file on the filesystem which makes calls to getxattr() fail).

Implement a simple filter as a while loop which sanitizes the list of
packages files before running restorecon on it, in batches handled by
xargs.

1 files changed, 4 insertions, 3 deletions

diff --git a/selinux-alpm-hook b/selinux-alpm-hook
index 15abf73bd858..9ac5b060753f 100755
--- a/selinux-alpm-hook
+++ b/selinux-alpm-hook
@@ -22,12 +22,13 @@ fi
 echo 'Relabeling package files...'
 while read -r FILE; do
     if [ -e "$FILE" ] || [ -L "$FILE" ] ; then
-        /usr/bin/restorecon -F "$FILE" || die "Error while relabeling $FILE"
+        # Transmit existing files to restorecon
+        printf '%s\0' "$FILE"
     else
         # Only show a warning when a file does not exist as this is not fatal
-        echo "Ugh, an installed file does not exist: $FILE"
+        echo >&2 "Ugh, an installed file does not exist: $FILE"
     fi
-done
+done | xargs -0 /usr/bin/restorecon -F || die "Error while relabeling files"
 
 # The install hooks of packages create files which got labelled with the wrong SELinux user
 # (e.g. sysadm_u instead of system_u). Relabel all these files too.