diff options
Diffstat (limited to '0007-rx-update_nextCid-overflow-handling-is-broken.patch')
| -rw-r--r-- | 0007-rx-update_nextCid-overflow-handling-is-broken.patch | 26 |
1 files changed, 18 insertions, 8 deletions
diff --git a/0007-rx-update_nextCid-overflow-handling-is-broken.patch b/0007-rx-update_nextCid-overflow-handling-is-broken.patch index d5a351f9a1f8..1b17517095fb 100644 --- a/0007-rx-update_nextCid-overflow-handling-is-broken.patch +++ b/0007-rx-update_nextCid-overflow-handling-is-broken.patch @@ -1,12 +1,14 @@ -From 99e01a0237ea3af6bf859ceeb2f53ed0755c75dd Mon Sep 17 00:00:00 2001 +From 270097d094d7dd9576f4808cd3d6c937ba8e053c Mon Sep 17 00:00:00 2001 From: Jeffrey Altman <jaltman@auristor.com> Date: Thu, 14 Jan 2021 09:57:13 -0500 -Subject: [PATCH 7/7] rx: update_nextCid overflow handling is broken +Subject: [PATCH 7/8] rx: update_nextCid overflow handling is broken The overflow handling in update_nextCid() produces a rx_nextCid -value of 0x80000001 which itself is an overflow. When used -to construct the first call of a new connection the connection -id for the call becomes 0x80000002. +value of 0x80000001 which itself is out of the valid range. When +used to construct the first call of a new connection the connection +id for the call becomes 0x80000002, and all subsequent connections +also trigger the overflow handling and thus also receive connection +id 0x80000002. If the same connection id is used for multiple connections from the same endpoint the accepting rx peer will be very confused. @@ -15,8 +17,10 @@ When authenticated connections are used, the CHALLENGE/RESPONSE will fail because of a mismatch in the connection's callNumber array. -All communication from a broken initiator to any rx peer will -fail. +If an initiator makes only a single connection to a given rx peer, +that connection would succeed, but once multiple connections are +initiated all communication from a broken initiator to any rx peer +will fail. The incorrect overflow calculation was introduced by 39b165cdda941181845022c183fea1c7af7e4356 ("Move epoch and cid @@ -26,7 +30,13 @@ This change corrects the overflow value to become 1 << RX_CIDSHIFT -Change-Id: If36e3aa581d557cc0f4d2d478f84a6593224c3cc +Reviewed-on: https://gerrit.openafs.org/14492 +Reviewed-by: Andrew Deason <adeason@sinenomine.net> +Reviewed-by: Benjamin Kaduk <kaduk@mit.edu> +Tested-by: Benjamin Kaduk <kaduk@mit.edu> +(cherry picked from commit 2c0a3901cbfcb231b7b67eb0899a3133516f33c8) + +Change-Id: I74d70706ddf99022bed639891cb610fba9ef863d --- src/rx/rx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) |