diff options
Diffstat (limited to '0133-virtio-pci-Remove-wrong-address-verification-in-vp_d.patch')
| -rw-r--r-- | 0133-virtio-pci-Remove-wrong-address-verification-in-vp_d.patch | 52 |
1 files changed, 52 insertions, 0 deletions
diff --git a/0133-virtio-pci-Remove-wrong-address-verification-in-vp_d.patch b/0133-virtio-pci-Remove-wrong-address-verification-in-vp_d.patch new file mode 100644 index 000000000000..1f0527600bbe --- /dev/null +++ b/0133-virtio-pci-Remove-wrong-address-verification-in-vp_d.patch @@ -0,0 +1,52 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Murilo Opsfelder Araujo <muriloo@linux.ibm.com> +Date: Thu, 14 Apr 2022 23:30:02 -0300 +Subject: [PATCH] virtio-pci: Remove wrong address verification in vp_del_vqs() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +commit 7e415282b41bf0d15c6e0fe268f822d9b083f2f7 upstream. + +GCC 12 enhanced -Waddress when comparing array address to null [0], +which warns: + + drivers/virtio/virtio_pci_common.c: In function ‘vp_del_vqs’: + drivers/virtio/virtio_pci_common.c:257:29: warning: the comparison will always evaluate as ‘true’ for the pointer operand in ‘vp_dev->msix_affinity_masks + (sizetype)((long unsigned int)i * 256)’ must not be NULL [-Waddress] + 257 | if (vp_dev->msix_affinity_masks[i]) + | ^~~~~~ + +In fact, the verification is comparing the result of a pointer +arithmetic, the address "msix_affinity_masks + i", which will always +evaluate to true. + +Under the hood, free_cpumask_var() calls kfree(), which is safe to pass +NULL, not requiring non-null verification. So remove the verification +to make compiler happy (happy compiler, happy life). + +[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102103 + +Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com> +Message-Id: <20220415023002.49805-1-muriloo@linux.ibm.com> +Signed-off-by: Michael S. Tsirkin <mst@redhat.com> +Acked-by: Christophe de Dinechin <dinechin@redhat.com> +Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> +Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +--- + drivers/virtio/virtio_pci_common.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c +index d724f676608ba34a973803eb8643bf3bba604262..5046efcffb4c042cb62d6c9c5ae4e0163b3202ae 100644 +--- a/drivers/virtio/virtio_pci_common.c ++++ b/drivers/virtio/virtio_pci_common.c +@@ -254,8 +254,7 @@ void vp_del_vqs(struct virtio_device *vdev) + + if (vp_dev->msix_affinity_masks) { + for (i = 0; i < vp_dev->msix_vectors; i++) +- if (vp_dev->msix_affinity_masks[i]) +- free_cpumask_var(vp_dev->msix_affinity_masks[i]); ++ free_cpumask_var(vp_dev->msix_affinity_masks[i]); + } + + if (vp_dev->msix_enabled) { |