summarylogtreecommitdiffstats
path: root/f4f62699e5d5b821e83dc2f902d486cf5c2b2755.patch
diff options
context:
space:
mode:
Diffstat (limited to 'f4f62699e5d5b821e83dc2f902d486cf5c2b2755.patch')
-rw-r--r--f4f62699e5d5b821e83dc2f902d486cf5c2b2755.patch32
1 files changed, 0 insertions, 32 deletions
diff --git a/f4f62699e5d5b821e83dc2f902d486cf5c2b2755.patch b/f4f62699e5d5b821e83dc2f902d486cf5c2b2755.patch
deleted file mode 100644
index cd8784e64460..000000000000
--- a/f4f62699e5d5b821e83dc2f902d486cf5c2b2755.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From f4f62699e5d5b821e83dc2f902d486cf5c2b2755 Mon Sep 17 00:00:00 2001
-From: Antoine Pitrou <antoine@python.org>
-Date: Tue, 9 Oct 2018 09:00:02 -0400
-Subject: [PATCH] ARROW-3466: [C++] Avoid leaking protobuf symbols
-
-Our linker script hides "google::*" symbols exported from various C++ modules, but that isn't enough to actually hide all symbols. Some symbols (vtables, destructors, "guard variables"...) aren't hidden.
-
-The ORC library links protobuf statically, and we link ORC statically. So we ended up exporting protobuf symbols. When linking another protobuf instance dynamically (like tensorflow does), this can wreak havoc. Hiding all symbols fixes the issue.
-
-Author: Antoine Pitrou <antoine@python.org>
-
-Closes #2731 from pitrou/ARROW-3466-protobuf-symbol-leak and squashes the following commits:
-
-0aa4648aa <Antoine Pitrou> ARROW-3466: Avoid leaking protobuf symbols
----
- cpp/src/arrow/symbols.map | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/cpp/src/arrow/symbols.map b/cpp/src/arrow/symbols.map
-index 69717f089d..96faf596d5 100644
---- a/cpp/src/arrow/symbols.map
-+++ b/cpp/src/arrow/symbols.map
-@@ -62,6 +62,9 @@
- je_arrow_*;
- # ORC destructors
- _ZThn8_N3orc*;
-+ # Protobuf symbols that aren't hidden by the C++ section below
-+ # (destructors, vtables, other stuff)
-+ *N6google8protobuf*;
-
- extern "C++" {
- # devtoolset or -static-libstdc++ - the Red Hat devtoolset statically