|
I've made a bunch of changes to the `PKGBUILD` script to make it more
closely meet the Arch Linux packaging guidelines.
- The package description is now less than 100 characters in length. It
should be below 80 according to the guidelines, but my understanding
is that since this is a modification of an official Arch package, it
should include the official package's description.
- The `license` has been changed from `LGPL2` to `LGPL2.1`. The former
is not listed in `/usr/share/licenses/common` which produces an error
in `namcap`. And the latter is more correct anyway.
- `gcc` and `make` have been removed from `makedepends` because we are
allowed to assume that all `base-devel` packages are already
installed. `git` has also been removed from `makedepends` because it
is not needed during the actual package build process (only to clone
the AUR Git repository).
- Inversely, I've added all transient dependencies (dependencies which
would otherwise automatically be pulled by `pacman` due to it being a
dependency further down the tree) to `depends` as per recent
guidelines and `namcap` output. This means that, in addition to the
top-level dependencies `libolm`, `qt5-multimedia` and
`qtkeychain-qt5` we also need to explicitly specify `gcc-libs`,
`glibc` and `openssl` (and `qt5-base` but that was already present).
I am honestly yet to see any other AUR package which explicitly lists
`glibc` as a dependency, and interestingly enough the official
`libquotient` package doesn't list it either, but as far as I can
tell from reading BBS/Wiki packages, I am indeed supposed to do this.
See https://bbs.archlinux.org/viewtopic.php?id=249846
- Added the soname (`libQuotient.so=0.7-64`) to `provides` to help
packages which look for sonames instead of Arch package names. The
soname is generated from the first two digits of `pkgver`.
- Switched from `sha512sums` to `sha256sums` so that I can just copy
the source checksum from the official Arch package when updating.
- Adjusted `source` to use `pkgver` so that bumping `pkgver` is enough
to cause the new source version to be downloaded instead of the old.
- Use `cmake -B <build dir> -S <source dir>` instead of manually
creating directories, as per the CMake packaging guidelines.
- Use `cmake --build` and `cmake --install` instead of manually calling
`make` as per the CMake packaging guidelines
- Remove `CMAKE_INSTALL_LIBDIR` because it is no longer needed (I don't
know if it was ever needed at all)
- Change `CMAKE_BUILD_TYPE` from `Release` to `None` as per the CMake
packaging guidelines. This causes CMake to use the system-provided
build settings (i.e. those specified in `/etc/makepkg.conf`)
verbatim, without adding additional optimisations or debugging
information.
- Note that the CMake changes listed above have already been applied to
the official `libquotient` package.
- Use `pkgver` when accessing the source directory directly, again so
that only `pkgver` has to be updated to make the new version work.
|