Package Details: aaxtomp3-git 1.1.r83.g3c7a5f1-1

Git Clone URL: https://aur.archlinux.org/aaxtomp3-git.git (read-only, click to copy)
Package Base: aaxtomp3-git
Description: Convert Audible's .aax filetype to MP3, FLAC, M4A, or OPUS
Upstream URL: https://github.com/KrumpetPirate/AAXtoMP3
Keywords: aax aaxtomp3 audible audiobooks converter ffmpeg mp3
Licenses: custom
Conflicts: aaxtomp3
Provides: aaxtomp3
Submitter: kbabioch
Maintainer: kbabioch
Last Packager: kbabioch
Votes: 7
Popularity: 0.000005
First Submitted: 2017-04-09 12:39 (UTC)
Last Updated: 2018-10-24 18:19 (UTC)

Latest Comments

diabonas commented on 2018-10-24 20:46 (UTC)

@kbabioch Looks perfect, thank you very much for the quick update!

kbabioch commented on 2018-10-24 18:19 (UTC)

@diabonas: Thanks for all of your input and all of the references. I've incorporated your suggestions, let me know if you are happy with the result ;).

diabonas commented on 2018-10-22 12:36 (UTC) (edited on 2018-10-22 12:43 (UTC) by diabonas)

Could you please modify the pkgver() function to remove the trailing v from the version, as suggested in the Wiki?

git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'

This should fix the updating issues described in the previous comments.

Furthermore, could you add bc as a dependency? The default conversion to chaptered MP3 files requires this tool and fails with an error if unavailable. Also libmp4v2 should be an optional dependency as it provides mp4art, which is needed to add cover art to MP4 files. On the other hand, there is no need to require lame, as this is already a dependency of ffmpeg.

diraimondo commented on 2018-09-08 15:54 (UTC) (edited on 2018-09-08 16:10 (UTC) by diraimondo)

Maybe this is not the proper way to handle -git packages but, another example near me, the package 'nvme-cli-git' has a release version in the PKGBUILD file. It looks the author periodically bump the version inside (see commits on PKGBUILD) but, if in the meanwhile there are further commits, the package build a package with a release in advance with respect to the PKGBUILD one. It looks a way for the package author to force the update on all the machines (major fixes or what) but anyone can get the today package forcing the upgrade. Clearly the only difference with your package is the choice in the release version numbering. Can you see the difference?

Example:

$ pacaur -Q | grep nvme-cli-git
nvme-cli-git r623.10e0bf6-1

(this is the release number in the PKGBUILD and indeed 'pacaur -Syu' doesn't propose updates)

$ pacaur -S nvme-cli-git
[...]
$ pacaur -Q | grep nvme-cli-git
nvme-cli-git r969.d9a1281-1

kbabioch commented on 2018-09-07 18:15 (UTC)

Hm, I've looked at libinput-git, but I can't spot any fundamental difference in the way it handles the pkgver, so unfortunately I really don't know how to help you here. If you find anything that is different between this package and the ones that work for you, let me know, I'm willing to look into it.

diraimondo commented on 2018-09-07 15:20 (UTC)

@kbabioch: I got a dozen of other -git packages that doesn't attempt to update itself on each 'pacaur -Syu' (like 'libinput-git'). Maybe this is wrong but your packages behaves different than other. I'm going to stick with the current version in order to prevent further updates.

kbabioch commented on 2018-09-07 09:56 (UTC)

@diraimondo: I'm afraid this is intended.

The pkgver is updated on the fly, whenever building the package. I'm only pushing a new PKGBUILD whenever I have to update it due to some build issues and/or major changes. Otherwise you can build this package from git and the pkgver will change itself in accordance.

So probably pacaur is not handling this situation correctly.

For explanation:

1.1 is the latest officially released version (i.e. tag) r81 <- 81 commits since then g8b0f9a4 <- commit 8b0f9a4 1 -> pkg release

I don't know what I can do here to fix it for you. You probably will face the same issue with any other -git, -svn package, etc., because this is the default way of packaging software from git. It is even described in the wiki:

https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git

diraimondo commented on 2018-09-07 08:21 (UTC)

There is something wrong in the PKGBUILD of this package. The claimed version is 1.1.r2.g2192558-1 but the produced package reports version 1.1.r81.g8b0f9a4-1. My pacaur continues to download-build-install it each time I invoke an update of all the packages.

KrumpetPirate commented on 2017-04-11 03:18 (UTC)

Original developer here. Please post any upstream issues to github and I'll look at them when I can.