Package Details: adom-noteye 3.3.3-6

Git Clone URL: https://aur.archlinux.org/adom-noteye.git (read-only, click to copy)
Package Base: adom-noteye
Description: A roguelike game with a quest-centric, plot driven structure (+ GUI) - Please consider buying the game on Steam
Upstream URL: http://www.adom.de/
Keywords: game roguelike
Licenses: custom:adom
Conflicts: adom, adom-restricted
Provides: adom
Submitter: eldios
Maintainer: eldios
Last Packager: eldios
Votes: 4
Popularity: 0.000000
First Submitted: 2017-11-30 15:20 (UTC)
Last Updated: 2019-11-29 01:49 (UTC)

Latest Comments

« First ‹ Previous 1 2

TrialnError commented on 2018-02-07 19:37 (UTC) (edited on 2018-02-07 19:42 (UTC) by TrialnError)

Well thank you for maintaining this, after free public releases were made available again. I doubt it would happen, so I had it removed from aurweb last year.

Ah, I see. The thing is with aurweb and the AUR. If packages get deleted from the aurweb, their history is still kept. See, this is the change[0] you introduced to the last existing PKGBUILD. And in this history it looks like a deliberate move, so therefor my comment.

Not sure I can follow your argument regarding avoiding repackaging. You need to repackage everytime if upstream releases a new package. And no need for pkgrel to increase because something changed in the Arch repos. Just some rm commands in prepare to use system libs (Arch way). But well. At least it is working.

<hr>

[0] https://aur.archlinux.org/cgit/aur.git/commit/?h=adom-noteye&id=8aff1c603817

Edit: Well.. the aurweb markdown parser is kinda faulty...

<https://aur.archlinux.org/cgit/aur.git/commit/?h=adom-noteye&id=[`8aff1c603817`](https://aur.archlinux.org/cgit/aur.git/commit/?h=adom-noteye&id=8aff1c603817)>

See "View changes" for the history

eldios commented on 2018-02-07 14:44 (UTC) (edited on 2018-02-07 14:45 (UTC) by eldios)

Hi @TrialnError and thanks for your hints and observations.

I'll try to answer you where I can:

Epoch was unneeded.

Removed.

Such small scripts can be added to the repo.

Fixed.

Specifing the license is "custom:adom", no separating or extra quoting. Also the license should be copied to /usr/share/licenses (See Wiki)

Fixed and Fixed.

Previous Maintainer and Contributor aren't removed from a PKGBUILD.

I don't know who they are, but they are NOT maintaners of this package, nor I inherited from them. They disappeared and the package was entirely dropped, I had to recreate it from scratch, so I'm not sure what "Previous Maintainer and Contributor" you're referring to.

The whole point of prepare() was, to use arch packages instead of the bundled deps if possible. Was there a reason to step back from this?

I'm just trying to use the package provided by the ADOM devs as verbatim as possible, I don't want to repackage everything every time.

In the source url the pkgver can be substituted with the var pkgver.

Fixed.

And what is this download url? Your server, or some server where you have some space available?

Yes it's a server of mine.

TrialnError commented on 2018-02-02 02:26 (UTC)

Some remarks on the PKGBUILD. And nice that there are again releases.

Moving the creation of the shell script for starting adom into the PKGBUILD, is imo an ugly solution. Such small scripts can be added to the repo.

Epoch was unneeded.

Specifing the license is "custom:adom", no separating or extra quoting. Also the license should be copied to /usr/share/licenses (See Wiki)

Previous Maintainer and Contributor aren't removed from a PKGBUILD.

The whole point of prepare() was, to use arch packages instead of the bundled deps if possible. Was there a reason to step back from this?

In the source url the pkgver can be substituted with the var pkgver.

And what is this download url? Your server, or some server where you have some space available?

« First ‹ Previous 1 2