Arch Linux User Repository

git should be added to makedepends as VCS tools are not included in base-devel. This PKGBUILD breaks building in a clean install or chroot.

@MarsSeed: I specifically set the pkgver to 0 because coming from git, it is meaningless to have the git version listed in the PKGBUILD. Imagine a repo that gets updated every day - are you supposed to update the PKGBUILD every day to reflect the latest git version? The pkgver() function will set the correct version every time you build it, so what is the point of listing some random version that matched git the last time you updated the PKGBUILD? It makes more sense to me to set the pkgver to 0 and have the pkgver() function update it to match the git repo on each build. That way there is no confusion about what version you are building - version 0 is always the latest git release.

provides would only work if you did not specify $pkgver because what that would do is say provides=("adplug=git12345") and no package should depend on a git version really. It would make more sense to say provides=("adplug-1.2.3") to show the git version is compatible with a non-git package, however this requires more complexity when managing the PKGBUILD because you need to know which release version the git version is compatible with, and this can change with any commit the maintainer wants, so I think it is a losing battle to try to make that workable.

@Malvineous, sorry, I've missed your pkgver() somehow. Guess I was just confused because of the wrong (non-updated) 1:0-1 (and now 1:0-2) pkgrel here on the AUR page.

Your current .SRCINFO should contain this generated version (separated of course into pkgver, pkgrel and epoch fields): 1:2.3.3.109.g4237f96-1.

The provides=("adplug=${pkgver}") could be useful if any of the dependent packages would want to define a version constraint for adplug.

@MarsSeed: I'm not sure what you mean about pkgver(), what's wrong with the existing pkgver() function?

What is the rationale behind the versioned provides? On the wiki it would seem putting the git version in here as you suggest is not the intended use, and it would be better to put the base version, but only for packages where you need specific versions which this one does not.

Source URL needs to be changed to begin with git+https://. (GitHub now refuses insecure connections.)

Also please kindly implement a git tag based pkgver() (something beginning with git describe --long --tags).

And after that, it would be nice if you could add versioned provides, like provides=("adplug=${pkgver}").

Thanks in advance!

@JerryXiao: Done, thanks

Also, an epoch should be added.

I have an updated pkgbuild at https://fars.ee/UmhB