Package Details: amimullvad 1.1-2

Git Clone URL: https://aur.archlinux.org/amimullvad.git (read-only, click to copy)
Package Base: amimullvad
Description: Utility to check for a mullvad vpn connection status
Upstream URL: https://github.com/hgrahamcs/amimullvad
Keywords: mullvad
Licenses: custom:WTFPL
Submitter: ciplc
Maintainer: ciplc
Last Packager: ciplc
Votes: 2
Popularity: 0.000000
First Submitted: 2020-10-27 03:07 (UTC)
Last Updated: 2024-09-11 23:10 (UTC)

Dependencies (1)

Required by (0)

Sources (1)

Latest Comments

ciplc commented on 2024-09-11 23:12 (UTC)

@dreieck I have corrected the PKGBUILD to download in the prepare section instead of in the build. I'm glad you are finding some use in this package!

@yochananmarqos Thank you for the link!

yochananmarqos commented on 2024-09-11 22:29 (UTC)

@dreieck: All you had to do was link to Rust package guidelines. ;)

dreieck commented on 2024-09-11 22:28 (UTC) (edited on 2024-09-11 22:29 (UTC) by dreieck)

This PKGBUILD downloads stuff during build().

Please do not do that.

Please download the rust specific stuff in prepare() so that build() can run in a restricted or offline environment.

Regards and thanks for the package!

==> Starting build()...
    Updating crates.io index
     Locking 24 packages to latest compatible versions
      Adding windows-sys v0.52.0 (latest: v0.59.0)
  Downloaded openssl-probe v0.1.5
  Downloaded curl v0.4.46
  Downloaded socket2 v0.5.7
  Downloaded pkg-config v0.3.30
  Downloaded shlex v1.3.0
  Downloaded openssl-sys v0.9.103
  Downloaded cc v1.1.18
  Downloaded vcpkg v0.2.15
  Downloaded libc v0.2.158
  Downloaded libz-sys v1.1.20
  Downloaded curl-sys v0.4.75+curl-8.10.0
  Downloaded 11 crates (4.0 MB) in 2.90s (largest was `curl-sys` at 1.8 MB)
[...]

ciplc commented on 2020-10-27 18:49 (UTC)

Fixed all the listed issues in the latest pkgbuild, thanks for the feedback.

yochananmarqos commented on 2020-10-27 18:27 (UTC) (edited on 2020-10-27 18:29 (UTC) by yochananmarqos)

  • The pkgver should be 1.1 to match the release version.
  • No need for provides(), a package already provides itself.
  • No need for a prepare() function, the tarball is automatically extracted.
  • Please see Rust package guidelines