Arch Linux User Repository

Thanks a bunch @Muflone!

@Auerhuhn I've temporarily applied your fix to pin jdk to version 21

Hi @Muflone,

Since jdk-openjdk was bumped from version 23 to 24, this build has been failing:

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':check'.
> Could not create task ':test'.
   > Could not create task of type 'Test'.
      > Could not create an instance of type org.gradle.api.internal.tasks.testing.DefaultTestTaskReports.
         > Could not create an instance of type org.gradle.api.reporting.internal.DefaultReportContainer.
            > Type T not present

Pinning the makedepends entry to Java 21 fixes it:

diff --git a/PKGBUILD b/PKGBUILD
index 418c928..fbb0e1d 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,17 +4,19 @@
 pkgname=android-apktool
 pkgver=2.11.1
 pkgrel=1
+_jdkver=21
 pkgdesc="a tool for reengineering Android apk files"
 arch=('any')
 url="https://github.com/iBotPeaches/Apktool"
 license=('Apache-2.0')
 depends=('java-runtime')
-makedepends=('java-environment' 'gradle')
+makedepends=("jdk${_jdkver}-openjdk" 'gradle')
 source=("${pkgname}-${pkgver}.tar.gz"::"https://github.com/iBotPeaches/Apktool/archive/refs/tags/v${pkgver}.tar.gz")
 sha256sums=('1c1ac3add61c5d9043b5efdb228fbd2be7c3bd329bb6ed82228eedacef90bcb9')

 build() {
   cd "Apktool-${pkgver}"
+  export JAVA_HOME="/usr/lib/jvm/java-${_jdkver}-openjdk"
   gradle build --no-daemon shadowJar proguard
 }

@Mitmischer this package uses the sources from the author while android-apktool-bin uses a prebuilt package

What is the difference between this and android-apktool-bin?

I did a careful comparison between the Arch and Artix jdk-openjdk and gradle packages, and as far as I can tell, they are identical. The only explanation I can come up with is that somehow makechroopkg from Arch's devtools somehow works differently from mkchrootpkg from Artix's artools-pkg. And as to that, I haven't the vaguest idea how.

I did figure out that the tests were failing for me in part because /usr/lib/jvm/java-21-openjdk/lib/libawt_xawt.so depends, per ldd, on a bunch of libraries that aren't named as dependencies, in particular libxext, libxrender, and libxtst; and installing those did partially solve some of the problems. But then the tests started failing because, as far as I can tell, it wants access to the X server and can't get it, generating the error "java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable", which the internet proved completely unhelpful about solving. After doing a lot of irritating install-random-stuff and eventually using Xvfb to generate some kind of headless display situation that I don't understand, gradle would announce that the build succeeded than then proceed to hang forever. I give up, I'm not clever enough to comprehend what in tarnation is going on here, although it if has something to do with needing a running X server for some asinine reason, I guess that would make some kind of twisted sense.

So I just don't get it, but adding "-x test" to the end of the gradle build line to simply skip the tests entirely works perfectly for me.

the default JVM for Arch Linux is jdk-openjdk, so if you had to change this then your repositories have different packages at least.

I don't know what else is changed in Artix

Thanks! I did explicitly specify installing jdk-openjdk into the chroot. It still fails for me, although it does compile fine by simply passing makepkg at the command line. I'm on artix, but given how few packages are involved, I can't imagine what difference that should make. There may not be anything you can do to fix my problem at your end, but would you have any idea where I should even start looking? Thank you!

@frankspace all my packages are always built in clean chroot using devtools and also this one build fine, I've just tested it again right now.

make sure to use jdk-openjdk to build

I had no problem with version 2.9.0, but attempting to compile 2.9.1 in a chroot fails:

> Task :brut.apktool:apktool-lib:test

brut.androlib.aapt1.BuildAndDecodeTest > classMethod FAILED
    java.lang.UnsatisfiedLinkError at BuildAndDecodeTest.java:58

brut.androlib.aapt1.LargeIntsInManifestTest > checkIfLargeIntsAreHandledTest FAILED
    java.lang.NoClassDefFoundError at LargeIntsInManifestTest.java:51
        Caused by: java.lang.ExceptionInInitializerError at NativeLibraries.java:-2

brut.androlib.aapt1.SkipAssetTest > checkControl FAILED
    java.lang.NoClassDefFoundError at SkipAssetTest.java:74
        Caused by: java.lang.ExceptionInInitializerError at NativeLibraries.java:-2

brut.androlib.aapt1.SkipAssetTest > checkIfEnablingSkipAssetWorks FAILED
    java.lang.NoClassDefFoundError at SkipAssetTest.java:57
        Caused by: java.lang.ExceptionInInitializerError at NativeLibraries.java:-2

brut.androlib.decode.DecodeKotlinTest > classMethod FAILED
    java.lang.NoClassDefFoundError at DecodeKotlinTest.java:50
        Caused by: java.lang.ExceptionInInitializerError at NativeLibraries.java:-2

brut.androlib.decode.MissingDiv9PatchTest > assertMissingDivAdded FAILED
    java.lang.NoClassDefFoundError at MissingDiv9PatchTest.java:55
        Caused by: java.lang.ExceptionInInitializerError at NativeLibraries.java:-2

128 tests completed, 6 failed

> Task :brut.apktool:apktool-lib:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':brut.apktool:apktool-lib:test'.
> There were failing tests. See the report at: file:///build/android-apktool/src/Apktool-2.9.1/brut.apktool/apktool-lib/build/reports/tests/test/index.html

(Checking that file yielded nothing but a list of the six tests that failed, so it wasn't helpful.)

At a guess, I tried installing java-commons-lang and java-commons-lang3, neither of which had any effect.