Arch Linux User Repository

should be fixed, reverted my (crappy) patch as upstream is fixed. :> thank you for letting me know

Same issue as lollilol for me. Doesn't install.

==> Starting prepare()...
patching file src/Application.vala
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file src/Application.vala.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error: failed to build 'appeditor-git-1.1.3.r4.gaeb0b13-1': 
error: packages failed to build: appeditor-git-1.1.3.r4.gaeb0b13-1

@PrzemekS I have adopted this package (as it was orphaned) and added a patch to merge in a pull request that fixes this - please let me know if this is something I should change, I'm not sure if a -git package should be a direct mirror or should at least try and fix some functionality. Additionally, this is done with a patch file rather than sed because I am more familiar with it. lmk if anyone wants to take over or suggest improvements! I'm new to the AUR but here to help o7

Hello, I cannot buid in pamac:

[15/41] Generating po/it/LC_MESSAGES/com.github.donadigo.appeditor-it.mo with a custom command
[16/41] Compiling C object com.github.donadigo.appeditor.p/meson-generated_.._as-resources.c.o
[17/41] Generating data/com.github.donadigo.appeditor.desktop with a custom command
[18/41] Generating data/com.github.donadigo.appeditor.appdata.xml with a custom command
[19/41] Compiling Vala source Config.vala ../appeditor/src/Application.vala ../appeditor/src/MainWindow.vala ../appeditor/src/AppSourceList.vala ../appeditor/src/AppItem.vala ../appeditor/src/CategoryItem.vala ../appeditor/src/IconButton.vala ../appeditor/src/SettingBox.vala ../appeditor/src/PersistentPlaceholderEntry.vala ../appeditor/src/FieldEntry.vala ../appeditor/src/CategoryComboBox.vala ../appeditor/src/AppInfoViewStack.vala ../appeditor/src/AppInfoView.vala ../appeditor/src/AppDirectoryScanner.vala ../appeditor/src/DesktopApp.vala ../appeditor/src/DesktopAppManager.vala ../appeditor/src/AppInfoViewSaver.vala ../appeditor/src/IconListBox.vala ../appeditor/src/IconChooserDialog.vala ../appeditor/src/IconRow.vala ../appeditor/src/Constants.vala
FAILED: com.github.donadigo.appeditor.p/Config.c com.github.donadigo.appeditor.p/src/Application.c com.github.donadigo.appeditor.p/src/MainWindow.c com.github.donadigo.appeditor.p/src/AppSourceList.c com.github.donadigo.appeditor.p/src/AppItem.c com.github.donadigo.appeditor.p/src/CategoryItem.c com.github.donadigo.appeditor.p/src/IconButton.c com.github.donadigo.appeditor.p/src/SettingBox.c com.github.donadigo.appeditor.p/src/PersistentPlaceholderEntry.c com.github.donadigo.appeditor.p/src/FieldEntry.c com.github.donadigo.appeditor.p/src/CategoryComboBox.c com.github.donadigo.appeditor.p/src/AppInfoViewStack.c com.github.donadigo.appeditor.p/src/AppInfoView.c com.github.donadigo.appeditor.p/src/AppDirectoryScanner.c com.github.donadigo.appeditor.p/src/DesktopApp.c com.github.donadigo.appeditor.p/src/DesktopAppManager.c com.github.donadigo.appeditor.p/src/AppInfoViewSaver.c com.github.donadigo.appeditor.p/src/IconListBox.c com.github.donadigo.appeditor.p/src/IconChooserDialog.c com.github.donadigo.appeditor.p/src/IconRow.c com.github.donadigo.appeditor.p/src/Constants.c 
valac -C --define HAS_VALA040 --pkg posix --pkg gee-0.8 --pkg gtk+-3.0 --pkg granite --color=always --directory com.github.donadigo.appeditor.p --basedir ../appeditor/ --gresources=../appeditor/data/com.github.donadigo.appeditor.gresource.xml Config.vala ../appeditor/src/Application.vala ../appeditor/src/MainWindow.vala ../appeditor/src/AppSourceList.vala ../appeditor/src/AppItem.vala ../appeditor/src/CategoryItem.vala ../appeditor/src/IconButton.vala ../appeditor/src/SettingBox.vala ../appeditor/src/PersistentPlaceholderEntry.vala ../appeditor/src/FieldEntry.vala ../appeditor/src/CategoryComboBox.vala ../appeditor/src/AppInfoViewStack.vala ../appeditor/src/AppInfoView.vala ../appeditor/src/AppDirectoryScanner.vala ../appeditor/src/DesktopApp.vala ../appeditor/src/DesktopAppManager.vala ../appeditor/src/AppInfoViewSaver.vala ../appeditor/src/IconListBox.vala ../appeditor/src/IconChooserDialog.vala ../appeditor/src/IconRow.vala ../appeditor/src/Constants.vala
../appeditor/src/IconButton.vala:71.9-71.41: warning: `Granite.Widgets.Utils.set_theming' has been deprecated since 5.5.0. Use 
   71 |         Granite.Widgets.Utils.set_theming (this, css, "flat", Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                              
../appeditor/src/FieldEntry.vala:55.9-55.41: warning: `Granite.Widgets.Utils.set_theming' has been deprecated since 5.5.0. Use 
   55 |         Granite.Widgets.Utils.set_theming (entry, css, Gtk.STYLE_CLASS_FLAT, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                             
../appeditor/src/Application.vala:19.42-23.5: error: value is less accessible than constant `AppEditor.Application.OPTIONS'
   19 |     public const OptionEntry[] OPTIONS = {
      |                                          ^
   20 |         { "create", 'c', 0, OptionArg.FILENAME, out create_exec_filename,
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   21 |         "Create an application entry from an executable path", "FILENAME" },
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   22 |         { null }
      | ~~~~~~~~~~~~~~~~
   23 |     };
      | ~~~~~ 
Compilation failed: 1 error(s), 2 warning(s)
ninja: build stopped: subcommand failed.

The vala issue is fixed: https://github.com/donadigo/appeditor/commit/17e47835d80b72b8783cc041118ca9804ae6e403

@Trupe: It's already been reported upstream: Fails to build with vala 0.46

Fix using sed since it's only one line:

prepare() {
    cd "$srcdir/${pkgname%-git}"
    sed -i 's/unowned string _path = info.get_string/string _path = info.get_string/g' \
        src/DesktopApp.vala
}

Hi, when i tried to install gave me this error:

FAILED: com.github.donadigo.appeditor@exe/src/Application.c com.github.donadigo.appeditor@exe/src/MainWindow.c com.github.donadigo.appeditor@exe/src/AppSourceList.c com.github.donadigo.appeditor@exe/src/AppItem.c com.github.donadigo.appeditor@exe/src/CategoryItem.c com.github.donadigo.appeditor@exe/src/IconButton.c com.github.donadigo.appeditor@exe/src/SettingBox.c com.github.donadigo.appeditor@exe/src/PersistentPlaceholderEntry.c com.github.donadigo.appeditor@exe/src/FieldEntry.c com.github.donadigo.appeditor@exe/src/CategoryComboBox.c com.github.donadigo.appeditor@exe/src/AppInfoViewStack.c com.github.donadigo.appeditor@exe/src/AppInfoView.c com.github.donadigo.appeditor@exe/src/AppDirectoryScanner.c com.github.donadigo.appeditor@exe/src/DesktopApp.c com.github.donadigo.appeditor@exe/src/DesktopAppManager.c com.github.donadigo.appeditor@exe/src/AppInfoViewSaver.c com.github.donadigo.appeditor@exe/src/IconListBox.c com.github.donadigo.appeditor@exe/src/IconChooserDialog.c com.github.donadigo.appeditor@exe/src/IconRow.c com.github.donadigo.appeditor@exe/src/Constants.c valac -C --debug --debug --define HAS_VALA040 --pkg posix --pkg posix --pkg posix --pkg gee-0.8 --pkg gtk+-3.0 --pkg granite --color=always --directory com.github.donadigo.appeditor@exe --basedir ../ --gresources=../data/com.github.donadigo.appeditor.gresource.xml ../src/Application.vala ../src/MainWindow.vala ../src/AppSourceList.vala ../src/AppItem.vala ../src/CategoryItem.vala ../src/IconButton.vala ../src/SettingBox.vala ../src/PersistentPlaceholderEntry.vala ../src/FieldEntry.vala ../src/CategoryComboBox.vala ../src/AppInfoViewStack.vala ../src/AppInfoView.vala ../src/AppDirectoryScanner.vala ../src/DesktopApp.vala ../src/DesktopAppManager.vala ../src/AppInfoViewSaver.vala ../src/IconListBox.vala ../src/IconChooserDialog.vala ../src/IconRow.vala ../src/Constants.vala ../src/DesktopApp.vala:133.28-133.32: error: Invalid assignment from owned expression to unowned variable unowned string _path = info.get_string (KeyFileDesktop.KEY_PATH); ^^^^^ ../src/DesktopApp.vala:134.17-134.21: error: The name _path' does not exist in the context ofAppEditor.DesktopApp.get_path' if (_path == null) { ^^^^^ ../src/DesktopApp.vala:135.17-135.21: error: The name _path' does not exist in the context ofAppEditor.DesktopApp.get_path' _path = ""; ^^^^^ ../src/DesktopApp.vala:138.20-138.24: error: The name _path' does not exist in the context ofAppEditor.DesktopApp.get_path' path = _path; ^^^^^ Compilation failed: 4 error(s), 0 warning(s) ninja: build stopped: subcommand failed.

There are tags available, please see VCS package guidelines:

pkgver() {
    cd "$srcdir/${pkgname%-git}"
    printf "%s" "$(git describe --long --tags | sed 's/\([^-]*-\)g/r\1/;s/-/./g')"
}

pkgver=1.1.0.r8.b7b4350

There's no need to manually install the desktop file anymore.

It's redundant to include ninja in the makedepends array, meson depends on it.

You're already using the ${pkgname%-git} variable, why it is not used in the provides / conflicts arrays?

provides=("${pkgname%-git}")
conflicts=("${pkgname%-git}")