Arch Linux User Repository

do not symlink, you need to rebuild astroid against the new version of protobuf.

Fails to open, complains about missing protobuf.so.22 Maybe an ln -s to the right one might help?

You have a fair point regarding the license. Okay, install all three of LICENSE.md, COPYING.GPL-3.0+, and COPYING.LGPL-2.1+ to /usr/share/licenses/${pkgname}/ and set the licenses array to custom.

As for the transitive dependencies, I specified the two that I caught: gmime3 and gobject-introspection-runtime. There are mixed opinions on whether they should or should not be added; namcap will call them unnecessary.

Hi Celti,

thanks a lot for your input and the patch. I'll update the package today after running some tests on my own.

Regarding the license: I think it's a bit more complicated: https://github.com/astroidmail/astroid/pull/44 The GMime part is licensed under LGPL v2.1 or later

Regarding dependencies: Thanks a lot for cleaning things up. I'll need to check if there's no transitive dependency in your definitions, e.g. will astroid break if notmuch drops its gmime3 dependency (for whatever reason)? If so, we still need to name it.

Cheers, Johannes

The install script is unnecessary; the gtk-update-icon-cache pacman hook has been doing that job for years. Along with that, any empty fields (e.g., epoch, groups, provides, conflicts, replaces, backup, options, changelog, andnoextract`) should be removed to improve clarity.

Astroid is specifically licensed under GPL v3 or any later version; the PKGBUILD should read LICENSE=('GPL3') to reflect this.

There are multiple depends=() issues: * notmuch-runtime instead of notmuch
* boost is a make dependency, boost-libs remains as the runtime dependency.
* gmime3 is a dependency of notmuch and may be removed here.
* gobject-introspection is a make dependency. The runtime dependency, gobject-introspection-runtime, is a dependency of libpeas and does not need to be added here.

There are multiple makedepends=() issues: * As above, boost and gobject-introspection should be added here.
* git is not necessary here.
* pkg-config should not be listed here; its provider, pkgconf, is part of base-devel.
* python-gobject is not necessary here.
* vte3 is listed in optional dependencies, but should be added here as well to ensure it is available to build against.

The check() function fails to run entirely when building in a clean chroot (e.g., with makechrootpkg) due to the inability to access a display server; fix this by adding xorg-server-xvfb to checkdepends and calling xvfb-run -a ninja test instead of ctest --output-on-failure. Additionally, as notmuch-runtime is a full dependency it should be dropped from checkdepends=().

A minimal patch for all of the above (tested) changes follows:

diff --git a/PKGBUILD b/PKGBUILD
index 909cc7e..63ccc33 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,2 +4 @@ pkgver=0.15
-pkgrel=4
-epoch=
+pkgrel=5
@@ -9,5 +8,4 @@ url="https://github.com/astroidmail/astroid"
-license=('GPL')
-groups=()
-depends=('notmuch' 'boost' 'boost-libs' 'gmime3' 'gtkmm3' 'webkit2gtk' 'libsass' 'libpeas' 'gobject-introspection' 'protobuf')
-makedepends=('cmake' 'ninja' 'git' 'pkg-config' 'python-gobject' 'cmark' 'ruby-ronn' 'w3m')
-checkdepends=('notmuch-runtime')
+license=('GPL3')
+depends=('notmuch-runtime' 'boost-libs' 'gtkmm3' 'webkit2gtk' 'libsass' 'libpeas' 'protobuf')
+makedepends=('cmake' 'ninja' 'boost' 'gobject-introspection' 'cmark' 'ruby-ronn' 'vte3' 'w3m')
+checkdepends=('xorg-server-xvfb')
@@ -18,7 +15,0 @@ optdepends=('gvim: default editor'
-provides=()
-conflicts=()
-replaces=()
-backup=()
-options=()
-install="${pkgname}.install"
-changelog=
@@ -27 +17,0 @@ source=("${pkgname}-v${pkgver}.tar.gz::https://github.com/astroidmail/astroid/ar
-noextract=()
@@ -47 +37 @@ check() {
-  ctest --output-on-failure
+  xvfb-run -a ninja test

Great, that should make life easier. Added you as co-maintainer.

@gauteh sure, I can give it a try :)

Also, I noticed that notmuch seems to be built against gmime3 now: https://www.archlinux.org/packages/community/x86_64/notmuch/

If someone wants to take over maintaining this package that would be great.

(@jheinz)

Note: check()-function needs to be invoked with acces to an X-server. (See my comment from today to https://aur.archlinux.org/packages/astroid-git/ for details.)

@ad1217: please report bugs to https://github.com/astroidmail/astroid