Package Details: binnavi-git v6.1.0.279.356eaa8-2

Git Clone URL: https://aur.archlinux.org/binnavi-git.git (read-only)
Package Base: binnavi-git
Description: A binary analysis IDE that allows to inspect, navigate, edit and annotate control flow graphs and call graphs of disassembled code
Upstream URL: https://github.com/google/binnavi
Licenses: Apache
Conflicts: binnavi
Provides: binnavi
Submitter: Shibumi
Maintainer: Shibumi
Last Packager: Shibumi
Votes: 3
Popularity: 0.000014
First Submitted: 2015-08-19 17:22
Last Updated: 2017-02-22 20:28

Latest Comments

Shibumi commented on 2015-09-15 18:05

I don't care.. give me a real fix for the issue and I will include it. I won't include one echo line

Manouchehri commented on 2015-09-15 17:58

Right now when it fails to build, it outputs ~10,000 lines. With that single line, it only outputs 4.

Which is likely easier to read?

Manouchehri commented on 2015-09-15 17:55

No, it will not be overwritten by any output. Look at the exit 1 at the end.

Shibumi commented on 2015-09-15 17:51

because adding the line does not solve the issue. Even when I would include your line the line will be overwritten with over 100 lines of javac/maven/ant output.

> Even in a clean chroot, if JDK7 is installed before JDK8, the build will fail I think.

nope. In a CLEAN chroot, only the dependencies would be installed. No JDK7.

Manouchehri commented on 2015-09-15 17:19

I don't see why you're against adding one single line of bash that will ensure that end users are easily able to build the package.. For those not familiar with Java, it takes a minute to figure out what the error messages are about (since it passes the dependency check).

Even in a clean chroot, if JDK7 is installed before JDK8, the build will fail I think.

Anyway, hopefully the comments here will serve as a bug report for users who are unable to build this.

Manouchehri commented on 2015-09-15 17:14

For binnavi I would agree, but this is binnavi-git. It's going to stay on the AUR permanently.

Shibumi commented on 2015-09-15 16:56

@Manouchehri
I won't fix.

The package builds in a clean chroot. AUR is only a staging for the official bin-repositories. Packages in the official repositories are build with clean chroot.

Please just use archlinux-java set java-8-openjdk or build it in a clean-chroot via makechrootpkg in package extra/devtools.

it's that simple.

Manouchehri commented on 2015-09-15 11:20

Furthermore, commit fc6805c64f is isolated by itself to enforce JDK8. You can/could have just cherry picked that single commit to fix the build if style changes are unacceptable.

https://github.com/Manouchehri/AUR-binnavi-git/commit/fc6805c64f2b159bb7ae80e979bc4e062f2301de

There is no point in using a distributed revision control system if you're not willing to use it.

Manouchehri commented on 2015-09-15 11:15

Because I sent my patches several weeks ago and you did not check them, the build process has changed since then.

The "no changes" I made also forced JDK8 to be used. Your package still fails to build for *any* system that does not have JDK8 as it's default, it's incorrect to assume that the end-user is only allowed to have one JVM installed.

https://gist.github.com/Manouchehri/539e170de60657c2d031 <- This is your package failing to build.

https://gist.github.com/Manouchehri/6e3e3334e5ab73048a97 <- This is mine correctly warning the user to set the default to JDK8.

You need to add this one line or figure out how to make the compiler use the correct JVM.

java -version 2>&1 | grep 'version "1.8' >/dev/null || (printf "\e[1;31mJDK8 is required.\e[0m\nsudo archlinux-java set java-8-openjdk\n" && exit 1)

Without the exit 1, build() will be attempted anyways and waste time trying to complete a build that is impossible to finish.

I am marking this package as out of date until it handles multiple JVMs.

Shibumi commented on 2015-09-13 07:59

because you have no changes (except more variables and one echo for the java version) and a lot of old stuff that had changed upstream.
Would I use your PKGBUILD version it would not compile.

They have changed the building part via ant. This does not work and is still in your PKGBUILD.

ant -f src/main/java/com/google/security/zynamics/build.xml \
build-binnavi-fat-jar

All comments