Arch Linux User Repository

Looks good, thanks.

/usr/local/bin link is now created in the PKGBUILD instead of in bloomrpc.install, this will cause a conflicting files error when upgrading. Either force it through or uninstall & install bloom please :)

Nice =). This is my current diff, btw:

diff --git a/PKGBUILD b/PKGBUILD
index eb0eae0..374cde1 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,9 +7,9 @@ arch=(any)
 url="https://github.com/uw-labs/bloomrpc"
 license=(LGPL3)
 depends=('gtk3' 'gconf' 'libxss' 'libxtst')
-makedepends=('nodejs' 'npm'  'clang' 'git' 'yarn')
+makedepends=('nodejs' 'npm' 'clang' 'git' 'yarn')
 install=${pkgname}.install
-source=("${pkgname}::git+https://github.com/uw-labs/bloomrpc.git#tag=${pkgver//_/-}"
+source=("${pkgname}::git+https://github.com/uw-labs/${pkgname}.git#tag=${pkgver//_/-}"
         "${pkgname}.desktop")
 sha1sums=('SKIP'
           'f050f42f2faedfb0df2da3e7afdaef42716a34ff')
@@ -35,11 +35,14 @@ package() {
   install -dm755 "${pkgdir}/opt/BloomRPC"
   cp -rd release/linux-unpacked/* "${pkgdir}/opt/BloomRPC/"

+  install -dm755 "${pkgdir}/usr/bin"
+  ln -s "/opt/BloomRPC/bloomrpc" "${pkgdir}/usr/bin/bloomrpc"
+
   cd resources/icons
   for i in $(ls *.png)
   do 
-    mkdir -p "$pkgdir/usr/share/icons/hicolor/${i%.png}"
-    install -Dm644  $i "$pkgdir/usr/share/icons/hicolor/${i%.png}/"
+    mkdir -p "$pkgdir/usr/share/icons/hicolor/${i%.png}/apps"
+    install -Dm644  $i "$pkgdir/usr/share/icons/hicolor/${i%.png}/apps/bloomrpc.png"
   done

   install -Dm644 "${srcdir}"/${pkgname}.desktop "${pkgdir}"/usr/share/applications/${pkgname}.desktop
diff --git a/bloomrpc.install b/bloomrpc.install
deleted file mode 100644
index 9a83d34..0000000
--- a/bloomrpc.install
+++ /dev/null
@@ -1,16 +0,0 @@
-post_install() {
-    :
-#!/bin/bash
-
-# Link to the binary
-ln -sf '/opt/BloomRPC/bloomrpc' '/usr/local/bin/bloomrpc'
-
-}
-post_remove() {
-    :
-#!/bin/bash
-
-# Delete the link to the binary
-rm -f '/usr/local/bin/bloomrpc'
-
-}

@pm_gameiro thanks for your suggestion! I'll update the PKGBUILD today :)

I also feel like the .install soft link creation could be done in the PKGBUILD. Then you wouldn't need to explicitly remove it.

The launcher icon is broken. I believe the following fix should be applied:

diff --git a/PKGBUILD b/PKGBUILD
index eb0eae0..14efef3 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -38,8 +38,8 @@ package() {
   cd resources/icons
   for i in $(ls *.png)
   do 
-    mkdir -p "$pkgdir/usr/share/icons/hicolor/${i%.png}"
-    install -Dm644  $i "$pkgdir/usr/share/icons/hicolor/${i%.png}/"
+    mkdir -p "$pkgdir/usr/share/icons/hicolor/${i%.png}/apps/"
+    install -Dm644  $i "$pkgdir/usr/share/icons/hicolor/${i%.png}/apps/bloomrpc.png"
   done

   install -Dm644 "${srcdir}"/${pkgname}.desktop "${pkgdir}"/usr/share/applications/${pkgname}.desktop

Thanks for maintaining this.