Package Details: brave 1.29.79-1

Git Clone URL: https://aur.archlinux.org/brave.git (read-only, click to copy)
Package Base: brave
Description: A web browser that stops ads and trackers by default
Upstream URL: https://www.brave.com/download
Licenses: custom
Submitter: maximbaz
Maintainer: alerque
Last Packager: alerque
Votes: 127
Popularity: 0.52
First Submitted: 2019-07-10 11:14 (UTC)
Last Updated: 2021-09-11 15:02 (UTC)

Dependencies (25)

Required by (3)

Sources (15)

Pinned Comments

alerque commented on 2021-08-31 09:41 (UTC)

Appeal for co-maintainers: I'd be very interested if anybody else out there was willing to take this on. Long term I have an eye on moving it to [community], but there are a number of road blocks to overcome before that can happen: some upstream and some local to this packaging. The PKGBUILD needs a bit of work, and even without trying to clean it up maintaining Chromium builds of any kind is quite a bit of work. I adopted this with the aim of shepherding it until I feel comfortable pulling it into [community], but until then I would love if one or more co-maintainers would jump on here.

Feel free to send patches in comments, via email, or as PRs to this repository.

figue commented on 2021-02-21 13:08 (UTC) (edited on 2021-02-21 13:10 (UTC) by figue)

I have been testing the way to keep the main sources of this package in disk and avoid to download all Chromium source everytime... Chromium is a huge project! So finally I have used the VCS package guidelines in Archwiki and I used to pull the main projects behind Brave:

  • brave-browser
  • chromium
  • depot_tools
  • brave-core
  • adblock-rust

So, now these projects are stored in your repo dir to be used in the future. Keep that in mind because it's more than 23 GB:

figue /DATA2/packages/figue/brave-aur $ du -hcs chromium brave-browser brave-core adblock-rust depot_tools
22G     chromium
20M     brave-browser
645M    brave-core
30M     adblock-rust
111M    depot_tools
23G     total

Latest Comments

Bitals commented on 2022-05-04 15:02 (UTC)

@MarsSeed PKGBUILD in that repo uses a precompiled binary.

MarsSeed commented on 2022-05-04 14:56 (UTC)

Hi @alerque,

You could check Manjaro's Brave build repo, or reach out to its maintainer, Stefano Capitani on GitLab, or directly by email (stefano AT manjaro.org).

ayr-ton commented on 2021-12-20 21:18 (UTC) (edited on 2021-12-20 21:18 (UTC) by ayr-ton)

Given its popularity maybe is it a good idea to move this package to [community]? Or flag it as Orphan?

jemadux commented on 2021-12-18 11:03 (UTC)

can please update pkgbuild my friend ? there's chaotic aur that will build automatically the package

alerque commented on 2021-12-11 19:59 (UTC)

@doctorzeus Becuase it is a train-load of work to do, nobody else is contributing, and I've been traveling and my laptop is not fast enough to even tinker with this build. Feel free to send PRs or patches that clean this up to Arch packaging guidelines. I'd be happy to accept them and it would accelerate it getting into [community].

doctorzeus commented on 2021-12-05 09:35 (UTC)

Seriously how is this not in the official repos yet?

korimitsu commented on 2021-11-23 10:59 (UTC)

Another issue: icon is missing.

monarc99 commented on 2021-09-29 20:26 (UTC)

@alerque decide yourself, what you want to be included.

I have updated my PKGBUILD to v1.30.86. I only tested COMPONENT=4, compiles with makepkg.conf CFLAGS/XX, LTO + PGO. But there a bad CFLAGS (from standard makepkg.conf) flags left, that need to be filtered.

https://github.com/monarc99/aur/commit/1345032e779af310bd46342d137c7c80a0f1bd89

alerque commented on 2021-09-11 15:15 (UTC)

@monarc99 You've clearly done a bit more fiddling with the assorted patches an options that are out there. I'm not sure all of your changes are generally applicable (not saying they aren't, I haven't had time to dig into each), but if there is anything you think should be put in the AUR here do feel free to open pull requests.

monarc99 commented on 2021-09-10 21:23 (UTC) (edited on 2021-09-29 20:17 (UTC) by monarc99)

i made my own PKGBUILD for 1.29.77 a few days ago. Maybe you can use something from it.

a good source for the patches is the arch chromium PKGBUILD

https://github.com/archlinux/svntogit-packages/commits/master/chromium/trunk

figue commented on 2021-09-10 15:12 (UTC)

@alerque tried your build very quickly, the basic seems fine (I can't test other features unfortunately). Good job

alerque commented on 2021-09-09 18:37 (UTC)

I've been messing around with bumping this version (experimental branch here) but there are some changes to patches and I haven't had time to work out yet if dropping the patches breaks anything. If anybody wants to try out v1.29.79 and report back to me, you can get it via pacman -U https://arch.alerque.com/x86_64/brave-1.29.79-1-x86_64.pkg.tar.zst.

alerque commented on 2021-08-31 09:44 (UTC)

@figue Some packages are harder than others to keep fresh! 95% of them are super easy periodic bumps & build tests. A few big obnoxious ones (like this one!) take more time and effort than 100 simple ones (I may or may not already be having buyers remorse after adopting this!).

alerque commented on 2021-08-31 09:41 (UTC)

Appeal for co-maintainers: I'd be very interested if anybody else out there was willing to take this on. Long term I have an eye on moving it to [community], but there are a number of road blocks to overcome before that can happen: some upstream and some local to this packaging. The PKGBUILD needs a bit of work, and even without trying to clean it up maintaining Chromium builds of any kind is quite a bit of work. I adopted this with the aim of shepherding it until I feel comfortable pulling it into [community], but until then I would love if one or more co-maintainers would jump on here.

Feel free to send patches in comments, via email, or as PRs to this repository.

figue commented on 2021-08-29 21:50 (UTC) (edited on 2021-08-29 21:52 (UTC) by figue)

@alerque thank you very much for taking care.

Cheers

PD: just curiosity... How you maintain 615 packages in AUR? XD That's incredible dude. Your awesome.

alerque commented on 2021-08-29 05:59 (UTC)

@figure You can put me on it.

figue commented on 2021-08-28 23:26 (UTC)

I think I'll abandon this package. Any volunteers to adopt it? If not, I'll orphan in a few days.

figue commented on 2021-08-25 17:55 (UTC)

@jaro3 it's up to you. I'm still compiling, no issues here for now. You can restart build with "makepkg -e". Sometimes builds segfault in my build machine, but -e continue the build.

jaro3 commented on 2021-08-25 15:14 (UTC)

This package build fails again and again....

Compiling brave-rust v0.1.0 (/usr/src/tmp/brave/src/brave-browser/src/brave/build/rust) Finished release [optimized] target(s) in 2m 10s ninja: build stopped: subcommand failed. null null ==> ERROR: A failure occurred in build(). Aborting...

Does it have any merit over the easy to install bin packages? I am using the latest brave-nightly-bin and it actually works....

figue commented on 2021-08-06 15:52 (UTC)

Release 1.27.111 is untested... I don't have access to my build machine until the end of the month. If something fails or I made some mistake, post a patch or tell me and I will try to fix it. Thanks for understanding.

alerque commented on 2021-08-03 09:32 (UTC)

@rakin09 Brave is Chromium with a different skin and some other changes strapped on top. Of course it needs the Chromium sources to build. Brave did not invent a new rendering engine, only adapted one to their goals. The Chromium source tree is huge partly because Google chose to vendor everything inside it, so virtually every library it uses is in the source tree. You can think that is egregious (and I would agree with you) but it is what it is. That's not the fault of this packaging.

rakin09 commented on 2021-08-03 09:15 (UTC)

I was trying to build brave through pamac but it failed.. Then tried with trizen. I was shocked to see that trizen was downloading Chromium Sources .. Why did you add Chromium source and why it's size is 22G!?

figue commented on 2021-07-30 22:14 (UTC)

@alerque I've read a couple of github issues and forums complaining about this. The answer is that Brave is a company and they spent money in those services. So we have to understand their position. You can open an issue to their github, but is obvious that they will say the same.

The message in post_install() will be added in the next release. Thanks

alerque commented on 2021-07-30 17:14 (UTC)

@figue It might be worth having instructions for that in a post_install() message. Maybe even more important though, do we have an upstream issue open for it yet? Even if they don't take it seriously now maybe months down the road when enough people have bumped into this it could start holding weight.

figue commented on 2021-07-30 15:28 (UTC)

@alerque yeah... You can always have the official binary release and open it from time to time to keep upgrading the components. Not the ideal solution, but it works for now.

alerque commented on 2021-07-30 14:48 (UTC)

@figue That's a bummer to hear. I think it's worth fighting to keep this working, otherwise the hope of getting it in official repos goes to near zero. Unfortunately Chromium is having issues as well, and of course Firefox has had a history of issues. Browser vendors are just notorious for not being distro friendly,Brave unfortunately not being an exception.

figue commented on 2021-07-30 14:14 (UTC)

Since last upstream modifications, our user builds seems that can't pull brave components or, if you have it from the past, you can't update them. So new profiles has no adblock lists for instance.

With official binary release all works.

Does anybody know if it's worth to keep using a user build of this package? Upstream seems to be very negative to support our custom builds.

figue commented on 2021-07-26 08:24 (UTC)

@Blazing no, protobuf is downloaded and built by brave's installation

Blazing commented on 2021-07-26 02:03 (UTC) (edited on 2021-07-26 02:04 (UTC) by Blazing)

I believe python-protobuf should be in make dependencies:

[20308/52347] ACTION //third_party/dom_distiller_js:json_values_converter_test_proto_gen(//build/toolchain/linux:clang_x64)
FAILED: pyproto/third_party/dom_distiller_js/test_sample_pb2.py gen/third_party/dom_distiller_js/test_sample.pb.h gen/third_party/dom_distiller_js/test_sample.pb.cc gen/third_party/dom_distiller_js/test_sample_json_converter.h
python3 ../../tools/protoc_wrapper/protoc_wrapper.py test_sample.proto --protoc ./protoc --proto-in-dir ../../third_party/dom_distiller_js --cc-out-dir gen/third_party/dom_distiller_js --py-out-dir pyproto/third_party/dom_distiller_js --plugin ../../third_party/dom_distiller_js/protoc_plugins/json_values_converter.py --plugin-out-dir gen/third_party/dom_distiller_js --plugin-options output_dir=:
Traceback (most recent call last):
  File "/home/blazing/.cache/paru/clone/brave/src/brave-browser/src/out/Release/../../third_party/dom_distiller_js/protoc_plugins/json_values_converter.py", line 14, in <module>
    from util import plugin_protos, types, writer
  File "/home/blazing/.cache/paru/clone/brave/src/brave-browser/src/third_party/dom_distiller_js/protoc_plugins/util/plugin_protos.py", line 22, in <module>
    from google.protobuf.descriptor_pb2 import FieldDescriptorProto
ModuleNotFoundError: No module named 'google.protobuf'
--plugin_out: protoc-gen-plugin: Plugin failed with status code 1.
Protoc has returned non-zero status: 1
[20325/52347] ACTION //chrome/app:generated_resources_grit(//build/toolchain/linux:clang_x64)
ninja: build stopped: subcommand failed.
null
null
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'brave-1.27.108-1':
error: packages failed to buid: brave-1.27.108-1

figue commented on 2021-07-24 15:35 (UTC)

@tooney712 try this: https://github.com/figue/brave

I've pushed new version there... I'm having issues cloning chromium repo

==> Creando el paquete: brave 1.27.108-1 (sáb 24 jul 2021 14:25:03)
==> Comprobando dependencias mientras se ejecuta...
==> Comprobando dependencias mientras se compila...
==> Recibiendo las fuentes...
  -> Actualizando brave-browser del repositorio git...
Extrayendo origin
  -> Clonando chromium del repositorio git...
Clonando en un repositorio vacío '/DATA2/sources/chromium'...
remote: Enumerating objects: 16514771, done.
remote: Counting objects: 100% (4574/4574), done.
remote: Compressing objects: 100% (2888/2888), done.
remote: Total 16514771 (delta 1596), reused 3689 (delta 1502), pack-reused 16510197
Recibiendo objetos: 100% (16514771/16514771), 22.83 GiB | 4.48 MiB/s, listo.
error: inflate: data stream error (incorrect data check)
fatal: inconsistencia seria en inflate
fatal: fetch-pack: salida de paquete de índice no válida
==> ERROR: Hubo fallos durante la descarga de chromium del repositorio git
    Cancelando...

I don't know why git clone fails... I'm relaunching it.

tooney712 commented on 2021-07-24 14:07 (UTC)

@figue

Thanks for the tip, unfortunately it didn't work, either due to me applying it incorrectly or for some deeper reason... I'd honestly guess the former since it keeps downloading the 0.1.6 version despite the patch telling it to do otherwise.

...I'll put up a gist of the PKGBUILD with my insertions, maybe people will be able to more easily see if I've done something wrong or if it's more a problem with brave itself.

https://gist.github.com/Tooney712/797c0888466822791e2b9cc9ecd24d3a

Thanks again for the help.

figue commented on 2021-07-23 19:45 (UTC)

Hi Caleb. If this become true, I will be very very happy. This package is a huge work for me, and to have in community will be a pleasure. I can help with anything in the middle steps until it can be moved finally.

We are in touch.

Cheers

alerque commented on 2021-07-23 19:31 (UTC)

Hey guys! Wow this packaging looks like it has been a lot of work to maintain, so thanks for that. I'm a newly appointed TU and this won't be my first package to help migrate to [community] but I wanted to drop by and let you know I've got my eye on it. There are a number of things I see already that will need to be tweaked for that to happen, but I'll definitely be in touch with you guys (and hopefully the current chromium packagers as well for their experience) even before taking any steps. In the mean time I'm also helping out on brave-bin as well — at least until such a time as a binary package is available in the repos.

figue commented on 2021-07-22 07:14 (UTC) (edited on 2021-07-22 07:24 (UTC) by figue)

@tooney712 in my case, I was building brave in a clean chroot, and cargo used zeroize-1.3.0, and it worked just fine.

So it's an upstream bug. See:

https://github.com/brave/brave-browser/issues/17046

It seems the patch is merged into 1.27.x, so we will have to wait for the official release.

For now, can you test if applying this patch in prepare() you can build it?

https://github.com/brave/brave-core/commit/dd4bfdd0c173cbc35153496de0dd6896129cc896.patch

Add it to sources and after "cd src/" patch -Np1 -i ../../dd4bfdd0c173cbc35153496de0dd6896129cc896.patch

DeUltima commented on 2021-07-22 07:07 (UTC)

@tooney712 I'm having the same exact issue, try giving brave-bin a shot instead. That worked for me.

tooney712 commented on 2021-07-22 01:12 (UTC) (edited on 2021-07-22 01:17 (UTC) by tooney712)

I could use some help, the 1.26.77-1 version keeps failing on me. I've managed to figure out it's a Rust-dependencies-installing issue, where the gclient python script is calling on a cargo binary that is specified in brave's DEPS file. The actual error reads as:

error: failed to compile `cargo-audit v0.15.0`, intermediate artifacts can be found at `/tmp/cargo-installMtE6vG`

Caused by:
  failed to parse manifest at `/var/tmp/pamac-build-{USERNAME}/brave/src/brave-browser/src/brave/build/rustup/0.1.6/registry/src/github.com-1ecc6299db9ec823/zeroize-1.4.1/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature
None
Traceback (most recent call last):
  File "script/download_rust_deps.py", line 192, in <module>
    sys.exit(main())
  File "script/download_rust_deps.py", line 186, in main
    cargo_install(tool)

I then looked in download_rust_deps.py, and found the bit of code that's relevant:

tools = [
    {
        "name": "cbindgen",
        "version": "0.14.2",
    },
    {
        "name": "cargo-audit",
        "features": "vendored-openssl",
    }
]
for tool in tools:
    cargo_install(tool)

And:

# Install the tool
cargo_args = []
cargo_args.append(cargo_bin)
cargo_args.append("install")
cargo_args.append(tool["name"])
if "version" in tool:
    cargo_args.append("--version")
    cargo_args.append(tool["version"])
if "features" in tool:
    cargo_args.append("--features")
    cargo_args.append(tool["features"])

One of the crates that is listed in the tools array is calling another crate named zeroize as a dependency. So, it looks like all I have to do is set a patch during the prepare phase that adds the zeroize crate to the tools array with the feature resolver added to it. Except the cargo binary file is also telling me that the "resolver" feature isn't supported and I have to switch to the nightly channel or build in order to get support for that.

I don't know how to fix that... I'm not sure whether the cargo binary is just sent out with the depot tools or if it's a normal part of chromium, or if it's configureable to use the nightly channel or if I have to download an entirely new binary file that is the nightly build of cargo, and if I did that I'm not sure what URL I could download it from that would be safe and compatible with the build process of brave...

I've already spent several hours looking over the build files to look at what the process from beginning to where the error occurs is, and while I could possibly look up the solution and build the nightly cargo binary from scratch or something via a couple commands in the PKGINFO file, building brave already eats a lot of disk space and I would have to learn at least a little about rust, which is a language I am largely unfamiliar with... Just, please, someone help... please tell me there's an easier way or a workaround I can do quickly without increasing the build-time file size or installing brave-bin (tried that, it disagreed with my system, the built version of brave hasn't given me any issues aside from actually building it). Thanks for reading this if you actually got this far. Please help if you can, and have a nice day.

figue commented on 2021-07-20 12:14 (UTC)

@rajkrys brave is what it is... It's a chromium based browser and the method to build it is cloning "almost" all chromium plus all stuff that upstream requires. You can use my brave prebuild too (see pinned comments for the repo) or use upstream's binary using brave-bin package in AUR.

rajkrys commented on 2021-07-20 11:52 (UTC)

@tioguda, thanks, I will do that, appreciate your advise!

tioguda commented on 2021-07-20 11:17 (UTC)

@rajkrys you can use the brave-bin package instead of this one.

rajkrys commented on 2021-07-20 11:09 (UTC) (edited on 2021-07-20 11:50 (UTC) by rajkrys)

Guys, this is crazy, cloning chromium repository from git repo takes hours, insane, one apllication update leads to few hours of waiting... sorry, but I am stopping to use Brave on Arch based desktops. Edit: thanks @tioguda, will switch to the other package :), as this one makes me going crazy :D

figue commented on 2021-07-19 09:04 (UTC)

@jaro3 for now, use COMPONENT=1

jaro3 commented on 2021-07-19 08:50 (UTC)

Cannot build this thing:

100 9177 100 9177 0 0 26903 0 --:--:-- --:--:-- --:--:-- 26991 -> Downloading brave-patches-brave-1.26-patches-1.zip... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 ==> ERROR: Failure while downloading https://gitlab.com/hadogenes/brave-patches/-/archive/brave-1.26-patches-1/brave-patches-brave-1.26-patches-1.zip Aborting...

figue commented on 2021-07-18 23:27 (UTC) (edited on 2021-07-18 23:28 (UTC) by figue)

@Linrono did you make a "git pull"?

1dbe91820081

This is the commit. You can fix it yourself.

Linrono commented on 2021-07-18 18:17 (UTC)

@figue Weird, it still fails for me. Maybe I am doing something wrong.

figue commented on 2021-07-18 16:20 (UTC)

@Linrono it was my fault... Sorry. It's fixed now.

Linrono commented on 2021-07-18 07:29 (UTC)

I am currently having trouble building this package. It gets to validating source files with sha256sums section but brave-launcher fails.

figue commented on 2021-07-16 07:02 (UTC)

@Lime this package takes 12 hours in my PC. I push my final package to a custom repo you can add. Check pinned messages for details.

Or you can use brave-bin package, which use binary prebuild by Brave team.

Lime commented on 2021-07-15 22:52 (UTC)

My CPU has been screaming for the past two and a half hours trying to update... There's no way this much compilation is necessary. Is there not a binary anywhere?

figue commented on 2021-07-05 22:27 (UTC)

@thedownstem fixed! Thanks

thedownstem commented on 2021-07-05 19:37 (UTC)

getting a sha256sum error with brave-launcher

figue commented on 2021-06-24 08:23 (UTC)

Help wanted to test new release 1.26.67, in my PC is not building (some clang failure). Can anybody test to build it? You can pull this repo: https://github.com/figue/brave

Thanks!

figue commented on 2021-06-06 17:04 (UTC)

@francoism90 why you need a signature of a custom and personal repo? I can sign anything and do the evil anyway. Signature doesn't guarantee anything. Even if I show you my system and you check the PKGBUILD sum is fine in the package, you need to trust me:

figue on pluto ~/packages/pkgs ➜  tar xOavf brave-1.25.68-1-x86_64.pkg.tar.zst .BUILDINFO | grep -E 'sha256|packager'
.BUILDINFO
pkgbuild_sha256sum = b5423748f2a2db346f6154a0c825ed1cf484cfd4c09e348b5308c5845e8a1b2b
packager = Figue <ffigue@gmail.com>

figue on pluto …/brave on  master ➜  git remote -v          
origin  ssh+git://aur.archlinux.org/brave (fetch)
origin  ssh+git://aur.archlinux.org/brave (push)

figue on pluto …/brave on  master ➜  LC_ALL=C git pull
Already up to date.

figue on pluto …/brave on  master ➜  sha256sum PKGBUILD
b5423748f2a2db346f6154a0c825ed1cf484cfd4c09e348b5308c5845e8a1b2b  PKGBUILD

The only thing you can do to trust me is reproduce my build:

https://wiki.archlinux.org/title/Reproducible_Builds

So, in that case, you wouldn't use my repo anyway.

Use it or not, trust me or not. Those files are generated at my home, with an old computer that takes me 16 hours to build, and then I upload to a server in the internet for anyone who trust. Everything is fine...

Cheers

francoism90 commented on 2021-06-06 11:27 (UTC)

I would like to use your repo, however I don't like it doesn't using any signing at all.

figue commented on 2021-06-05 17:58 (UTC)

@maverick1 I follow the official channel only: https://brave.com/latest/

@Maryll because Brave uses the Chromium engine, customized. Why do you ask?

Maryll commented on 2021-06-05 03:59 (UTC)

why does installing this package download the entire chromium project?

figue commented on 2021-04-25 00:25 (UTC)

@vate01 that's not my fault... This package takes a lot of time to download and build.

deemon commented on 2021-04-24 23:26 (UTC)

@vate01 or you could go for brave-bin instead...

vate01 commented on 2021-04-24 23:16 (UTC)

The entire day compiling this and got an error at the end. I would never do that again. Go for the snap package: https://snapcraft.io/install/brave/arch.

figue commented on 2021-04-18 19:15 (UTC)

@jaro3 COMPONENT=4 is disabled for now.

jaro3 commented on 2021-04-18 01:55 (UTC)

Doesn't build either:


  -> Downloading brave-patches-brave-1.23-patches-1.zip...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
==> ERROR: Failure while downloading https://gitlab.com/hadogenes/brave-patches/-/archive/brave-1.23-patches-1/brave-patches-brave-1.23-patches-1.zip
    Aborting...

using brave-nightly-bin at the moment....

figue commented on 2021-04-16 08:07 (UTC)

@jaro3 I moved the libva patch to system build only: 98beab40e1d8

Anyway, I'm finishing to build and test V1.23.71. So you can wait for a new update soon.

jaro3 commented on 2021-04-16 00:34 (UTC)

1.22.72-2 doesn't build:


../../third_party/libva_protected_content/va_protected_content.h:158:3: error: unknown type name 'VAEncryptionParameters'; did you mean 'VAEncryptionStatus'?
  VAEncryptionParameters*
  ^~~~~~~~~~~~~~~~~~~~~~
  VAEncryptionStatus
../../third_party/libva_protected_content/va_protected_content.h:147:3: note: 'VAEncryptionStatus' declared here
} VAEncryptionStatus;
  ^
In file included from ../../media/gpu/vaapi/vaapi_video_decode_accelerator.cc:39:
In file included from ../../media/gpu/vaapi/h264_vaapi_video_decoder_delegate.h:12:
../../media/gpu/vaapi/vaapi_video_decoder_delegate.h:98:7: error: unknown type name 'VAEncryptionParameters'
      VAEncryptionParameters* crypto_params,
      ^
../../media/gpu/vaapi/vaapi_video_decoder_delegate.h:99:19: error: use of undeclared identifier 'VAEncryptionSegmentInfo'
      std::vector<VAEncryptionSegmentInfo>* segments,
                  ^
In file included from ../../media/gpu/vaapi/vaapi_video_decode_accelerator.cc:39:
../../media/gpu/vaapi/h264_vaapi_video_decoder_delegate.h:73:15: error: use of undeclared identifier 'VAEncryptionSegmentInfo'
  std::vector<VAEncryptionSegmentInfo> encryption_segment_info_;
              ^
../../media/gpu/vaapi/h264_vaapi_video_decoder_delegate.h:77:3: error: unknown type name 'VAEncryptionParameters'
  VAEncryptionParameters crypto_params_;
  ^
../../media/gpu/vaapi/vaapi_video_decode_accelerator.cc:223:37: error: incompatible pointer types assigning to 'media::VaapiVideoDecoderDelegate *' from 'std::unique_ptr<media::H264VaapiVideoDecoderDelegate, std::default_delete<media::H264VaapiVideoDecoderDelegate>>::pointer' (aka 'media::H264VaapiVideoDecoderDelegate *')
    decoder_delegate_ = accelerator.get();
                        ~~~~~~~~~~~~^~~~~
../../media/gpu/vaapi/vaapi_video_decode_accelerator.cc:224:24: error: no matching constructor for initialization of 'media::H264Decoder'
    decoder_.reset(new H264Decoder(std::move(accelerator), profile,
                       ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../media/gpu/h264_decoder.h:166:3: note: candidate constructor not viable: no known conversion from 'unique_ptr<media::H264VaapiVideoDecoderDelegate, default_delete<media::H264VaapiVideoDecoderDelegate>>' to 'unique_ptr<media::H264Decoder::H264Accelerator, default_delete<media::H264Decoder::H264Accelerator>>' for 1st argument
  H264Decoder(std::unique_ptr<H264Accelerator> accelerator,
  ^
../../media/gpu/h264_decoder.h:416:28: note: candidate constructor not viable: requires 1 argument, but 3 were provided
  DISALLOW_COPY_AND_ASSIGN(H264Decoder);
                           ^
7 errors generated.
ninja: build stopped: subcommand failed.
null
null
npm ERR! code 1
npm ERR! path /usr/src/tmp/brave/src/brave-browser/src/brave
npm ERR! command failed
npm ERR! command sh -c node ./build/commands/scripts/commands.js build "Release" "--gn=custom_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=host_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=clang_use_chrome_plugins:false" "--gn=treat_warnings_as_errors:false" "--gn=fieldtrial_testing_like_official_build:true" "--gn=proprietary_codecs:true" "--gn=rtc_use_pipewire:true" "--gn=link_pulseaudio:true" "--gn=use_gnome_keyring:false" "--gn=use_sysroot:false" "--gn=use_custom_libcxx:false" "--gn=use_vaapi:true" "--gn=icu_use_data_file:false" "--gn=symbol_level:0"

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-04-15T16_39_08_653Z-debug.log
npm ERR! code 1
npm ERR! path /usr/src/tmp/brave/src/brave-browser
npm ERR! command failed
npm ERR! command sh -c npm --prefix src/brave run build -- "Release" "--gn=custom_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=host_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=clang_use_chrome_plugins:false" "--gn=treat_warnings_as_errors:false" "--gn=fieldtrial_testing_like_official_build:true" "--gn=proprietary_codecs:true" "--gn=rtc_use_pipewire:true" "--gn=link_pulseaudio:true" "--gn=use_gnome_keyring:false" "--gn=use_sysroot:false" "--gn=use_custom_libcxx:false" "--gn=use_vaapi:true" "--gn=icu_use_data_file:false" "--gn=symbol_level:0"

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-04-15T16_39_08_673Z-debug.log
==> ERROR: A failure occurred in build().
    Aborting...

figue commented on 2021-04-12 08:39 (UTC)

@anatolik no, in fact it can be added, but it needs a TU that wants to maintain and push it to [community].

anatolik commented on 2021-04-12 01:02 (UTC)

And yes I am happy to vote for it

anatolik commented on 2021-04-12 01:01 (UTC)

Is there a reason why it cannot be added to the official repo?

figue commented on 2021-04-11 09:36 (UTC)

@anatolik for now I'm not been in contacted by any TU. You can vote this package, but I doubt it will be added to official repo.

anatolik commented on 2021-04-10 17:40 (UTC)

Is there any chance to see this package in [community] repo?

figue commented on 2021-02-21 13:08 (UTC) (edited on 2021-02-21 13:10 (UTC) by figue)

I have been testing the way to keep the main sources of this package in disk and avoid to download all Chromium source everytime... Chromium is a huge project! So finally I have used the VCS package guidelines in Archwiki and I used to pull the main projects behind Brave:

  • brave-browser
  • chromium
  • depot_tools
  • brave-core
  • adblock-rust

So, now these projects are stored in your repo dir to be used in the future. Keep that in mind because it's more than 23 GB:

figue /DATA2/packages/figue/brave-aur $ du -hcs chromium brave-browser brave-core adblock-rust depot_tools
22G     chromium
20M     brave-browser
645M    brave-core
30M     adblock-rust
111M    depot_tools
23G     total

figue commented on 2021-02-19 00:25 (UTC)

We've enabled COMPONENT=4 build. Thanks to Jacek (again!). I didn't have time to verify, so I didn't bump the release. I'm curious to know how many people wants a COMPONENT=4 build. Please, comment here. Thanks!

figue commented on 2021-01-22 10:50 (UTC)

Finally we have enabled build with system libs. Thanks Jacek!

figue commented on 2021-01-12 17:41 (UTC) (edited on 2021-01-12 17:48 (UTC) by figue)

@jpmolinamatute ncurses5-compat-libs is in AUR:

https://aur.archlinux.org/packages/ncurses5-compat-libs/

jpmolinamatute commented on 2021-01-12 17:01 (UTC)

I'm installing this package for the first time and I'm getting a dependency error, error: target not found: ncurses5-compat-libs then I tried sudo pacman -S ncurses5-compat-libs and it didn't find this package, is there a workaround for this problem???

figue commented on 2021-01-08 14:10 (UTC)

@bittin I'm aware that this package is outdated. I said it a couple of days ago.

The problem with your PKGBUILD is that build with system libs (COMPONENT=4) doesn't work because patch brave-custom-build.patch is not updated. I'm waiting for Jacek, he is who implemented system build in this package. I was trying to fix it myself but unfortunately my knowledge of brave coding is poor.

As I said before. If you use COMPONENT=1 then brave compiles and works just fine. In fact my build in a chroot can be found in my personal repo:

https://mirror.lnx.im/archlinux/brave/

If you request, I can release a PKGBUILD without system libs for now. It's not a problem (it's already pushed to my github: https://github.com/figue/brave/

bittin commented on 2021-01-08 13:13 (UTC)

New PKGBUILD with todays update: http://pastie.org/p/7MI3ULwegJUj46EW5sbkmJ

figue commented on 2021-01-05 15:02 (UTC) (edited on 2021-01-05 15:02 (UTC) by figue)

BTW 1.18.77 is working fine with COMPONENT=1. I've pushed PKGBUILD to my github if anyone is interested in compiling last version. If we can't fix system build soon, I'll disable system build and push 1.18.77.

figue commented on 2021-01-04 09:02 (UTC) (edited on 2021-01-04 09:02 (UTC) by figue)

1.18.70 is pushed. For now we fixed the startup issue (segfault) thanks to Jacek's work. Now we need to review a patch to bump to 1.18.77. Stay tunned.

Warning: if brave takes long time to build, you can wait until we can work on 1.18.77.

figue commented on 2021-01-02 18:45 (UTC)

@deemon brave is basically a very tunned Chromium, so if you want to build from source you have to download all Chromium project and brave patches and build it. If you don't mind, use brave-bin.

deemon commented on 2021-01-02 05:21 (UTC) (edited on 2021-01-02 05:21 (UTC) by deemon)

dafuq is going on with this package? :D

Receiving objects:  28% (4362481/15300413), 8.55 GiB | 28.31 MiB/s   

Downloading 30GB+ objects is NOT OK.

figue commented on 2021-01-01 18:33 (UTC)

You can use brave-bin in the meantime. I will work to update this package in the next couple of days. Stay tunned.

mikesco3 commented on 2021-01-01 17:58 (UTC) (edited on 2021-01-01 17:59 (UTC) by mikesco3)

Update make sure you have installed the brave-bin package from AUR and NOT brave as the later has been flagged out of date

mikesco3 commented on 2021-01-01 17:35 (UTC) (edited on 2021-01-01 17:47 (UTC) by mikesco3)

@jaro3 I was able to solve the issue by copying libre2.so.8 and libre2.so.8.0.0 to /usr/lib from the package cache
archive in my system /var/cache/pacman/pkg/re2-1:20201001-1-x86_64.pkg.tar.zst
copy it over to a temporary folder, then use the archive manager to extract libre2.so.8 and libre2.so.8.0.0

else you can also find re2-1:20201001-1-x86_64.pkg.tar.zst over at archive.archlinux.org/packages/r/re2

and try to find libicui18n.so.67 and libicuuc.so.67 at https://archive.archlinux.org/packages/i/icu/

jaro3 commented on 2020-12-31 01:10 (UTC) (edited on 2020-12-31 01:16 (UTC) by jaro3)

After upgrading the system brave stops working:

/usr/lib/brave/brave: error while loading shared libraries: libicui18n.so.67: cannot open shared object file: No such file or directory /usr/lib/brave/brave: error while loading shared libraries: libicuuc.so.67: cannot open shared object file: No such file or directory /usr/lib/brave/brave: error while loading shared libraries: libre2.so.8: cannot open shared object file: No such file or directory

downgrading icu would break other package dependencies...

symlinks to newer versions don't work:

/usr/lib/brave/brave: symbol lookup error: /usr/lib/brave/brave: undefined symbol: _ZN3re23RE23Arg12parse_stringEPKcmPv

recompiling from source fails:


env USE_SCCACHE=0 COMPONENT=4 makepkg -s --asroot -scC -f
....
[10419/44767] CXX obj/base/i18n/string_compare.o
FAILED: obj/base/i18n/string_compare.o 
/usr/src/tmp/brave/src/brave-browser-1.17.75/src/brave/script/redirect-cc.py clang++ -MMD -MF obj/base/i18n/string_compare.o.d -DBASE_I18N_IMPLEMENTATION -DBRAVE_CHROMIUM_BUILD -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DUSE_X11=1 -DOFFICIAL_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DCR_CLANG_REVISION=\"llvmorg-12-init-5035-gd0abc757-3\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_40 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_40 -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DUCHAR_TYPE=uint16_t -DU_IMPORT=U_EXPORT -I../../brave/chromium_src -I../.. -Igen -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/zlib_shim -I../../third_party/ced/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -enable-dse-memoryssa=false -flto=thin -fsplit-lto-unit -fwhole-program-vtables -m64 -march=x86-64 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-psabi -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-final-dtor-non-final-class -Wno-builtin-assume-aligned-alignment -Wno-deprecated-copy -Wno-non-c-typedef-for-linkage -Wno-max-tokens -fno-omit-frame-pointer -g0 -ftrivial-auto-var-init=pattern -fsanitize=cfi-vcall -fsanitize-blacklist=../../tools/cfi/ignores.txt -fsanitize=cfi-icall -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -O2 -fno-ident -fdata-sections -ffunction-sections -Wno-shorten-64-to-32 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -std=c++14 -fno-trigraphs -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -D__DATE__=  -D__TIME__=  -D__TIMESTAMP__= -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -Wno-builtin-macro-redefined -Wno-unknown-warning-option -c ../../base/i18n/string_compare.cc -o obj/base/i18n/string_compare.o
../../base/i18n/string_compare.cc:21:26: error: use of undeclared identifier 'FALSE'
      icu::UnicodeString(FALSE, lhs.data(), static_cast<int>(lhs.length())),
                         ^
../../base/i18n/string_compare.cc:22:26: error: use of undeclared identifier 'FALSE'
      icu::UnicodeString(FALSE, rhs.data(), static_cast<int>(rhs.length())),
                         ^
2 errors generated.
[10424/44767] CXX obj/base/i18n/time_formatting.o
FAILED: obj/base/i18n/time_formatting.o 
/usr/src/tmp/brave/src/brave-browser-1.17.75/src/brave/script/redirect-cc.py clang++ -MMD -MF obj/base/i18n/time_formatting.o.d -DBASE_I18N_IMPLEMENTATION -DBRAVE_CHROMIUM_BUILD -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DUSE_X11=1 -DOFFICIAL_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DCR_CLANG_REVISION=\"llvmorg-12-init-5035-gd0abc757-3\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_40 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_40 -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DUCHAR_TYPE=uint16_t -DU_IMPORT=U_EXPORT -I../../brave/chromium_src -I../.. -Igen -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/zlib_shim -I../../third_party/ced/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -enable-dse-memoryssa=false -flto=thin -fsplit-lto-unit -fwhole-program-vtables -m64 -march=x86-64 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-psabi -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-final-dtor-non-final-class -Wno-builtin-assume-aligned-alignment -Wno-deprecated-copy -Wno-non-c-typedef-for-linkage -Wno-max-tokens -fno-omit-frame-pointer -g0 -ftrivial-auto-var-init=pattern -fsanitize=cfi-vcall -fsanitize-blacklist=../../tools/cfi/ignores.txt -fsanitize=cfi-icall -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -O2 -fno-ident -fdata-sections -ffunction-sections -Wno-shorten-64-to-32 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -std=c++14 -fno-trigraphs -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -D__DATE__=  -D__TIME__=  -D__TIMESTAMP__= -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -Wno-builtin-macro-redefined -Wno-unknown-warning-option -c ../../base/i18n/time_formatting.cc -o obj/base/i18n/time_formatting.o
../../base/i18n/time_formatting.cc:243:31: error: use of undeclared identifier 'TRUE'
  return U_SUCCESS(status) == TRUE;
                              ^
1 error generated.
[10432/44767] CXX obj/base/util/memory_pressure/memory_pressure/multi_source_memory_pressure_monitor.o
ninja: build stopped: subcommand failed.
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave-core@1.17.75 build: `node ./build/commands/scripts/commands.js build "Release" "--gn=custom_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=host_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=clang_use_chrome_plugins:false" "--gn=treat_warnings_as_errors:false" "--gn=fieldtrial_testing_like_official_build:true" "--gn=proprietary_codecs:true" "--gn=rtc_use_pipewire:true" "--gn=link_pulseaudio:true" "--gn=use_gnome_keyring:false" "--gn=use_sysroot:false" "--gn=use_custom_libcxx:false" "--gn=use_vaapi:true" "--gn=icu_use_data_file:false" "--gn=symbol_level:0"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave-core@1.17.75 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-12-31T00_33_53_636Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@1.17.75 build: `npm --prefix src/brave run build -- "Release" "--gn=custom_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=host_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=clang_use_chrome_plugins:false" "--gn=treat_warnings_as_errors:false" "--gn=fieldtrial_testing_like_official_build:true" "--gn=proprietary_codecs:true" "--gn=rtc_use_pipewire:true" "--gn=link_pulseaudio:true" "--gn=use_gnome_keyring:false" "--gn=use_sysroot:false" "--gn=use_custom_libcxx:false" "--gn=use_vaapi:true" "--gn=icu_use_data_file:false" "--gn=symbol_level:0"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave@1.17.75 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-12-31T00_33_53_656Z-debug.log
==> ERROR: A failure occurred in build().
    Aborting...

figue commented on 2020-12-23 07:32 (UTC)

@deemon

figue on pluto …/brave-github on  master [?] took 15s ➜  grep python2-xcb-proto .SRCINFO 
    makedepends = python2-xcb-proto

deemon commented on 2020-12-23 00:59 (UTC)

Brave install needs python2-xcb-proto which fails to install due to failing importing the PGP keys.

mikesco3 commented on 2020-12-22 22:01 (UTC) (edited on 2020-12-22 22:03 (UTC) by mikesco3)

Finally finished compiling and upgrading this morning at about 9am after almost 40 hours...

I hope the logs that I gathered help in any way...
@figue please let me know if there is anything I could provide that would help

figue commented on 2020-12-22 22:01 (UTC)

@techandy1 when build is done makepkg strip the executable to a "normal size". I don't know why did not happen in your case. Latest package I've build is 239,26 MiB (chromium is 209,31 MiB).

commented on 2020-12-22 19:42 (UTC)

Why in the world is this version of the Brave browser almost 20 GB in size when the last version was approx. 30+ MB. This is odd. Even the download package from the website itself is not even close to the 20 GB like this package is.

mikesco3 commented on 2020-12-22 13:14 (UTC) (edited on 2020-12-22 13:17 (UTC) by mikesco3)

and also checked the package info in manjaro and it points to this
http://aur.archlinux.org/packages/brave
and
Maintainer: figue

mikesco3 commented on 2020-12-22 13:11 (UTC) (edited on 2020-12-22 13:16 (UTC) by mikesco3)

I was able to abbreviate the log by replacing a lot of the lines between stuff with ...
here is a pastebin link
https://pastebin.com/EZXewDsC

mikesco3 commented on 2020-12-22 12:36 (UTC) (edited on 2020-12-22 13:16 (UTC) by mikesco3)

@figue Thank you for answering, I just updated what Manjaro was offering ...
now about 6:30am the following day and still compiling
at this point I'm doing this mostly out of curiosity..
I went back through the log to try to answer your question I figured it would be just easier to upload to pastebin...
(I replaced some of the lines between the 0% and 100% with ... )
future me: had to search pastebin alternative due to size limit...
here is the url: https://filebin.ca/5lcOimEGjAQ7/ManjaroBraveUpdate.txt

figue commented on 2020-12-21 18:43 (UTC)

@mikesco3 thanks. Where did you download the sources from? AUR or my github?

In my case, building in a clean chroot or normal build results in a segfault at start.

mikesco3 commented on 2020-12-21 13:54 (UTC)

I've been downloading/compiling brave for about 10 hours now... running Manjaro (started the update last night at around 10pm, now it's currently almost 8am) and now scrolling through: [23949/44767] CXX obj/services/network/public/cpp/cpp/cross_thread_pending_shared_url_loader_factory.o [23950/44767] CXX obj/services/network/public/cpp/cpp/ip_address_space_util.o

I'm willing to share logs if necessary...

Gio commented on 2020-12-19 21:29 (UTC)

Thank You @figue for the prompt response. I'll wait for the updates then.

Keep up the good work!

figue commented on 2020-12-19 21:11 (UTC)

@Gio please update your system first. Probably you have an old icu package. Anyway, a newest version of brave is out, but for some reason, it results in a core dump and doesn't work. Be patient for now. In the meantime you can use brave-bin.

Gio commented on 2020-12-19 20:45 (UTC)

Hi. When trying to install, I get the following error:

==> Validating source files with sha256sums... v1.17.75.tar.gz ... Passed brave-launcher ... Passed brave-browser.desktop ... Passed chromium-launcher-6.tar.gz ... Passed chromium-87-patchset-9.tar.xz ... Passed brave-custom-build.patch ... Passed chromium-skia-harmony.patch ... Passed ==> Removing existing $srcdir/ directory... ==> Extracting sources... -> Extracting v1.17.75.tar.gz with bsdtar -> Extracting chromium-launcher-6.tar.gz with bsdtar -> Extracting chromium-87-patchset-9.tar.xz with bsdtar ==> Starting prepare()... -> Prepare the environment... node: error while loading shared libraries: libicui18n.so.65: cannot open shared object file: No such file or directory ==> ERROR: A failure occurred in prepare(). Aborting...

figue commented on 2020-12-18 16:01 (UTC)

@srevinsaju thanks. Yes, I know... It should be rebuild.

On the other hand, Jacek is helping me to figure out why any compilation results in a segfault at the start... That's the reason why this package is not updated yet.

Any help is appreciated. Development can be followed in my github: https://github.com/figue/brave

srevinsaju commented on 2020-12-18 13:29 (UTC)

The latest build on @figue's repo does not work now,

/usr/lib/brave/brave: error while loading shared libraries: libre2.so.8: cannot open shared object file: No such file or directory

It seems like arch packages updated to libre2.so.9, libre.so.9 is now missing.

figue commented on 2020-12-06 17:02 (UTC)

@gondsman we are looking into it.

gondsman commented on 2020-12-06 16:20 (UTC)

1.17.75 still crashes on my side... On my laptop with Arch it does so frequently but not always (every ~15 minutes or so), on my desktop with Manjaro (I know it's not supported, but I might as well report it) it crashes every time I launch it within 1 second.

jaro3 commented on 2020-12-06 12:58 (UTC)

1.17.75-1 compiles and seems to work fine at my end :-)

jaro3 commented on 2020-11-29 23:43 (UTC)

env USE_SCCACHE=0 COMPONENT=4 makepkg -s --asroot -scC

built on latest Arch release...

Kido commented on 2020-11-29 20:53 (UTC) (edited on 2020-11-29 20:53 (UTC) by Kido)

1.17.73-1 works fine for me so far. Tested on youtube.com, google.com, habr.com

It was built with:

env LANG=C USE_SCCACHE=0 COMPONENT=4 makepkg -sicC

figue commented on 2020-11-29 11:38 (UTC)

@jaro3 indeed. It happens to me too... What type of COMPONENT do you built? I don't have time to dig into the problem, so for now I'm running the previous release.

jaro3 commented on 2020-11-29 04:32 (UTC)

The new version 1.17.73-1 crashes :-(

jaro3 commented on 2020-11-23 23:02 (UTC)

Yes, I build as root and have to confirm something "y" in the middle of compilation as well... same as with 1.16.76-1 which is rock stable (except for screen garble after suspend - common chrome issue with nvidia)

figue commented on 2020-11-23 19:34 (UTC)

@jaro3 do you build asroot?

jaro3 commented on 2020-11-23 01:54 (UTC) (edited on 2020-11-23 02:05 (UTC) by jaro3)

https://aur.archlinux.org/cgit/aur.git/commit/?h=brave&id=ec0248d88652 compiles and works! version 1.17.73-1

env USE_SCCACHE=0 COMPONENT=4 makepkg -s --asroot -scC

but after some use it quits unexpectedly, I'm back to 1.16.76-1

figue commented on 2020-11-22 16:21 (UTC)

Ok. Let me know how it works for you. I have issues building COMPONENT=1 though... :(

jaro3 commented on 2020-11-22 16:12 (UTC)

Thanks, I missed the space, sorry, now redoing it and it seems OK ;-)

figue commented on 2020-11-22 11:09 (UTC)

@jaro3 "No space left on device"... :)

jaro3 commented on 2020-11-22 03:22 (UTC) (edited on 2020-11-22 03:25 (UTC) by jaro3)

https://aur.archlinux.org/cgit/aur.git/commit/?h=brave&id=ec0248d88652 This one fails:-(

env USE_SCCACHE=0 COMPONENT=4 makepkg -s --asroot -scC

um /usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_febvzo3g' in '/usr/src/tmp/brave/src/brave-browser-1.17.73' attempt 4 / 4
Cloning into '/usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_febvzo3g'...
remote: Enumerating objects: 1058, done.
remote: Counting objects: 100% (1058/1058), done.
remote: Compressing objects: 100% (993/993), done.
fatal: write error: No space left on device 3.40 GiB | 12.63 MiB/s   
fatal: index-pack failed
1>WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://github.com/chromium/chromium" "/usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_febvzo3g"' in /usr/src/tmp/brave/src/brave-browser-1.17.73 failed; will retry after a short nap...
Syncing projects:  50% ( 1/ 2) src

src (ERROR)
----------------------------------------
[0:00:00] Started.
[0:00:00] 
Traceback (most recent call last):
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 1043, in _Clone
    self._Run(clone_cmd, options, cwd=self._root_dir, retry=True,
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 1411, in _Run
    gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_utils.py", line 673, in CheckCallAndFilter
    raise subprocess2.CalledProcessError(
subprocess2.CalledProcessError: Command 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/chromium/chromium /usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_uhzedu_v' returned non-zero exit status -13 in /usr/src/tmp/brave/src/brave-browser-1.17.73
[0:24:37] _____ Conflicting directory found in /usr/src/tmp/brave/src/brave-browser-1.17.73/src. Moving to /usr/src/tmp/brave/src/brave-browser-1.17.73/_bad_scm/srcybchp6wm.
[0:24:37] 
Traceback (most recent call last):
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 546, in update
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 1043, in _Clone
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 1411, in _Run
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_utils.py", line 673, in CheckCallAndFilter
subprocess2.CalledProcessError: Command 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/chromium/chromium /usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_uhzedu_v' returned non-zero exit status -13 in /usr/src/tmp/brave/src/brave-browser-1.17.73

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 1043, in _Clone
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_scm.py", line 1411, in _Run
  File "/usr/src/tmp/brave/src/brave-browser-1.17.73/src/brave/vendor/depot_tools/gclient_utils.py", line 673, in CheckCallAndFilter
subprocess2.CalledProcessError: Command 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/chromium/chromium /usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_febvzo3g' returned non-zero exit status -13 in /usr/src/tmp/brave/src/brave-browser-1.17.73
----------------------------------------
Error: Command 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/chromium/chromium /usr/src/tmp/brave/src/brave-browser-1.17.73/_gclient_src_febvzo3g' returned non-zero exit status -13 in /usr/src/tmp/brave/src/brave-browser-1.17.73


Warnings:
Conflicting directory /usr/src/tmp/brave/src/brave-browser-1.17.73/src moved to /usr/src/tmp/brave/src/brave-browser-1.17.73/_bad_scm/srcybchp6wm.
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave-core@1.17.73 sync: `node ./build/commands/scripts/sync.js "--init"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave-core@1.17.73 sync script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-11-22T03_08_12_251Z-debug.log
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@1.17.73 init: `node ./scripts/init.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave@1.17.73 init script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-11-22T03_08_12_287Z-debug.log
==> ERROR: A failure occurred in prepare().
    Aborting...

figue commented on 2020-11-21 18:08 (UTC) (edited on 2020-11-21 18:11 (UTC) by figue)

@jaro3 try this commit trunk please:

https://aur.archlinux.org/cgit/aur.git/commit/?h=brave&id=ec0248d88652

It's 1.17.73

You can execute git checkout ec0248d88652deae5f12554d249cd1c72237f25e to do it. Thanks!

jaro3 commented on 2020-11-21 17:25 (UTC)

brave 1.16.76-1 compile and works fine for me with env USE_SCCACHE=0 COMPONENT=4 makepkg

figue commented on 2020-11-21 15:16 (UTC) (edited on 2020-11-21 15:17 (UTC) by figue)

I've reverted latest release because it's not working here with COMPONENT=4. Brave crash and my last session history was gone... Can anyone use ec0248d88652 to build brave with system libs and see if it's working fine? I'm rebuilding normal release... Will notice when it ends.

kiankasad commented on 2020-11-15 00:21 (UTC)

@figue Yes, it builds fine without sccache.

figue commented on 2020-11-14 15:43 (UTC) (edited on 2020-11-14 15:44 (UTC) by figue)

@kiankasad can you relaunch build without SCCACHE (makepkg -e)? But before edit ./src/brave-browser-1.16.76/.npmrc and delete sccache line.

kiankasad commented on 2020-11-14 00:36 (UTC)

Building using:

env SCCACHE_DIR=/mnt/sccache USE_SCCACHE=1 COMPONENT=4 makepkg -s

fails with the following error:

ninja: Entering directory `/mnt/brave-git/src/brave-browser/src/out/Release'
[1/44153] CXX obj/brave/components/moonpay/common/common/pref_names.o
FAILED: obj/brave/components/moonpay/common/common/pref_names.o
/mnt/brave-git/src/brave-browser/src/brave/script/redirect-cc.py clang++ [...] -fsanitize-blacklist=../../tools/cfi/ignores.txt [...] -c ../../brave/components/moonpay/common/pref_names.cc -o obj/brave/components/moonpay/common/common/pref_names.o
sccache: encountered fatal error
sccache: error : Failed to open file for hashing: "../../tools/cfi/ignores.txt"
sccache:  cause: Failed to open file for hashing: "../../tools/cfi/ignores.txt"
sccache:  cause: No such file or directory (os error 2)

I can cd into the directory ninja reports and cat ../../tools/cfi/ignores.txt just fine.

I'm not sure if this is an upstream error or one caused by the way the PKGBUILD sets things up.

figue commented on 2020-11-13 07:27 (UTC)

@jaro3 thanks. I'm just finishing 1.16.76. Wait until it will be pushed to build it again.

jaro3 commented on 2020-11-13 01:10 (UTC)

1.16.72-2 builds fine for me too :-) will try the new release....

Kido commented on 2020-11-12 07:48 (UTC)

@figue 1.16.72-2 builds fine for me with USE_SCCACHE=0 COMPONENT=4

figue commented on 2020-11-11 12:43 (UTC)

Our contributor Jacek fixed release with custom cflags and system libs (COMPONENT=4).

Please, can anybody try if all is ok? Thanks!

figue commented on 2020-11-03 17:55 (UTC)

@luntik2012 are you trying to build brave in /tmp? The sources and compilation require more than 30GB of free space. My recommendation is to clone repo manually and build with makepkg in a local disk (SSD better) with enough free space.

luntik2012 commented on 2020-11-03 17:07 (UTC)

  -> Prepare the environment...

added 641 packages, and audited 641 packages in 10s

found 0 vulnerabilities
npm notice 
npm notice New patch version of npm available! 7.0.5 -> 7.0.7
npm notice Changelog: https://github.com/npm/cli/releases/tag/v7.0.7
npm notice Run npm install -g npm@7.0.7 to update!
npm notice 

> brave@1.16.69 init
> node ./scripts/init.js

Performing initial checkout of brave-core
Cloning brave-core [undefined] into /tmp/yaourt-tmp-user/aur-brave/src/brave-browser/src/brave...
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/yaourt-tmp-user/aur-brave/src/brave-browser/src/brave
> git clone  .

fatal: repository 'undefined' does not exist

npm ERR! code 1
npm ERR! path /tmp/yaourt-tmp-user/aur-brave/src/brave-browser
npm ERR! command failed
npm ERR! command sh -c node ./scripts/init.js

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/user/.npm/_logs/2020-11-03T17_10_16_770Z-debug.log
==> ERROR: A failure occurred in prepare().
    Aborting...
==> ERROR: Makepkg was unable to build .
==> Restart building brave ? [y/N]

figue commented on 2020-11-02 10:00 (UTC)

@jaro3 Thanks for reporting... I can't test COMPONENT=4 right now, build with 1 for now. Probably we need to update some patch.

jaro3 commented on 2020-11-02 00:49 (UTC) (edited on 2020-11-02 00:51 (UTC) by jaro3)

Latest build fails (COMPONENT=4):


[26075/44173] CXX obj/brave/components/ipfs/browser/browser/translate_ipfs_uri.o
FAILED: obj/brave/components/ipfs/browser/browser/translate_ipfs_uri.o 
/usr/src/tmp/brave/src/brave-browser/src/brave/script/redirect-cc.py clang++ -MMD -MF obj/brave/components/ipfs/browser/browser/translate_ipfs_uri.o.d -DBRAVE_CHROMIUM_BUILD -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DOFFICIAL_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_40 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_40 -DVK_USE_PLATFORM_XCB_KHR -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DUPDATER_DEV_ENDPOINT=\"\" -DUPDATER_PROD_ENDPOINT=\"\" -I../../brave/chromium_src -I../.. -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/zlib_shim -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -Igen/shim_headers/libpng_shim -Igen/shim_headers/libwebp_shim -I../../third_party/libyuv/include -I../../third_party/jsoncpp/source/include -I../../third_party/jsoncpp/generated -Igen/shim_headers/opus_shim -Igen/shim_headers/ffmpeg_shim -I../../third_party/vulkan_headers/include -Igen/shim_headers/re2_shim -Igen/shim_headers/snappy_shim -I../../third_party/khronos -I../../gpu -Igen/third_party/dawn/src/include -I../../third_party/dawn/src/include -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -fprofile-sample-use=../../chrome/android/profiles/afdo.prof -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -flto=thin -fsplit-lto-unit -fwhole-program-vtables -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -Wimplicit-fallthrough -Wthread-safety -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-psabi -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-final-dtor-non-final-class -Wno-builtin-assume-aligned-alignment -Wno-deprecated-copy -Wno-non-c-typedef-for-linkage -Wno-string-concatenation -Wno-max-tokens -fno-omit-frame-pointer -ftrivial-auto-var-init=pattern -fsanitize=cfi-vcall -fsanitize-blacklist=../../tools/cfi/ignores.txt -fsanitize=cfi-icall -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -std=c++14 -fno-trigraphs -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -Wno-deprecated-declarations -D_FORTIFY_SOURCE=2 -D__DATE__=  -D__TIME__=  -D__TIMESTAMP__= -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -Wno-builtin-macro-redefined -Wno-unknown-warning-option -c ../../brave/components/ipfs/browser/translate_ipfs_uri.cc -o obj/brave/components/ipfs/browser/browser/translate_ipfs_uri.o
../../brave/components/ipfs/browser/translate_ipfs_uri.cc:38:30: error: no member named 'all_of' in namespace 'std'
    if ((ipfs_scheme && std::all_of(cid.begin(), cid.end(),
                        ~~~~~^
1 error generated.
[26088/44173] CXX obj/brave/components/brave_referrals/browser/browser/brave_referrals_service.o
ninja: build stopped: subcommand failed.
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave-core@1.16.69 build: `node ./build/commands/scripts/commands.js build "Release" "--gn=custom_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=host_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=clang_use_chrome_plugins:false" "--gn=treat_warnings_as_errors:false" "--gn=fieldtrial_testing_like_official_build:true" "--gn=proprietary_codecs:true" "--gn=rtc_use_pipewire:true" "--gn=link_pulseaudio:true" "--gn=use_gnome_keyring:false" "--gn=use_sysroot:false" "--gn=use_custom_libcxx:false" "--gn=use_vaapi:true" "--gn=icu_use_data_file:false" "--gn=symbol_level:0"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave-core@1.16.69 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-11-01T19_51_55_293Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@1.16.69 build: `npm --prefix src/brave run build -- "Release" "--gn=custom_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=host_toolchain:\"//build/toolchain/linux/unbundle:default\"" "--gn=clang_use_chrome_plugins:false" "--gn=treat_warnings_as_errors:false" "--gn=fieldtrial_testing_like_official_build:true" "--gn=proprietary_codecs:true" "--gn=rtc_use_pipewire:true" "--gn=link_pulseaudio:true" "--gn=use_gnome_keyring:false" "--gn=use_sysroot:false" "--gn=use_custom_libcxx:false" "--gn=use_vaapi:true" "--gn=icu_use_data_file:false" "--gn=symbol_level:0"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave@1.16.69 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-11-01T19_51_55_313Z-debug.log
==> ERROR: A failure occurred in build().
    Aborting...

figue commented on 2020-10-21 18:20 (UTC) (edited on 2020-10-24 16:16 (UTC) by figue)

It's odd... Without ncurses5-compat-libs and COMPONENT=4 build was fine... I'll test V1.15.76 with COMPONENT=1 and without ncurses5-compat-libs...

Edit: confirmed that COMPONENT=1 now need that library libtinfo.so.5...

figue commented on 2020-10-20 21:04 (UTC)

@WnvPFWXzB569dV I had to upgrade to 16GB early this year to build brave

WnvPFWXzB569dV commented on 2020-10-20 12:31 (UTC)

For me - it fails at the linker step (linking ./chrome). @figue could you help me on that? Do you know if that could be due to low RAM? (I have 8GB and I thought it should be enough, but I'm not sure anymore). I have a build log here: https://privatebin.net/?9a0c200586eb0511#6F6u5ydVb63dTtUdEyA4oBGWjDBfxgFYhuspEeUKKMpV

figue commented on 2020-10-20 06:31 (UTC)

@Kido thanks

Kido commented on 2020-10-20 06:31 (UTC)

I'm compiling without setting environment variables or modifying PKGBUILD, so according to PKGBUILD it's USE_SCCACHE=0 and COMPONENT=1.

I've tried compiling in fresh chroot via https://aur.archlinux.org/packages/clean-chroot-manager/ with same rerults.

figue commented on 2020-10-20 06:17 (UTC)

@Kido are you compiling with COMPONENT=4?

Kido commented on 2020-10-20 02:30 (UTC)

@figue Brave builds and runs fine after installing ncurses5-compat-libs. Thank you.

It also runs fine after removing ncurses5-compat-libs after build. So I guess this package should go to makedepends?

figue commented on 2020-10-19 15:40 (UTC)

@Kido Can you try installing ncurses5-compat-libs package and then compile again?

Kido commented on 2020-10-19 12:51 (UTC)

I can't build 1.15.72 or 1.15.75 on fresh arch installation.

Clang can't find libtinfo.so.5:

../../third_party/llvm-build/Release+Asserts/bin/clang++: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory

Full build log: https://pastebin.com/GXBUQUcS

figue commented on 2020-10-17 16:35 (UTC)

@XavierCLL yes, I'm just finishing compilation with COMPONENT=4. I've pushed a fix a48b332f65ce always thanks to Jacek for that patch :)

jaro3 commented on 2020-10-17 11:46 (UTC)

doesn't compile: ╭────────────────────────────────────────────────────────────────╮ │ │ │ New patch version of npm available! 6.14.7 → 6.14.8 │ │ Changelog: https://github.com/npm/cli/releases/tag/v6.14.8 │ │ Run npm install -g npm to update! │ │ │ ╰────────────────────────────────────────────────────────────────╯

-> Apply Chromium patches...

patching file brave/vendor/bat-native-ads/src/bat/ads/internal/filters/ads_history_conversion_filter.cc Hunk #1 FAILED at 4 (different line endings). 1 out of 1 hunk FAILED -- saving rejects to file brave/vendor/bat-native-ads/src/bat/ads/internal/filters/ads_history_conversion_filter.cc.rej patching file brave/components/ipfs/common/ipfs_utils.cc ==> ERROR: A failure occurred in prepare(). Aborting...

hadogenes commented on 2020-10-15 07:11 (UTC) (edited on 2020-10-15 07:14 (UTC) by hadogenes)

@francoism90 I use brave-flags.conf

--enable-accelerated-video-decode                                                                                                                                                                                  
--ignore-gpu-blacklist
--in-process-gpu
--enable-gpu-rasterization
--enable-zero-copy
--enable-oop-rasterization
--enable-oop-rasterization-ddl
--enable-quic
--enable-parallel-downloading
--enable-lazy-image-loading
--enable-lazy-frame-loading
--decode-jpeg-images-to-yuv
--decode-webp-images-to-yuv
--texture-layer-skip-wait-for-activation
--omnibox-context-menu-show-full-urls
--enable-webassembly-baseline
--enable-webassembly-lazy-compilation
--enable-webassembly-simd
--enable-webassembly-threads
--enable-webassembly-tiering
--tab-groups
--tab-groups-collapse
--disable-gpu-driver-bug-workarounds

I'm not sure if --disable-gpu-driver-bug-workarounds is a good idea, but it works for me

figue commented on 2020-09-27 14:21 (UTC) (edited on 2020-09-27 14:22 (UTC) by figue)

@XavierCLL pinned your comment. Thanks!

Upstream request is opened right now, and waiting for a fix:

https://github.com/brave/brave-browser/issues/10262

XavierCLL commented on 2020-09-27 00:48 (UTC)

@figue is good to let the user know that sync function in Brave not works for non-binary release while we know how to fix it (in the pinned notes). Thanks for all you work in packaging!

figue commented on 2020-09-22 20:22 (UTC)

@jaro3 I don't know... Issue mentioned is fixed upstream. If you didn't delete src folder, can you run "makepkg -e" and post full log please?

jaro3 commented on 2020-09-21 15:18 (UTC) (edited on 2020-09-21 17:24 (UTC) by jaro3)

Doesn't build on newest Arch:

Compiling cvss v1.0.0 error[E0658]: while is not allowed in a const fn --> /usr/src/tmp/brave/src/brave-browser/src/brave/build/rustup/0.1.4/registry/src/github.com-1ecc6299db9ec823/smol_str-0.1.17/src/lib.rs:58:9 | 58 | / while i < text.len() { 59 | | buf[i] = text.as_bytes()[i]; 60 | | i += 1 61 | | } | |___^ | = note: see issue #52000 https://github.com/rust-lang/rust/issues/52000 for more information

error: aborting due to previous error

For more information about this error, try rustc --explain E0658. error: could not compile smol_str.

francoism90 commented on 2020-09-19 07:03 (UTC)

Sorry for the flag, I keep getting checksum failure on chromium-no-history.patch.

@hadogenes Would you please share your brave-flags.conf? :)

figue commented on 2020-09-17 13:33 (UTC)

NOTICE: build with COMPONENT=4 doesn't work for me in a clean enviromnent. Will try to fix it, but I've disabled in the meantime.

figue commented on 2020-09-17 13:32 (UTC)

@XavierCLL I don't use sync for a while, but I found this:

https://brave.com/signing-keys/

Maybe we need to add this key to somewhere during the compilation, but I can't figure it out. Can anyone help?

XavierCLL commented on 2020-09-17 01:38 (UTC)

Hey guys, using this packages I realiced that the sync function in Brave not work, maybe because the brave_services_key is missing, not idea if this is possible to fix, please check: https://github.com/brave/brave-browser/issues/10262

figue commented on 2020-09-02 00:04 (UTC) (edited on 2020-09-02 00:05 (UTC) by figue)

Acceleration fixed in https://mirror.lnx.im/archlinux/brave/brave-1.13.82-2-x86_64.pkg.tar.zst Please check it.

hadogenes commented on 2020-09-01 10:52 (UTC) (edited on 2020-09-01 10:58 (UTC) by hadogenes)

After adding --use-gl=desktop to ~/.config/brave-flags.conf everything works like in previous version it disables ANGLE (https://bbs.archlinux.org/viewtopic.php?pid=1922783#p1922783)

@figue it looks like we have to pack libEGL.so libGLESv2.so (like chromium) now to have hardware acceleration (the system libs works only with flag --use-gl=desktop, now default is --use-gl=egl)

figue commented on 2020-09-01 10:03 (UTC)

@el.Quero did you build your own package (then with which COMPONENT?) or are you using my package?

el.Quero commented on 2020-09-01 08:09 (UTC) (edited on 2020-09-01 08:09 (UTC) by el.Quero)

I'm experiencing the same problem reported by @Kandelborg, which are caused by Brave not making use of hardware acceleration as "brave://gpu/" page states (all the graphic features are making use of software acceleration).

I think that the error is caused by a missing library, as this console error message suggests: "Failed to load /usr/lib/brave-bin/libGLESv2.so: /usr/lib/brave-bin/libGLESv2.so: cannot open shared object file: No such file or directory". Previous Brave version is not affected by this problem.

figue commented on 2020-08-28 10:42 (UTC)

@Kandelborg I had to include some patches from Chromium in Brave. Let's wait until my build finish...

Kandelborg commented on 2020-08-28 10:27 (UTC) (edited on 2020-08-28 10:35 (UTC) by Kandelborg)

I'm on V1.13.82 according to brave About.

I just made the upgrade not long ago, rebooted and wanted to continue learning vim. Only to find that either Chromium 85 or Braves integration made it lag.

I checked firefox-dev-edition and the game works like I remember, perhaps even better. But that doesn't take away from the fact that Brave is lagging on this website, way more than it did before (if it did it was unnoticable).

Console warnings say requestAnimationFrame is taking too long, so it probably has to do with hardware acceleration or a Chromium 85 regression.

figue commented on 2020-08-28 10:25 (UTC)

@Kandelborg you mean in 1.12.114 right? I'm just compiling the new release 1.13.82...

Kandelborg commented on 2020-08-28 10:14 (UTC)

Upgrading Brave reduced the performance of vim-adventures.com by a lot. The website worked perfectly fine before the update, and in other browsers.

If you haven't upgraded yet, wait a bit, there's probably a regression that needs to be fixed.

figue commented on 2020-08-14 15:15 (UTC) (edited on 2020-08-14 15:17 (UTC) by figue)

Thanks to Jacek, we added a new option to build brave. Now you can build as release with custom cflags and system libs (like in Chromium package).

Variable is renamed to $COMPONENT. Full info is documented in PKGBUILD as always. Check it out before building.

Example to build Brave:

env USE_SCCACHE=0 COMPONENT=4 makepkg -sicC

Good job Jacek.

Cheers

figue commented on 2020-08-09 19:20 (UTC)

@hornetcluster I don't use Plasma in any computer... Maybe I need to add something?

hornetcluster commented on 2020-08-07 15:00 (UTC)

I'm on Manjaro KDE Plasma desktop, every time Brave is updated, the right-click menu from the dock/panel icon for Brave is gone. Then I edit /usr/share/applications/brave-browser.desktop to add the line from my previous comment. I don't know what's going on here.

figue commented on 2020-08-07 14:37 (UTC) (edited on 2020-08-07 14:37 (UTC) by figue)

@hornetcluster line 117 is exactly the line you request to add...

https://aur.archlinux.org/cgit/aur.git/tree/brave-browser.desktop?h=brave#n117

hornetcluster commented on 2020-08-05 23:00 (UTC)

Please add the line: Actions=new-window;new-private-window; after line no. 116 in the file brave-browser.desktop, so that right-clicking on the dock launcher icon for brave gives the options to start a 'New Window' and 'New Incognito Window'. Thanks.

figue commented on 2020-07-26 21:58 (UTC) (edited on 2020-07-26 21:59 (UTC) by figue)

@Night sorry about that. Pushed the correct patch 34ae1c595759. Please, update your local repo.

Night commented on 2020-07-26 17:22 (UTC)

The chromium-no-history.patch fails the sha256sum check for me :(

figue commented on 2020-07-18 05:35 (UTC)

I haven't time to compile until next weekend. If anybody wants to try, this is the updated PKGBUILD:

https://mirror.lnx.im/archlinux/brave/test/brave-1.11.97-1.src.tar.gz

figue commented on 2020-06-29 20:55 (UTC)

@hadogenes thanks! added.

andril commented on 2020-06-29 19:43 (UTC)

thank you figue - so much and everyone else who made this package available

hadogenes commented on 2020-06-29 12:10 (UTC)

There is missing make dependency for python2-setuptools (info: https://github.com/brave/brave-browser/wiki/Linux-Development-Environment)

figue commented on 2020-06-07 23:47 (UTC)

@mdedetrich I know. I compiled for myself and shared in my repo. Tried to use something like opensuse's build service, but as brave sources are pulled by npm it doesn't work (I was asking to ungoogled-chromium maintainer).

If this package could go to community would be awesome. I don't know if it can be proposed...

mdedetrich commented on 2020-06-07 19:36 (UTC)

How hard would it be to make this brave package official? The patches for video hardware acceleration should be in the official package and unfortunately building this off AUR takes ages (had to spend like 6 hours compiling this).

EndUserOnly commented on 2020-06-03 10:16 (UTC)

Thanks to Figue for building a package. I am really liking this browser, so far.

figue commented on 2020-05-12 20:54 (UTC) (edited on 2020-05-12 20:54 (UTC) by figue)

Thanks again mk-fg

COMPONENT variable added in last release.

In next will push your launcher code:

[[
  ( -r $(echo /proc/config.*)
    && -z $(bsdcat /proc/config.* | grep CONFIG_USER_NS=y) )
  || ( -r /proc/sys/kernel/unprivileged_userns_clone
    && $(< /proc/sys/kernel/unprivileged_userns_clone) != 1 )
]] && SANDBOX_FLAG="--no-sandbox" && echo "User namespaces are not detected as enabled on your system, Brave will run with the sandbox disabled"

Indeed Arch default kernel has that patch.

mk-fg commented on 2020-05-11 07:32 (UTC) (edited on 2020-05-11 07:49 (UTC) by mk-fg)

One problem I found after install is that Brave refuses to enable user namespace sandboxing mode, ... will need to look into it separately.

This seem to be a simple bug in brave-launcher script bundled here, this bit specifically:

if [[ ! (-r /proc/sys/kernel/unprivileged_userns_clone && $(< /proc/sys/kernel/unprivileged_userns_clone) == 1 && -n $(zcat /proc/config.gz | grep CONFIG_USER_NS=y) ) ]]; then
    >&2 echo "User namespaces are not detected as enabled on your system, Brave will run with the sandbox disabled"
    SANDBOX_FLAG="--no-sandbox"
fi

There is no "/proc/sys/kernel/unprivileged_userns_clone" in regular linux kernels (from kernel.org), as this is added by a debian patch which was explicitly rejected upstream. (see https://lwn.net/Articles/673597/ )

Not sure if Arch kernel also includes this patch (check suggests that it likely does), but I think check should be more along these lines:

[[ 
  ( -r $(echo /proc/config.*)
    && -z $(bsdcat /proc/config.* | grep CONFIG_USER_NS=y) )
  || ( -r /proc/sys/kernel/unprivileged_userns_clone
    && $(< /proc/sys/kernel/unprivileged_userns_clone) != 1 )
]] && SANDBOX_FLAG="--no-sandbox"

Reasoning:

  • Always default to enabling sandboxing to err on the secure side, even if it would crash the browser.

  • /proc/config.* might be missing entirely (module not loaded, disabled, etc).

  • bsdcat (part of libarchive pacman dependency) - because in modern kernels config can be compressed as .xz/.zst and such, not just .gz.

  • If unprivileged_userns_clone sysctl is missing (e.g. with regular vanilla linux), it is enabled as per that kernel option.

EDIT: added "-r $(echo /proc/config.*)" to check above.

mk-fg commented on 2020-05-11 06:49 (UTC) (edited on 2020-05-11 06:51 (UTC) by mk-fg)

Can confirm that component build finishes faster - something like 10 hours here, which is at least 4x faster (or maybe more) than release build.

But I think you were right in your earlier statement that it seem to be debug build not intended for regular users (though looking at both chromium and brave wikis, couldn't find it to be stated explicitly there), as after building it with just "npm run build --official_build=false", .so files in out/Component (should be copied to /usr/lib/brave) didn't get stripped by build system and had debug symbols in them.

Didn't notice anything slower about resulting browser in general, comparing to statically-linked chromium here, but didn't look too hard either, and it's also possible that these two shouldn't be comparable.

One problem I found after install is that Brave refuses to enable user namespace sandboxing mode, but that seem to be common issue that's mentioned a dozen times on Brave issue tracker, probably unrelated to build type and just due to my kernel/system configuration, will need to look into it separately.

figue commented on 2020-05-10 08:56 (UTC)

yeah... in official wiki is not mentioned that:

https://github.com/brave/brave-browser/wiki

Well I think I'll change that variable for the next release. It's a shame that build can not be incremental... gclient reset all compiled stuff everytime you want to compile a new release.

mk-fg commented on 2020-05-10 08:52 (UTC) (edited on 2020-05-10 08:53 (UTC) by mk-fg)

If you’re going to contribute to Brave browser open source project, you should know that npm run build (without Release parameter) will provide a debug build.

That's actually what I'd expect to happen with BUILD=debug parameter - i.e. have component build split into .so files, so that e.g. gdb can work with these separately.

(well, that + passing flags to not strip binaries)

Currently it seem to be also building Release bundle, which looks weird to me, but then again, no idea if maybe right thing to do here anyway.

figue commented on 2020-05-10 08:48 (UTC) (edited on 2020-05-10 08:48 (UTC) by figue)

COMPONENT seems fine... I've an old Intel i5, with 16GB RAM and build is slow too (~16 hours)

I think this is the tutorial where I read about build release:

https://www.unixtutorial.org/projects-compiling-brave-browser-on-linux-mint/

Here we go! Let’s build this thing. Should take an hour or two on a fast PC:

greys@xps:~/proj/brave-browser$ npm run build Release

This is a release build, meaning this is a fully performance and release-grade build of the source code. If you’re going to contribute to Brave browser open source project, you should know that npm run build (without Release parameter) will provide a debug build.

mk-fg commented on 2020-05-10 08:40 (UTC) (edited on 2020-05-10 08:45 (UTC) by mk-fg)

So I can make a generic BUILD variable, for instance: default BUILD=0: npm run build

Might also make sense to call this one "component", as that's how docs seem to refer to it.

I don't know about other types though, and whether it makes sense to use for e.g. debug build as well or not. Don't know pretty much anything about Google's build system, unfortunately.

Only noticed that default component build wasn't used when looking into why thing been building here for two days now as mentioned (and might've been for couple more at this rate).

I thought that the best build was release, according to last time I read the documentation. What do you think?

I think if component build works and takes significantly less time, it would make sense to use it as a default option, as it also seem to be default on its wiki here - https://github.com/brave/brave-browser/wiki#build-brave

But again, don't really know all pros and cons, I think it should result in slower initial startup due to dynamic linking and load a dozen .so files instead of just one binary (which can be bad thing on e.g. android).

figue commented on 2020-05-10 08:30 (UTC) (edited on 2020-05-10 08:35 (UTC) by figue)

I'm reading the documentation... So I can make a generic BUILD variable, for instance:

  • default BUILD=0: npm run build
  • if BUILD=1 or BUILD=release: npm run build Release
  • if BUILD=2 or BUILD=static: npm run build -- Static
  • if BUILD=3 or BUILD=debug: npm run build -- Release --debug_build=true --official_build=false

Has this any sense?

I thought that the best build was release, according to last time I read the documentation. What do you think?

mk-fg commented on 2020-05-10 08:09 (UTC)

@figue Looking into why my Brave build here seem to be surprisingly slow, I found that regardless of whether BUILD_RELEASE is 0 or 1, PKGBUILD runs "npm run build Release" (but with extra options in case of 0).

This is explicitly documented as:

Running a release build with npm run build Release can be very slow and use a lot of RAM especially on Linux with the Gold LLVM plugin.

So I wonder, is there a reason why PKGBUILD can't do component build (.so files, not linked into one humongous blob) when asked to build non-release version?

It'd seem to be a logical and expected thing to do for BUILD_RELEASE=0, but not sure if maybe causes any kind of issues, so thought to ask (and if so, maybe worth adding a comment or link to PKGBUILD as well).

mk-fg commented on 2020-05-10 02:31 (UTC)

@mk-fg see 9ecc75b2d88f

Ah, nice, thanks.

I've reported some time ago the support to build brave with directly the chromium tarball ... but the request was rejected

Right, guess I won't waste time reporting it again, as they should be aware of the issue.

Wanted to wait until after thing finishes building here, make sure it does work afterwards, but looks like linker memory requirements got bumped up significantly again, and my 12G of RAM no longer enough for the build (still linking via swap, and guess might be for days) :(

figue commented on 2020-05-09 23:56 (UTC)

@mk-fg see 9ecc75b2d88f

figue commented on 2020-05-09 09:28 (UTC)

I've reported some time ago the support to build brave with directly the chromium tarball (like is done in [extra] chromium package: https://commondatastorage.googleapis.com/chromium-browser-official/$pkgname-$pkgver.tar.xz) but the request was rejected...

mk-fg commented on 2020-05-09 09:11 (UTC)

If relevant and useful, I'd suggest adding it via proper .patch, and not a sed line like one I've pasted, as sed can easily fail silently in the future or tweak stuff in the wrong place.

figue commented on 2020-05-09 09:08 (UTC) (edited on 2020-05-09 09:09 (UTC) by figue)

It seems to work:

HEAD está ahora en c5f95c03 Roll recipe dependencies (trivial).
Done updating submodules...
Syncing Gclient (with reset)
/DATA2/packages/figue/brave/src/brave-browser: gclient sync --no-history --shallow --force --nohooks --with_branch_heads --with_tags --upstream
WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created.
1>________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/chromium/chromium.git --depth=1 /DATA2/packages/figue/brave/src/brave-browser/_gclient_src_CZ1ngI' in '/DATA2/packages/figue/brave/src/brave-browser'
1>Cloning into '/DATA2/packages/figue/brave/src/brave-browser/_gclient_src_CZ1ngI'...
1>remote: Enumerating objects: 325095, done.        
1>remote: Counting objects: 100% (325095/325095), done.        
1>remote: Compressing objects: 100% (243233/243233), done.        
1>remote: Total 325095 (delta 87627), reused 190448 (delta 70063), pack-reused 0        
1>Receiving objects: 100% (325095/325095), 982.75 MiB | 11.59 MiB/s, done.

mk-fg commented on 2020-05-09 08:43 (UTC)

Yes, though browser itself is still building for me (at 29769/41850 atm), as my CPU here is ~10y old (and its usage is further limited by cgroup parameters).

As ninja step in build() starts perfectly fine, don't expect it'll break now, but will definitely leave +1 comment if it will.

Didn't think reporting upstream would be useful, as presumably they do builds in some consistent environment, where keeping around full clone of chromium is not a bug but a useful feature, as switching tags there is easier with full history when Brave updates to use new version of underlying engine.

But guess it'd be not much trouble to report and ask - will do, thanks for the suggestion.

figue commented on 2020-05-09 08:32 (UTC)

@mk-fg that sounds interesting. Have you tried it? Maybe can be reported upstream, so for release purposes will save some time to prepare. Thanks!

mk-fg commented on 2020-05-09 06:00 (UTC) (edited on 2020-05-09 06:01 (UTC) by mk-fg)

I've noticed that node ./scripts/sync.js --all --run_hooks --run_sync step in prepare() tries to clone entire chromium repository using gclient.

Which takes a lot of time and space - it's a very large repo, with extensive history going back decades to original webkit iirc. But for purposes of the build, all this history does not matter and gets discarded anyway - only files from one tag checkout seem to be used.

So wonder if maybe it'd be worth adding something like this to PKGBUILD: sed -i $'s/\'sync\',/\\0 \'--no-history\', \'--shallow\',/' lib/util.js (or similar thing via patch)

That should make gclient only fetch last checkout without history, which would still be around gigabyte, but small compared to an entire git repo.

nuc commented on 2020-03-30 12:27 (UTC)

Anybody else experiences a segfault after latest updates?

https://github.com/brave/brave-browser/issues/8916

gondsman commented on 2020-03-30 08:59 (UTC)

@figue I honestly have no idea how the patch works, but the chromium-vaapi package seems to be fine: https://aur.archlinux.org/packages/chromium-vaapi/ and it is supposed to use the same patch. If Brave did something to break it, then I wouldn't know how to fix it.

figue commented on 2020-03-27 16:34 (UTC)

@gondsman it was broken in a past update... If there is a new patch out there, please, link here and I will add again. Thanks!

gondsman commented on 2020-03-27 11:35 (UTC)

@figue Is there a reason why you removed the vaapi patch? I was wondering why video acceleration stopped working...

figue commented on 2020-02-14 19:32 (UTC) (edited on 2020-02-14 19:32 (UTC) by figue)

@maximbaz we have an answer from brave developers... Unfortunately they can't provide a full source tarball for now. I can workaround my build issues for now, but it takes more than 12 hours and it's annoying...

https://github.com/brave/brave-browser/issues/7385

figue commented on 2020-02-10 10:43 (UTC)

@Armeeh I've removed chromium-vaapi-fix.patch for now. Please update your local repo.

Armeeh commented on 2020-02-10 10:35 (UTC)

I'm running into an issue with the patches:

  -> Apply Chromium patches...
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- a/media/gpu/vaapi/vaapi_wrapper.cc 2019-12-09 13:51:52.000000000 -0800
|+++ b/media/gpu/vaapi/vaapi_wrapper.cc 2019-12-11 02:28:55.172810666 -0800
--------------------------

figue commented on 2020-02-09 22:44 (UTC) (edited on 2020-02-09 22:48 (UTC) by figue)

Something like this?

figue /DATA2/packages/figue/brave $ diff -u PKGBUILD PKGBUILD_with_submodules 
--- PKGBUILD    2020-02-09 23:40:38.498033102 +0100
+++ PKGBUILD_with_submodules    2020-02-09 23:39:24.401601136 +0100
@@ -36,6 +36,9 @@
             'kwallet: for storing passwords in KWallet on KDE desktops'
             'sccache: For faster builds')
 source=("git+https://github.com/brave/brave-browser.git#tag=v${pkgver}"
+        "https://chromium.googlesource.com/chromium/tools/depot_tools.git"
+        "git+https://github.com/brave/gn-project-generators"
+        "git+https://github.com/pallets/jinja.git"
         'brave-vaapi-enable.patch'
         'chromium-vaapi-fix.patch'
         'brave-launcher'
@@ -56,6 +59,9 @@
 done

 sha256sums=('SKIP'
+            'ad1819717ef1bc1f4b86cf9a01be00c8c42c2d72ce3d529ba8819a3eb1872e2b'
+            'SKIP'
+            'SKIP'
             '2b07eabd8b3d42456d2de44f6dca6cf2e98fa06fc9b91ac27966fca8295c5814'
             '5a5f71370a02a6406d5f072f21bd98b4ea56d458608942bf78b6ebd8dc201c5a'
             '43f442d9ffacd69a1ca770b029083aaa544d48c052939a66e58a868d91ebde70'
@@ -71,8 +77,15 @@
             '771292942c0901092a402cc60ee883877a99fb804cb54d568c8c6c94565a48e1')

 prepare() {
+    # Update submodules
+    cd "${_reponame}"/vendor
+    git submodule init
+    git config submodule.depot_tools.git.url "${srcdir}"/depot_tools
+    git config submodule.gn-project-generators.url "${srcdir}"/gn-project-generators
+    git config submodule.jinja.git.url "${srcdir}"/jinja
+    cd ..
+
     # Apply Brave patches
-    cd "${_reponame}"
     patch -Np1 -i "${srcdir}/brave-vaapi-enable.patch"

     # Hack to prioritize python2 in PATH

I have tested and "npm run sync" or "npm run init" tries to sync submodules in any case. I don't think it has any benefit to add submodules in source array. Maybe in other packages it has, but you need internet access to download all sources in prepare().

Also, I always try to follow upstream method to build packages, so what brave developers suggest?

https://github.com/brave/brave-browser/wiki

git clone git@github.com:brave/brave-browser.git
cd brave-browser
npm install

# this takes 30-45 minutes to run
# the Chromium source is downloaded which has a large history
npm run init

FabioLolix commented on 2020-02-09 21:25 (UTC)

They are indeed pulled at some point, but is a good packaging practice to add them in source() array, this will also save time and bandwidth for multiple package builds

figue commented on 2020-02-09 18:16 (UTC)

@FabioLolix thanks, but I think that the 3 vendor submodules are pulled by npm at some point... Do you think they need to be pulled by makepkg before?

FabioLolix commented on 2020-02-09 17:33 (UTC)

Hello, configuration of git submodules is missing, there are 3 of them, let me know if you need help

figue commented on 2020-02-08 20:01 (UTC)

Bug seems fixed in a minor pre-release:

https://github.com/brave/brave-browser/issues/8134

Will push a new version now.

figue commented on 2020-02-08 15:26 (UTC) (edited on 2020-02-08 15:37 (UTC) by figue)

Can anybody try my pre-compiled new version?

https://mirror.lnx.im/archlinux/brave/test/brave-1.3.113-1-x86_64.pkg.tar.zst

Segfaults for me, but I don't have time to check it now...

Edit: with new profile seems ok... I will try to update my PC and build it again...

Found this:

https://github.com/brave/brave-browser/issues/8134

figue commented on 2020-01-28 10:26 (UTC)

@tylargh you mean to add in makedepends nodejs>=10 ?

tylargh commented on 2020-01-28 01:09 (UTC) (edited on 2020-01-28 01:09 (UTC) by tylargh)

Possible to enforce node v>=10?

https://github.com/brave/brave-browser/issues/6022

My build failed for this reason due to an older version of nodejs installed.

figue commented on 2020-01-27 10:19 (UTC) (edited on 2020-01-27 13:59 (UTC) by figue)

@aonsao I don't have this issue, could be related to graphics card/driver? I have a laptop with an integrated Intel card and no issues. If I have time later I can try to search if there is any issue in github, or do it yourself if you can:

https://github.com/brave/brave-browser/issues

Edit: Check this issue https://chromium.googlesource.com/chromium/src/+/3137000d424ddc2b1ed21c93aa9420afddaf1302 but should be fixed in latest release...

aonsao commented on 2020-01-27 01:13 (UTC)

There's an issue with fullscreen for some people, myself included. If you try to fullscreen anything while the window is maximized it only takes up the top-left portion of the screen. If you restore the window then you can go fullscreen just fine.

figue commented on 2020-01-04 16:37 (UTC)

@gardotd426 what repo? Brave sources are huge indeed, but the repo I publish for everybody [brave-archlinux] should be as is. Check yourself in your browser:

https://mirror.lnx.im/archlinux/brave/

gardotd426 commented on 2020-01-04 03:08 (UTC)

Why is this repo multiple gigabytes in size? That seems outrageously huge. Right now I've doiwnloaded 250 MiB from it, and I'm only THREE percent. There should be no way this git repo should be 6 GiB in size.

gondsman commented on 2019-12-16 09:53 (UTC)

@figue the VAAPI patch does work now, thanks a lot!

figue commented on 2019-12-13 22:54 (UTC)

Done: https://github.com/brave/brave-browser/issues/7385

maximbaz commented on 2019-12-13 22:09 (UTC)

yeah you are right about npm stuff, I remember now I also looked into making this an offline build when I first created PKGBUILD, but I couldn't figure it out so I dropped the idea. Perhaps worth trying to create a github issue for brave and ask for offline build support, they only need to provide an source tarball that already contains everything needed to build the app. Argue also that this is important for reproducible builds effort (this is totally true and important thing). Feel free to cc me in the issue.

figue commented on 2019-12-13 21:05 (UTC)

Although we find a fix for that, later npm needs to download all the sources, so obs will not work for us... I didn't find any other way to build brave (in a offline mode). Any ideas?

figue commented on 2019-12-13 20:10 (UTC)

@maximbaz yes I know, it's why you have to use _service file:

https://build.opensuse.org/package/view_file/home:ffigue/brave-arch/_service?expand=0&rev=910db01a5892ada0778c13d599b0f03e

I'm trying to figure out how declare git+https://github.com/brave/brave-browser.git#tag=v${pkgver}

Would be a lot easier to build directly form https://github.com/brave/brave-browser/archive/v1.1.20.zip but it seems that vendor files are not included, so build fails... :(

maximbaz commented on 2019-12-13 14:37 (UTC)

Ouch, it fails because it cannot access github.com during build(), and it seems it's intentional decision on their side :(

figue commented on 2019-12-13 14:24 (UTC)

@gondsman I have the patch and I'll test ASAP

@maximbaz thanks buddy. I have signed in yesterday and I'm trying to figure it out how build brave there... It fails always hahahaha

https://build.opensuse.org/package/show/home:ffigue/brave-arch

gondsman commented on 2019-12-13 11:01 (UTC)

Ehm, I've installed the latest version from your repo and GPU decoding still doesn't work despite the patch being applied (although as @maximbaz guessed it works with h264ify). Maybe something changed and made the patch non-working?

maximbaz commented on 2019-12-12 14:39 (UTC)

Guys, check this out, it seems there is a free of charge build server you can use to provide pre-built binaries: https://bbs.archlinux.org/viewtopic.php?pid=1877237#p1877237

wizard32 commented on 2019-12-06 10:45 (UTC) (edited on 2019-12-06 10:47 (UTC) by wizard32)

Thanks for the prebuilt package @figue.

Something that I noticed(or it's only to me, no clue) is that Brave cannot render the PDF for example inside the Salesforce website. If I download and open it, it works. I'll check if this happening in other sites also. Please let me know if anyone else has the same issue.

[Edited and solved]: Brave Shield blocks the content to be loaded, by disable it, it works ok

gondsman commented on 2019-11-27 09:11 (UTC) (edited on 2019-12-09 14:46 (UTC) by gondsman)

@figue thanks a lot, compiling right now (it takes ages though...). EDIT: I don't think I have the right machine to build this, my PC has tried for more than 24 hours and it was still going... I guess I'll have to rely on the prebuild version.

figue commented on 2019-11-26 19:11 (UTC)

@gondsman sorry, no particular reason. I though it wasn't needed anymore, because I didn't see in chromium package. I've pushed a new commit, please update your local repo and see if now you can build and videos work.

maximbaz commented on 2019-11-26 16:00 (UTC)

That patch is definitely needed, mostly to be able to render vp9 videos. There's high chance @gondsman that a workaroud of installing h264ify extension will fix youtube for you, until the patch is brought back.

gondsman commented on 2019-11-26 14:45 (UTC)

@figue I have the same output, but youtube doesn't load. I think it's because the new version is compiled without the chromium-vaapi-fix.patch file which was included before. Is there a reason why it was removed? According to https://github.com/brave/brave-browser/issues/1024#issuecomment-524250448 it is needed for video decoding to work on Intel 620 GPU.

ArchGuy1 commented on 2019-11-25 23:41 (UTC) (edited on 2019-11-26 01:16 (UTC) by ArchGuy1)

Thus far I've been unable to compile this package. Trying again today, so I will provide details momentarily.

EDIT: The build script only supports the LTS release of node. Upon downgrading, I then ran into an issue applying patches:

patching file third_party/blink/public/platform/web_rtc_rtp_source.h
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file third_party/blink/public/platform/web_rtc_rtp_source.h.rej
==> ERROR: A failure occurred in prepare().
    Aborting...

figue commented on 2019-11-25 14:25 (UTC) (edited on 2019-11-25 14:34 (UTC) by figue)

@gondsman I have checked in my laptop (Intel Corporation Skylake GT2 [HD Graphics 520]) and video decoding is working fine.

In brave://gpu I see:

  • Canvas: Hardware accelerated
  • Flash: Hardware accelerated
  • Flash Stage3D: Hardware accelerated
  • Flash Stage3D Baseline profile: Hardware accelerated
  • Compositing: Hardware accelerated
  • Multiple Raster Threads: Enabled
  • Out-of-process Rasterization: Disabled
  • Hardware Protected Video Decode: Hardware accelerated
  • Rasterization: Software only. Hardware acceleration disabled
  • Skia Renderer: Disabled
  • Video Decode: Hardware accelerated
  • Viz Display Compositor: Enabled
  • Viz Hit-test Surface Layer: Disabled
  • WebGL: Hardware accelerated
  • WebGL2: Hardware accelerated

Without --ignore-gpu-blacklist I get:

  • Canvas: Hardware accelerated
  • Flash: Hardware accelerated
  • Flash Stage3D: Hardware accelerated
  • Flash Stage3D Baseline profile: Hardware accelerated
  • Compositing: Hardware accelerated
  • Multiple Raster Threads: Enabled
  • Out-of-process Rasterization: Disabled
  • Hardware Protected Video Decode: Unavailable
  • Rasterization: Software only. Hardware acceleration disabled
  • Skia Renderer: Disabled
  • Video Decode: Unavailable
  • Viz Display Compositor: Enabled
  • Viz Hit-test Surface Layer: Disabled
  • WebGL: Hardware accelerated
  • WebGL2: Hardware accelerated

and youtube is working fine also.

Check logs in the endo of brave://gpu

gondsman commented on 2019-11-25 10:00 (UTC)

Is VA-API acceleration working for anyone? I'm running an 8th gen intel chip and youtube videos don't play if I enable the --ignore-gpu-blacklist flag, while it works fine with the chromium-vaapi package.

figue commented on 2019-11-21 22:55 (UTC)

@coxackie: I didn't add signature in makepkg.conf, just ignore it:

SigLevel = Never

coxackie commented on 2019-11-20 18:33 (UTC) (edited on 2019-11-21 08:14 (UTC) by coxackie)

@figue:

Just tried the pre-built from your repo - after downloading, I get:

error: brave: missing required signature
error: failed to commit transaction (package missing required signature)

Could you please provide the signature?

figue commented on 2019-11-20 16:50 (UTC) (edited on 2021-07-19 09:26 (UTC) by figue)

If somebody wants to try my prebuilt package can add this repo:

[brave-archlinux]
Server = https://mirror.lnx.im/archlinux/brave

Compilation is using ccm64 and default makepkg.conf, only tuned the PACKAGER and MAKEFLAGS="-j5".

Pacman key has to be imported manually:

$ sudo pacman-key --keyserver hkps://keys.openpgp.org/ --recv-keys 8A8C604C6EA9264B
$ sudo pacman-key --keyserver hkps://keys.openpgp.org/ --lsign-key 8A8C604C6EA9264B

figue commented on 2019-11-20 11:53 (UTC) (edited on 2019-11-20 11:54 (UTC) by figue)

Pushed v1.0.1. Added a few things. Please review PKGBUILD as you can use ccache if you set a variable or build release or not. By default ccache is not used and build is release.

Also patches are pulled directly from Archlinux repos.

Please test and report if I forgot something.

Example building with ccache enabled:

env USE_SCCACHE=1 BUILD_RELEASE=1 makepkg -sic

figue commented on 2019-11-18 16:45 (UTC)

I'm trying 1.0.0 now... Please, wait a bit longer

Mark1 commented on 2019-11-18 09:14 (UTC) (edited on 2019-11-18 09:15 (UTC) by Mark1)

Many thanks to figue! Do you know any available 0.71.114-1 compiled package? Thanks again!

figue commented on 2019-11-15 09:49 (UTC) (edited on 2019-11-15 09:50 (UTC) by figue)

A friend of mine compiled a package for us to test:

https://mirror.lnx.im/archlinux/brave/brave-0.70.123-1-x86_64.pkg.tar.xz

I've ordered 8 GB RAM for my old PC, hope it can help to build this package :)

maximbaz commented on 2019-11-14 16:27 (UTC)

Seeing this, I wonder if Manjaro folks would be willing to provide precompiled binaries for this pkg for you guys: https://twitter.com/ManjaroLinux/status/1194749794851459079

figue commented on 2019-11-13 19:33 (UTC) (edited on 2019-11-13 19:33 (UTC) by figue)

@nuc yes, it's normal... And even more:

https://chromium.googlesource.com/chromium/src/+/master/docs/linux_build_instructions.md#System-requirements

System requirements:

  • A 64-bit Intel machine with at least 8GB of RAM. More than 16GB is highly recommended.
  • At least 100GB of free disk space.
  • You must have Git and Python v2 installed already.

nuc commented on 2019-11-13 19:24 (UTC) (edited on 2019-11-13 19:24 (UTC) by nuc)

Is it normal that compiling this package needs about 17.5GB of files?

I don't even have that much space left on my hard drive lol

figue commented on 2019-11-11 22:23 (UTC)

I pushed a pre-release by mistake. Will fix in the next commit.

Anyone here is building brave? I tried several time, but never could finish compiling... I don't know what I can do. Will try to increase RAM as soon as I can, but in the meantime: anybody can build it? Or anybody know if I can request a piece of machine to build and maintain this package? I was thinking in request help in arch forums or even in an independent group like archlinuxcn... Thanks in advance

figue commented on 2019-11-03 21:37 (UTC) (edited on 2019-11-03 21:40 (UTC) by figue)

@sanduhrs as I said, I've been trying to build brave in my own machine. Finally after a week trying many things, I have to stop. Probably my desktop doesn't have enough memory (it has only 8 GB). As I already import last patches from chromium etc, I will push the new version, then if you want to maintain the package because you can build it, please, request and I will orphan again the package so you can adopt it.

sanduhrs commented on 2019-11-03 21:28 (UTC)

@maximbaz, please orphan the package if you don't want to maintain it anymore.

maximbaz commented on 2019-10-27 19:17 (UTC)

Interesting finding!

figue commented on 2019-10-27 19:15 (UTC)

Maybe it is, after first build use:

makechrootpkg -n -r /var/lib/archbuild/extra-x86_64

https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_clean_chroot#Handling_major_rebuilds

maximbaz commented on 2019-10-27 18:32 (UTC)

Wow that's slow! Makes sense to stop if it won't finish overnight. I'm not sure it's possible to preserve the sources (I think not), it didn't bother me too much to download sources every time as it's a small price for building in guaranteed clean environment, and downloading sources takes up nothing comparing to the actual build time anyway :D

figue commented on 2019-10-27 18:19 (UTC) (edited on 2019-10-27 18:19 (UTC) by figue)

Tried with extra-x86_64-build (also pushed new version, with new patches from chromium), but it seems the same:

[39334/39369] STAMP obj/brave/renderer/renderer.stamp
[39335/39369] STAMP obj/components/content_capture/renderer/renderer.stamp
[39336/39369] AR obj/components/cdm/renderer/librenderer.a
[39337/39369] AR obj/components/contextual_search/content/librenderer.a
[39338/39369] AR obj/components/data_reduction_proxy/content/renderer/librenderer.a
[39339/39369] AR obj/components/page_image_annotation/content/renderer/librenderer.a
[39340/39369] AR obj/components/dom_distiller/content/renderer/librenderer.a
[39341/39369] AR obj/components/guest_view/renderer/librenderer.a
[39342/39369] AR obj/components/network_hints/renderer/librenderer.a
[39343/39369] AR obj/components/pdf/renderer/librenderer.a
[39344/39369] STAMP obj/components/safe_browsing/renderer/renderer.stamp
[39345/39369] STAMP obj/components/safe_browsing/renderer/throttles.stamp
[39346/39369] STAMP obj/components/spellcheck/renderer/renderer.stamp
[39347/39369] AR obj/components/plugins/renderer/librenderer.a
[39348/39369] AR obj/components/visitedlink/renderer/librenderer.a
[39349/39369] AR obj/components/translate/content/renderer/librenderer.a
[39350/39369] STAMP obj/content/app/content_main_runner_both.stamp
[39351/39369] STAMP obj/content/app/both.stamp
[39352/39369] AR obj/components/web_cache/renderer/librenderer.a
[39353/39369] STAMP obj/content/public/app/both.stamp
[39354/39369] STAMP obj/extensions/renderer/renderer.stamp
[39355/39369] AR obj/components/printing/renderer/librenderer.a
[39356/39369] AR obj/headless/libheadless_renderer.a
[39357/39369] AR obj/components/subresource_filter/content/renderer/librenderer.a
[39358/39369] STAMP obj/components/page_load_metrics/renderer/renderer.stamp
[39359/39369] AR obj/components/autofill/content/renderer/librenderer.a

Compilation stuck there, with this process running:

figue     443600 54.4 56.7 28339952 4437468 pts/0 Dl  18:23  28:27 /build/brave/src/brave-browser/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld @/tmp/response-e9f367.txt

I can see disk I/O working... I can wait several hours (it's running for almost 12h now) but if tomorrow I don't see any advance I'll stop.

Also one question: do you download all sources every time? Is there any possibility to maintain sources and sync only changes when you use extra-x86_64-build?

maximbaz commented on 2019-10-24 18:29 (UTC)

I've always been building in chroot via extra-x86_64-build from devtools pkg, helps to avoid problems like these :)

figue commented on 2019-10-24 18:20 (UTC) (edited on 2019-10-24 18:25 (UTC) by figue)

and now "makepkg -e":

ERROR at //printing/BUILD.gn:159:22: Script returned non-zero exit code.
      cups_version = exec_script("cups_config_helper.py",
                     ^----------
Current dir: /DATA2/packages/figue/brave/src/brave-browser/src/out/Release/
Command: python /DATA2/packages/figue/brave/src/brave-browser/src/printing/cups_config_helper.py --api-version /DATA2/packages/figue/brave/src/brave-browser/src/build/linux/debian_sid_amd64-sysroot
Returned 1.
stderr:

  File "/DATA2/packages/figue/brave/src/brave-browser/src/printing/cups_config_helper.py", line 70
    print 'cups-config not found: %s' % cups_config
                                    ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print('cups-config not found: %s' % cups_config)?

See //BUILD.gn:142:7: which caused the file to be included.
      "//printing:printing_unittests",
      ^------------------------------
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@0.69.135 build: `node ./scripts/commands.js build "Release"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave@0.69.135 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/figue/.npm/_logs/2019-10-24T18_02_22_860Z-debug.log
==> ERROR: Se produjo un fallo en build().
    Cancelando...

Edit: ok, build() don't have python2 PATH... Just added and just executed "makepkg -e"... Will report later.

maximbaz commented on 2019-10-24 18:18 (UTC)

That's disappointing... will you be trying again?

figue commented on 2019-10-24 18:01 (UTC)

Finally it finished... but:

[13243/13252] LINK ./v8_context_snapshot_generator
FAILED: v8_context_snapshot_generator 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -Wl,--build-id=sha1 -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -flto=thin 
-Wl,--thinlto-jobs=8 -Wl,--thinlto-cache-dir=thinlto-cache -Wl,--thinlto-cache-policy,cache_size=10\%:cache_size_bytes=10g:cache_size_files=100000 -Wl,--lto-O0 -fwhole-program-vtables -m64 -Werror -Wl,-O2 -Wl,--gc-sections -Wl,--gdb-inde
x -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linu
x/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -fsanitize=cfi-vcall -fsanitize=cfi-icall -pie -Wl,--disable-new-dtags -Wl,--icf=none -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -o "./v8_context_snapshot_gen
erator" -Wl,--start-group @"./v8_context_snapshot_generator.rsp"  -Wl,--end-group   -ldl -lpthread -lrt -lgmodule-2.0 -lglib-2.0 -lgobject-2.0 -lgthread-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lresolv -lgio-2.0 -lexpat -lu
uid -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lXrandr -lpci -lXss -ldbus-1 -lasound -lm -lz 
clang: error: unable to execute command: Killed
clang: error: linker command failed due to signal (use -v to see invocation)
ninja: build stopped: subcommand failed.
null
null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! brave@0.69.135 build: `node ./scripts/commands.js build "Release"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the brave@0.69.135 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/figue/.npm/_logs/2019-10-24T13_35_14_250Z-debug.log
==> ERROR: Se produjo un fallo en build().
    Cancelando...

figue commented on 2019-10-24 10:13 (UTC)

figue ~ $ ps aux | grep [b]rave
figue     150175  0.0  3.8 513364 298788 pts/1   S+   oct23   0:17 /DATA2/packages/figue/brave/src/brave-browser/vendor/depot_tools/ninja-linux64 -C /DATA2/packages/figue/brave/src/brave-browser/src/out/Release brave -k 1
figue     185895  3.3 56.7 28284644 4437764 pts/1 Dl  oct23  32:37 /DATA2/packages/figue/brave/src/brave-browser/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld @/tmp/response-dd68af.txt

Dl STAT means that is doing something busy in disk IO... But anyway it's stuck for long time. I'll try to "makepkg -e" and see if it finishes.

maximbaz commented on 2019-10-24 09:55 (UTC)

I don't think it's normal... Hate to say it but maybe try to restart the build? It's generally a problem with everything Chromium-based, it takes soo long to compile :/

figue commented on 2019-10-24 09:33 (UTC)

@Maxim Is it normal for the compilation to be stuck at this point for a long time?

Done. Made 11999 targets from 2096 files in 18510ms
/DATA2/packages/figue/brave/src/brave-browser/src: ninja -C /DATA2/packages/figue/brave/src/brave-browser/src/out/Release brave -k 1
ninja: Entering directory `/DATA2/packages/figue/brave/src/brave-browser/src/out/Release'
[13242/13252] STAMP obj/chrome/browser_dependencies.stamp

It shows this for 12 hours approximately...

figue commented on 2019-10-22 13:30 (UTC) (edited on 2019-10-22 13:31 (UTC) by figue)

Hi Maxim. I've been using brave-bin for several months, but now I want to compile myself. I saw that you are looking for maintainers (at least for a while). I can take care of bumping this package, etc... so I can be co-maintainer if you want, but I would like to confirm if I can fully build the package in one of my machines. Let me try first, because I don't know how many time will take to complete.

Cheers and thanks for your work.

maximbaz commented on 2019-10-13 08:35 (UTC)

I would like to remove brave from my repo. Maintenance would also involve making sure that brave is able to compile (particularly important when new patches are ported from chromium or chromium-vaapi), so ideally someone will have to build the pkg at least once anyway before pushing updates to AUR.

AidanGG commented on 2019-10-13 08:23 (UTC)

@maximbaz if someone takes over maintenance, will you still offer builds from your personal repo?

maximbaz commented on 2019-10-09 08:14 (UTC)

I'm not using Brave for a while because of #5761, anyone interested to take over this package and continue maintaining it? The maintenance basically includes bumping version and following chromium or chromium-vaapi to apply the same patches as those packages do (except "chromium-system-*" ones, these need to be skipped).

maximbaz commented on 2019-09-23 09:39 (UTC)

Uh I don't really know, I'm building on a very beefy machine... Try and see how it goes :)

shaumux commented on 2019-09-23 06:38 (UTC)

How much space is required to build this?

maximbaz commented on 2019-09-03 21:32 (UTC)

Thank you for your contribution!

aichrist commented on 2019-09-03 20:32 (UTC)

@maximbaz, I put in a PR on github. I simply changed it to create a bin within ${srcdir} which seems to work fine.

maximbaz commented on 2019-09-02 20:25 (UTC)

I usually build in chroot to avoid any side-effects, but in principle I'm not against your proposal. If you have time, would you be able to submit a patch, here or directly on Github?

aichrist commented on 2019-09-02 19:30 (UTC)

The package is working fine, but this python workaround is causing some problems:

    ln -s /usr/bin/python2 "${HOME}/bin/python"                                                           
    ln -s /usr/bin/python2-config "${HOME}/bin/python-config" 

This can break many things where the user wants/expects a different python as a default. For example, installing a package like python-pivy from AUR goes into the wrong place due to this.

Since this is just for the build, it should be a temporary directory just for the build, and the path can refer to that. In general, we should probably avoid side-effects outside of the temporary build dirs when building a package.

maximbaz commented on 2019-08-12 20:34 (UTC)

In Manjaro KDE, Brave never seems to realize that it is the default browser. Is it a sandboxing issue?

This was supposedly fixed in https://github.com/maximbaz/pkgbuilds/pull/7, but to be honest I haven't experienced this issue myself. Here's also my mimeapps.list for reference.

By the way, I can also report that VA-API is working great. I can finally enable hardware acceleration and use Google Maps without it crashing after a brief time. Great work.

Yay!

wizonesolutions commented on 2019-08-12 13:51 (UTC)

By the way, I can also report that VA-API is working great. I can finally enable hardware acceleration and use Google Maps without it crashing after a brief time. Great work.

wizonesolutions commented on 2019-08-12 13:32 (UTC)

In Manjaro KDE, Brave never seems to realize that it is the default browser. Is it a sandboxing issue?

maximbaz commented on 2019-08-06 19:00 (UTC)

It is compiled with VA-API support, you enable it yourself if you pass --ignore-gpu-blacklist to the browser (directly or via ~/.config/brave-flags.conf)

Mark1 commented on 2019-08-06 13:39 (UTC)

So, this package has vaapi enabled?

maximbaz commented on 2019-07-17 16:07 (UTC)

Could you explain why?

paulodiovani commented on 2019-07-17 16:06 (UTC)

Please, add Provides: brave, brave-browser to PKGBUILD

maximbaz commented on 2019-07-11 13:03 (UTC)

You are right @wooque, it makes sense to just add all patches from extra/chromium - if you are using my repo, I'll put the new build up as soon as compilation finishes.

wooque commented on 2019-07-10 20:59 (UTC)

I'm experiencing black background flash on startup and on right click menus that were fixed in chromium: https://git.archlinux.org/svntogit/packages.git/tree/trunk/chromium-fix-window-flash-for-some-WMs.patch?h=packages/chromium

wooque commented on 2019-07-10 19:44 (UTC)

Great work, I tried Brave in the past, but lack of VA-API support was deal breaker, I can report that VA-API is working on Intel i5-5300U.

maximbaz commented on 2019-07-10 11:26 (UTC) (edited on 2019-10-24 18:17 (UTC) by maximbaz)

I'm experimenting with Brave, this PKGBUILD also adds hardware video acceleration support via VA-API (you need to pass --ignore-gpu-blacklist if you want to enable hardware video acceleration using VA-API).