Package Details: caddy-full-bin 0.11.1-1

Git Clone URL: https://aur.archlinux.org/caddy-full-bin.git (read-only)
Package Base: caddy-full-bin
Description: A configurable, general-purpose HTTP/2 web server for any platform (All features enabled)
Upstream URL: https://caddyserver.com
Keywords: http2 proxy webserver
Licenses: Apache
Conflicts: caddy, caddy-all-features, caddy-git
Provides: caddy
Submitter: klingt.net
Maintainer: klingt.net
Last Packager: klingt.net
Votes: 24
Popularity: 0.000517
First Submitted: 2016-07-27 09:09
Last Updated: 2018-11-19 10:33

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 ... Next › Last »

vith commented on 2016-10-05 16:58

==> Starting prepare()...
-> Patching systemd service file
patching file /home/vith/.cache/pacaur/caddy-full-bin/src/init/linux-systemd/caddy.service
Hunk #2 FAILED at 38.
1 out of 2 hunks FAILED -- saving rejects to file /home/vith/.cache/pacaur/caddy-full-bin/src/init/linux-systemd/caddy.service.rej
==> ERROR: A failure occurred in prepare().
Aborting...

klingt.net commented on 2016-10-04 08:31

@simon04 It is a `HEREDOC` that gives some migration instructions, see https://github.com/klingtnet/caddy-AUR/blob/url-shortener-fix/caddy-full-bin.install#L8-L15

It looks like you're running `/bin/sh` which was originally a bourne shell but is now bash with restricted feature set.
Hence, there is no heredoc support.

I may will replace the HEREDOC with single `echo` calls in an upcoming package release.

klingt.net commented on 2016-10-04 08:31

@simon04 It is a `HEREDOC` that gives some migration instructions, see https://github.com/klingtnet/caddy-AUR/blob/url-shortener-fix/caddy-full-bin.install#L8-L15

It looks like you're running `/bin/sh` which was originally a bourne shell but is now bash with restricted feature set.
Hence, there is no heredoc support.

I may will replace the HEREDOC with single `echo` calls in an upcoming package release.

simon04 commented on 2016-10-04 06:36

There seems to be a typo in the install script:

(1/1) upgrading caddy-full-bin [########################################################################################] 100%
cat: With: No such file or directory
cat: the: No such file or directory
cat: package: No such file or directory
cat: level: No such file or directory
cat: 0.9.3-5: No such file or directory
cat: the: No such file or directory
cat: caddy: No such file or directory
cat: user: No such file or directory
cat: is: No such file or directory
cat: changed: No such file or directory
cat: from: No such file or directory
cat: www-data: No such file or directory
cat: to: No such file or directory
cat: http.: No such file or directory
Changing ownership of /etc/ssl/caddy to http:http
==> Making package: dropbox 11.4.21-1 (Die Okt 4 08:33:51 CEST 2016)
==> Checking runtime dependencies...

klingt.net commented on 2016-09-30 11:01

@vith:
So, I also checked nginx and mysql's PKGBUILD and can confirm that they are not restarting/stopping their services. Therefore I removed the restart/stop systemctl calls from caddy's install script as well.

I discussed the {user,group}del issue with another person and came to the conclusion that printing the instructions on how to do is this is probably the best way, like you already said. A downside of this approach is that not everybody reads the pacman update, but it won't delete any data.

vith commented on 2016-09-30 09:56

Well, stopping it and not starting it again is definitely not good. Why would it need to be stopped pre-upgrade?

I checked apache, nginx, and lighttpd; none of them stop, start, or restart automatically in any .install functions.

IMO things like userdel or restarting services can be instructions echoed for the user to handle themselves, especially since www-data isn't necessarily caddy specific.

klingt.net commented on 2016-09-30 09:24

I've another question, should caddy be automatically restarted after a package upgrade?
The current install script will stop it, but not start it again.

Ubuntu packages start services automatically after installation and I don't want to replicate this behaviour. But, if the service is already running, then it should be restarted after the package upgrade, right?

klingt.net commented on 2016-09-30 09:17

So the groupdel issue should be fixed as well. Here is the commit: https://github.com/klingtnet/caddy-AUR/commit/bd60ccef5de444f8db8d315571838452ded30db4

kseistrup commented on 2016-09-30 08:28

Please address the groupdel issue also. If there are no users mentioned after the last colon in the output from "getent group www-data", no other users than www-data had been added to said group, which can then safely be groupdel'ed. If there are users mentioned in the output, however, the install script shouldn't groupdel the group, IMHO.

klingt.net commented on 2016-09-30 08:19

Thank you for spotting this, I totally missed to check the userdel command in yesterdays PR (https://github.com/klingtnet/caddy-AUR/pull/3).
Deleting www-data's home directory is not what one would expect to be done by a package upgrade :( .
I've removed the `-r` switch and pushed a new package release.

I am really sorry for the inconvenience.