Package Details: cataclysm-dda-git 0.F.2022.05.24-1

Git Clone URL: https://aur.archlinux.org/cataclysm-dda-git.git (read-only, click to copy)
Package Base: cataclysm-dda-git
Description: A post-apocalyptic roguelike.
Upstream URL: https://cataclysmdda.org/
Licenses: CCPL:by-sa
Conflicts: cataclysm-dda, cataclysm-dda-ncurses, cataclysm-dda-tiles
Submitter: Ferk
Maintainer: gileri
Last Packager: gileri
Votes: 39
Popularity: 0.000134
First Submitted: 2013-11-23 17:41 (UTC)
Last Updated: 2022-05-24 22:02 (UTC)

Latest Comments

1 2 3 4 5 6 .. 9 Next › Last »

gileri commented on 2022-06-17 06:07 (UTC)

Maybe wait until CI gcc version gets bumped to 12 or until this lint is included?

Agreed, good idea !

fogapod commented on 2022-06-14 06:50 (UTC)

Will update the package if this is resolved upstream.

Package might break again if they don't include this lint in testing suite. Maybe wait until CI gcc version gets bumped to 12 or until this lint is included?

gileri commented on 2022-06-03 20:10 (UTC)

Thank you @NetSysFire, I've subscribed to the issue. Will update the package if this is resolved upstream.

NetSysFire commented on 2022-06-03 19:42 (UTC)

fogapod and gileri: I am sort-of involved with cdda, here is an upstream issue I created for you: https://github.com/CleverRaven/Cataclysm-DDA/issues/58123 Patching it here works for now but this is hacky and should be fixed at the source, so please watch that issue so you know when it is resolved and the patch can be removed.

fogapod commented on 2022-05-28 08:39 (UTC)

is there a reason LTO=1 is not used in build step? does it take significantly longer this way?

gileri commented on 2022-05-24 22:01 (UTC)

Implemented your patch @fogapod, thank you !

fogapod commented on 2022-05-22 14:38 (UTC) (edited on 2022-05-22 17:50 (UTC) by fogapod)

hello, i tried installing this package today, i'm getting errors after a minute of compilation:

In file included from src/type_id.h:7,
                 from src/damage.h:11,
                 from src/veh_type.h:20,
                 from src/veh_type.cpp:1:
In member function ‘bool string_id<T>::operator<(const This&) const [with T = ammunition_type]’,
    inlined from ‘constexpr bool std::less<_Tp>::operator()(const _Tp&, const _Tp&) const [with _Tp = string_id<ammunition_type>]’ at /usr/include/c++/12.1.0/bits/stl_function.h:408:20,
    inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::find(const _Key&) const [with _Key = string_id<ammunition_type>; _Val = string_id<ammunition_type>; _KeyOfValue = std::_Identity<string_id<ammunition_type> >; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_tree.h:2546:33,
    inlined from ‘std::set<_Key, _Compare, _Alloc>::size_type std::set<_Key, _Compare, _Alloc>::count(const key_type&) const [with _Key = string_id<ammunition_type>; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_set.h:749:25,
    inlined from ‘static void vehicle_prototype::finalize()’ at src/veh_type.cpp:1268:61:
src/string_id.h:229:24: error: array subscript 0 is outside array bounds of ‘ammotype [0]’ [-Werror=array-bounds]
  229 |             return _id._id < rhs._id._id;
      |                    ~~~~^~~
In member function ‘bool string_id<T>::operator<(const This&) const [with T = ammunition_type]’,
    inlined from ‘constexpr bool std::less<_Tp>::operator()(const _Tp&, const _Tp&) const [with _Tp = string_id<ammunition_type>]’ at /usr/include/c++/12.1.0/bits/stl_function.h:408:20,
    inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_lower_bound(_Const_Link_type, _Const_Base_ptr, const _Key&) const [with _Key = string_id<ammunition_type>; _Val = string_id<ammunition_type>; _KeyOfValue = std::_Identity<string_id<ammunition_type> >; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_tree.h:1967:29,
    inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::find(const _Key&) const [with _Key = string_id<ammunition_type>; _Val = string_id<ammunition_type>; _KeyOfValue = std::_Identity<string_id<ammunition_type> >; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_tree.h:2544:42,
    inlined from ‘std::set<_Key, _Compare, _Alloc>::size_type std::set<_Key, _Compare, _Alloc>::count(const key_type&) const [with _Key = string_id<ammunition_type>; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_set.h:749:25,
    inlined from ‘static void vehicle_prototype::finalize()’ at src/veh_type.cpp:1268:61:
src/string_id.h:229:38: error: array subscript 0 is outside array bounds of ‘ammotype [0]’ [-Werror=array-bounds]
  229 |             return _id._id < rhs._id._id;
      |                              ~~~~~~~~^~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make: *** [Makefile:950: obj/veh_type.o] Error 1
make: *** Waiting for unfinished jobs....
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: cataclysm-dda-git

i could not find anything about this error on game's github

EDIT: i fixed this by patching Makefile:

diff --git a/Makefile b/Makefile
index 56418b4be7a6..39a333e7af9a 100644
--- a/Makefile
+++ b/Makefile
@@ -109,7 +109,8 @@ WARNINGS = \
   -Wsuggest-override \
   -Wunused-macros \
   -Wzero-as-null-pointer-constant \
-  -Wno-unknown-warning-option
+  -Wno-unknown-warning-option \
+  -Wno-array-bounds
 # Uncomment below to disable warnings
 #WARNINGS = -w
 DEBUGSYMS = -g

gileri commented on 2022-03-21 08:39 (UTC)

Happy that I could help !

matthemsteger commented on 2022-03-20 16:34 (UTC)

Oh I didnt know about that option, even better! Thanks for pointing that out gileri

gileri commented on 2022-03-20 16:13 (UTC)

Thanks for the suggestion matthemsteger. Why not put it directly in /etc/makepkg.conf ?