Arch Linux User Repository

Thank you so much!

Hi HurricanePootis, thanks for the suggestions! I realize now that I also missed the message from abouvier forever ago - sorry about that. This was the first and only package I made on the AUR, and at the time I was using Arch. Now I am using a different distribution, so I have not kept an eye on this package. To not inconvenience you further, I have pushed up your changes myself - hopefully they are to your liking :) I have also disowned the package so that someone more active can maintain it.

Hello I am the maintainer of cdecrypt. This package could do with the following changes:

1. Set arch=('x86_64'). This package has a binary
2. Set license() to GPL-3.0-or-later to be SPDX compliant
3. Add provides=("${pkgname::-4}") and conflicts=("${pkgname::-4}") since this is a -git package.
4. Add depends=('glibc'). This package relies on the C library.
5. Change makedepends() to makedepends=('git'). make is included in the base-devel package, which is required to even have makepkg in the first place.
6. Add a pkgver() function. Crazy that this package doesn't have that
7. Add a prepare() function to modify the Makefile to allow passing environmental $CFLAGS and $LDFLAGS into the build system.
8. Modify the build() function to pass those flags.
9. Just use install command, do not mv.

diff --git a/PKGBUILD b/PKGBUILD
index e9ecf18..786fe0e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,22 +1,35 @@
-pkg=cdecrypt
-pkgname=$pkg-git
-pkgver=r32.0ca58c6
+pkgname=cdecrypt-git
+pkgver=4.8.r1.g0ca58c6
 pkgrel=1
 pkgdesc="A utility that decrypts Wii U NUS content files."
-arch=('any')
+arch=('x86_64')
 url="https://github.com/VitaSmith/cdecrypt"
-license=('GPL')
-makedepends=('git' 'make')
+license=('GPL-3.0-or-later')
+provides=("${pkgname::-4}")
+conflicts=("${pkgname::-4}")
+depends=('glibc')
+makedepends=('git')
 source=("git+$url")
 md5sums=('SKIP')

+pkgver() {
+  cd "$srcdir/${pkgname::-4}"
+  git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//'
+}
+
+prepare() {
+  cd "$srcdir/${pkgname::-4}"
+  sed -i 's/-O2/-O2 ${EXTRA_CFLAGS}/;s/LDFLAGS=-s/LDFLAGS=-s ${EXTRA_LDFLAGS}/' Makefile
+}
+
 build() {
-    cd $pkg
+    cd "$srcdir/${pkgname::-4}"
+    EXTRA_CFLAGS="${CFLAGS}" \
+    EXTRA_LDFLAGS="${LDFLAGS}" \
     make
 }

 package() {
-    cd $pkg
-    install -dm755 $pkgdir/usr/bin
-    mv $pkg $pkgdir/usr/bin
+    cd "${srcdir}/${pkgname::-4}"
+    install -Dm755 ${pkgname::-4} "$pkgdir/usr/bin/${pkgname::-4}"
 }

arch=('any') is not correct for a package containing a binary.