Arch Linux User Repository

@dangpzanco : #[expect] is stable since rust 1.81 (https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#expectlint), the current version in the official repos is 1.82.0. Update the rust package, or run rustup update stable if you use rustup and it should build fine.

I can't install because of error E0658 (unstable feature, I have stable rustc, so I cannot install):

For more information about this error, try `rustc --explain E0658`.

See the output:

Compiling check-broken-packages v1.0.0 (~/.cache/yay/check-broken-packages-pacman-hook-git/src/pacman-hooks/check-broken-packages)
error[E0658]: the `#[expect]` attribute is an experimental feature
   --> src/main.rs:270:5
    |
270 |     #[expect(clippy::unwrap_used)]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

error[E0658]: the `#[expect]` attribute is an experimental feature
   --> src/main.rs:272:5
    |
272 |     #[expect(clippy::unwrap_used)]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

error[E0658]: the `#[expect]` attribute is an experimental feature
   --> src/main.rs:274:5
    |
274 |     #[expect(clippy::unwrap_used)]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

error[E0658]: the `#[expect]` attribute is an experimental feature
   --> src/main.rs:217:1
    |
217 | #[expect(clippy::too_many_lines)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `check-broken-packages` (bin "check-broken-packages") due to 4 previous errors
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: check-broken-packages-pacman-hook-git-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
check-broken-packages-pacman-hook-git - exit status 4

Hi,

Thank you very much for maintaining this very useful package.

But if you let me share my advice and polite request, it would be best if you did not do empty pkgver bump commits in the future.

The purpose of a '-git' VCS package is that Arch build tools like makepkg and devtools, as well as AUR helpers already pick up changes in the upstream git repository when checking for updates. Therefore, users automatically get to compile the latest version when they initiate the build.

Also there are AUR support tools that periodically check for updates - the properly implemented ones do pick up upstream git repo changes and notify users, even without you pushing this bump in pkgver to the PKGBUILD & .SRCINFO.

Although pushing such empty pkgver bumps might not have outright harmful impact, but, depending on the AUR build tool used, it might cause someone who already built the latest commit version get a notification upon your version bump push that there is a new update, and it might trigger a rebuild of the same version - which then the AUR helper tool will not install due to same version being already installed, or it might still reinstall it, depending on the configuration. In addition, AUR users who are subscribed to package update notifications of this one will get an email about this pkgver change that is essentially meaningless to them.

Thank you in advance if you heed my advice. And again let me express my gratitude for this superb package that is truly a must-have one for me!

@desbma Thanks for cycling back. Re: First comment, you're right, it was a problem with my own setup (~/.gitconfig), so sorry for the noise.

Re: Second comment, will do.

@thiagowfx: It's a false positive because it's an Electron package. 1password ships with it's own copy of Electron which includes it's own libraries in a non-standard location.

@thiagowfx From https://github.com/rust-lang/cargo/issues/3381 it seems your issue is due to your own git config file Adding CARGO_NET_GIT_FETCH_WITH_CLI=1 would make sense, but this is not specific to this package and should go in https://wiki.archlinux.org/title/Rust_package_guidelines before I consider adding it, because I'm not sure if does not have other side effects.

Regarding the libffmpeg.so dependency, please open an issue at https://github.com/desbma/pacman-hooks/issues since this is related to the program, not the package.

One more thing:

% check-broken-packages
File "/usr/bin/1password" from package "1password" is missing dependency "libffmpeg.so"

Is there any chance this could be a false positive? It seems odd that a password manager would have ffmpeg as dependency.

The following error occurs:

==> Updated version: check-broken-packages-pacman-hook-git r59.b62c0f4-1
==> Starting build()...
    Updating crates.io index
error: failed to get `ansi_term` as a dependency of package `check-broken-packages v1.0.0 (/home/typhoon/aur/check-broken-packages-pacman-hook-git/src/pacman-hooks/check-broken-packages)`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to authenticate when downloading repository: git@github.com:rust-lang/crates.io-index

  * attempted ssh-agent authentication, but no usernames succeeded: `git`

  if the git CLI succeeds then `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  error authenticating: no auth sock variable; class=Ssh (23)
==> ERROR: A failure occurred in build().
    Aborting...

Apparently it works if I do this first:

export CARGO_NET_GIT_FETCH_WITH_CLI=true

I am not much familiar with Rust, maybe you could change the PKGBUILD or your Cargo config to include that setting by default?

@desbma: Done.

@yochananmarqos I'm quite confident these are not false positives. Please open an issue at https://github.com/desbma/pacman-hooks/issues if you want me to look at it.