Search Criteria
Package Details: cpick 1.3.0-5
Package Actions
Git Clone URL: | https://aur.archlinux.org/cpick.git (read-only, click to copy) |
---|---|
Package Base: | cpick |
Description: | Extensive color picker in the terminal! |
Upstream URL: | https://github.com/ethanbaker/cpick |
Keywords: | application colorpicker colors terminal |
Licenses: | Apache 2.0 |
Submitter: | ethanbaker |
Maintainer: | ethanbaker |
Last Packager: | ethanbaker |
Votes: | 1 |
Popularity: | 0.000000 |
First Submitted: | 2020-06-06 15:35 (UTC) |
Last Updated: | 2023-08-02 15:41 (UTC) |
Dependencies (1)
- go (go-gitAUR, gcc-go-gitAUR, gcc-go-snapshotAUR, gcc-go) (make)
Latest Comments
djmattyg007 commented on 2020-10-12 01:40 (UTC)
Hi there! I only just got your email from months ago :( I'm glad I could help! Congratulations on your first package too, it's always a great feeling :)
I do have a couple more suggestions:
You don't need the pkgver() function. It's redundant because you're specifying an exact version already.
You don't need to use git to download the code at all. I highly recommend using the tarball that gitlab provides for all tags automatically:
https://gitlab.com/ethanbakerdev/cpick/-/archive/v1.0.2/cpick-v1.0.2.tar.gz
This will also allow you to provide a checksum for the file, so that it isn't just skipped. You'll also then be able to remove 'git' as a make dependency.
djmattyg007 commented on 2020-06-07 02:57 (UTC)
Also the source for this package is a git repository that isn't even referring to a specific tag, rather than a properly versioned release. You should either re-submit this package with a '-git' suffix, or change it so it uses versioned build artifacts.
You should probably review the following documentation on the subject:
https://wiki.archlinux.org/index.php/Arch_package_guidelines https://wiki.archlinux.org/index.php/Creating_packages https://wiki.archlinux.org/index.php/VCS_package_guidelines
djmattyg007 commented on 2020-06-07 02:53 (UTC)
Why is sudo used to build the binary? Root permissions should never be required to build anything, it's why makepkg has a specific check in place to not run as root.
It also means the package completely fails to build inside a clean chroot using Arch's official packaging tools for doing so.