Arch Linux User Repository

thank you for the diff. let me know if you'd like to be co-maintainer

for your consideration a patch that:

• uses the user-configured cargo home
• has a prepare() function
• does some shellcheck fixes

diff --git a/PKGBUILD b/PKGBUILD
index ba8659e..7949ce0 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -23,6 +23,7 @@ makedepends=(
    cargo
    git
    rust
+   jq

    # GUI (GTK4)
    cairo
@@ -53,15 +54,17 @@ conflicts=(
 )

 pkgver() {
-   cd $pkgname/
+   cd $pkgname/ || exit 1
    git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
 }

-build() {
-  cd $pkgname/
+prepare() {
+   cd $pkgname || exit 1
+   cargo fetch --target "$(rustc -vV | sed -n 's|host: ||p')"
+}

-  # Keep rust/cargo build-dependency management inside the build directory
-  export CARGO_HOME="${srcdir}/cargo"
+build() {
+   cd $pkgname/ || exit 1

    cargo build \
        --bin czkawka_cli \
@@ -72,20 +75,23 @@ build() {
 }

 check() {
-  cd $pkgname/
+   cd $pkgname/ || exit 1

-  export CARGO_HOME="${srcdir}/cargo"
    cargo test --bin czkawka_cli --release
    dbus-run-session xvfb-run -s '-nolisten local' \
        cargo test --bin czkawka_gui --release
 }

 package() {
+   pushd "${srcdir}/${pkgname}" || exit 1
+   CARGO_TARGET_DIR="$(cargo metadata --format-version 1 --no-deps --offline | jq -r '.target_directory')"
+   popd
+
    # cli

    install -Dm644 "${srcdir}/${pkgname}/czkawka_cli/LICENSE_MIT" \
        "${pkgdir}/usr/share/licenses/czkawka-cli/LICENSE_MIT"
-  install -Dm755 "${srcdir}/${pkgname}/target/release/czkawka_cli" \
+   install -Dm755 "${CARGO_TARGET_DIR}/release/czkawka_cli" \
        "${pkgdir}/usr/bin/czkawka_cli"

    # gui
@@ -97,7 +103,7 @@ package() {
    install -Dm644 "${srcdir}/${pkgname}/czkawka_gui/LICENSE_MIT_WINDOWS_THEME" \
        "${pkgdir}/usr/share/licenses/czkawka-gui/LICENSE_MIT_WINDOWS_THEME"

-  install -Dm755 "${srcdir}/${pkgname}/target/release/czkawka_gui" \
+   install -Dm755 "${CARGO_TARGET_DIR}/release/czkawka_gui" \
        "${pkgdir}/usr/bin/czkawka_gui"

    install -Dm644 "${srcdir}/${pkgname}/data/com.github.qarmin.czkawka.desktop" \
@@ -124,6 +130,6 @@ package() {
    install -Dm644 "${srcdir}/${pkgname}/krokiet/LICENSE_MIT_CODE" \
        "${pkgdir}/usr/share/licenses/krokiet/LICENSE_MIT_CODE"

-  install -Dm755 "${srcdir}/${pkgname}/target/release/krokiet" \
+   install -Dm755 "${CARGO_TARGET_DIR}/release/krokiet" \
        "${pkgdir}/usr/bin/krokiet"
 }

It has been almost three months since issues preventing this package from building have been reported. Please, if you are not going to update or maintain the package, disown it so another user may take care of it.

The main LICENSE file was removed and separate files czkawka_cli/LICENSE, czkawka_core/LICENSE, and czkawka_gui/LICENSE were added in commit c6b1eae.

Would it be possible to compile with the HEIF feature enabled? Otherwise it can't recognize pictures from iPhones :)

been having a slight trouble with rustup myself: if the default toolchain is stable the package doesn't build. I think it's unreasonable to ask the user to change their default toolchain; luckily adding +nightly to the cargo calls forces using that without impacting the user.

Is this worth looking into? I've already installed and switched to nightly, so I couldn't test this 100% yet, but explicitly specifying that nightly Rust is required can't hurt right?

@msnspk thanks for the heads up!

The developer recently started porting this program to GTK 4, so the gtk4 package is now required to build this package, thanks.

this is because you haven't updated to a recent rust compiler version with rustup yet. pacman is unable to know that compiler version and won't update it for you automatically. Ideally you drop rustup from your system altogether, since it doesn't work nice with packages. If you do want to keep using it, and upstream built compiler binaries, you need to run rustup update (I think).

thank you, that worked (running rustup update as user). some AUR packages require rustup (no idea why) which is the reason why it gets pulled to my system from time to time. maybe you could consider something like this added to PKGBUILD (perhaps better than pinning the comment):

cargo build --release --bin czkawka_gui || {
  if pacman -Q rustup >/dev/null 2>&1
  then
    echo "Try updating rustup with rustup update and retry"
    exit 1
  fi
}