Thanks for the patch, it works now. Looks like my laptop had a newer version of prettier that formats stuff differently now - and when I tested your patch on my other computer that had the old version of prettier it failed.
Search Criteria
Package Details: deezer 6.0.110-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/deezer.git (read-only, click to copy) |
---|---|
Package Base: | deezer |
Description: | A proprietary music streaming service |
Upstream URL: | https://www.deezer.com/ |
Keywords: | deezer desktop streaming |
Licenses: | custom:"Copyright (c) 2006-2024 Deezer S.A." |
Provides: | deezer |
Submitter: | IlyaGulya |
Maintainer: | SibrenVasse |
Last Packager: | SibrenVasse |
Votes: | 59 |
Popularity: | 1.71 |
First Submitted: | 2018-12-12 06:54 (UTC) |
Last Updated: | 2024-04-23 11:48 (UTC) |
Dependencies (5)
- electron13-binAUR
- asar (make)
- imagemagick (imagemagick-gitAUR, imagemagick-full-gitAUR, imagemagick-fullAUR) (make)
- p7zip (p7zip-natspecAUR, p7zip-full-binAUR, 7-zip-fullAUR) (make)
- prettier (make)
Required by (0)
Sources (7)
Latest Comments
« First ‹ Previous 1 2 3 4 5 6 7 8 .. 25 Next › Last »
msrd0 commented on 2023-07-15 17:27 (UTC)
SibrenVasse commented on 2023-07-15 17:27 (UTC)
As you can see here: the new patch has the comma:
https://aur.archlinux.org/cgit/aur.git/tree/avoid-change-default-texthtml-mime-type.patch?h=deezer
shuall commented on 2023-07-15 17:23 (UTC) (edited on 2023-07-15 17:24 (UTC) by shuall)
Failing for me as well. Just re-applied the changes in the failing patch (avoid-change-default-texthtml-mime-type.patch), and it looks like it's a little off (sorry it's a diff of diffs)
$ diff avoid-change-default-texthtml-mime-type.patch avoid2.patch
1,3c1,3
< diff --git a/build/main.js b/build/main.js
< index de51acb..e2c0b9e 100644
< --- a/build/main.js
---
> diff --git a/build/main.js.orig b/build/main.js
> index e385c23..0dae4a4 100644
> --- a/build/main.js.orig
12c12
< - scheme
---
> - scheme,
Specifically, main.js contains a line that has "scheme," with a comma, but the patch tries to remove a line that contains "scheme" without the comma.
SibrenVasse commented on 2023-07-15 17:13 (UTC)
Can you retry the build? I have updated one of the patches.
SibrenVasse commented on 2023-07-15 17:07 (UTC) (edited on 2023-07-15 17:12 (UTC) by SibrenVasse)
Yeah the reason I specified -C is because I wanted to be sure the src directory is clean.
-c only works if you:
- specified it the last time you build the package
- the last build of the package was successful
jongeduard commented on 2023-07-15 16:21 (UTC) (edited on 2023-07-15 16:28 (UTC) by jongeduard)
@SibrenVasse
I did it even better.
I use git clean -ffdxi
and then option "4: ask each" in which git let's you exactly walk through everything which does not belong to the repo. :)
The "src" directory is the thing that I removed. I always prefer to keep some existing ".pkg.tar.zst" files around just like I also maintain some regular pacman cache.
Generally I also build using makepkg -csi
. Maybe the C is the better way to do it, if it does the exact thing (explanation in man page is for option '-C' versus '-c' is very different however).
However, making a fresh new git clone of this repo into some other directory and trying to build that gives the same error for me.
msrd0 commented on 2023-07-15 14:09 (UTC)
I have reinstalled ArchLinux. There was definitely no cache nowhere messing anything up.
SibrenVasse commented on 2023-07-15 14:07 (UTC) (edited on 2023-07-15 14:10 (UTC) by SibrenVasse)
I can't seem to reproduce your issue. Have you tried buiding the package manually with makepkg -C
(capital C)?
Because my build system on github also had no issue. https://github.com/SibrenVasse/deezer/releases/tag/v5.30.580
msrd0 commented on 2023-07-15 13:42 (UTC)
I am seeing the same error message as @jongeduard
Pinned Comments
SibrenVasse commented on 2024-01-17 12:02 (UTC) (edited on 2024-01-17 12:02 (UTC) by SibrenVasse)
If you're having issues building the package, make sure the prettier package is up-to-date on your system.
Current version is prettier 3.2.2