| Git Clone URL: | https://aur.archlinux.org/devilutionx.git (read-only, click to copy) |
|---|---|
| Package Base: | devilutionx |
| Description: | Additional voices for DevilutionX |
| Upstream URL: | https://github.com/diasurgical/devilutionX |
| Keywords: | 1 Blizzard Diablo Game Hellfire Multiplayer Singleplayer |
| Licenses: | custom:UNLICENSE |
| Submitter: | robertfoster |
| Maintainer: | robertfoster |
| Last Packager: | robertfoster |
| Votes: | 19 |
| Popularity: | 0.21 |
| First Submitted: | 2019-11-17 18:10 (UTC) |
| Last Updated: | 2024-09-06 14:45 (UTC) |
@yochananmarqos anyway I've removed the make command, replacing it with cmake. in this way you don't drive crazy for INSTALL_ROOT=$pkgdir that, as discussed in the past, it's not an install directive ("I apologize, I must've hallucinated" - your words).
For README.txt ask upstream although can be considered as "Application data". I will use vanilla resources if they don't break the build and are POSIX and Arch compliant for the majority of files placement.
@robertfoster: They're not my ideas, they're Arch packaging standards.
See specifically:
@yochananmarqos please ask at the upstream project. this is the official file placement provided by cmake. Anyway why README.txt is supposed to be in the wrong path? Also your assertions on pkgdir in the build function and the fact that you don't have to touch? Maybe are your ideas, but are not formalized in anyway (except for POSIX standard).
I updated my PKGBUILD again. The docs need to be installed manually and the README.txt ends up on the wrong place.
Updated PKGBUILD. Again, don't touch the $pkgdir in the build() function. It should be used only in the package() function which uses the fakeroot environment to place the files in the right places with the proper permissions.
@robertfoster: I apologize, I must've hallucinated the word install in there. Nevermind me, then. Good day to you.
@yochananmarqos ehi man it's a make without install INSTALL_ROOT is a global variable. sit back and relax and read what other people write. It's not
make INSTALL_ROOT=$pkgdir install
but
make INSTALL_ROOT=$pkgdir
is it clear now?
@robertfoster: See the PKGBUILD template and guidelines, make install is only ever used in the package() function. We only need make as the files are being installed manually, anyway.
@yochananmarqos make doesn't have the install directive if you pay more attention. it has only an INSTALL_ROOT variable as reported in official .spec and debian packaging resources. so also it's position in build() function is done in the right way. I toke inspiration from your PKGBUILD but I leave some things (like tar.gz instead of git, the choice to use DIABDAT.MPQ during the building phase...) that I prefer. I added you as Contributor
I didn't even notice the TTF_FONT_PATH flag, nice!
Do not use make install or touch the $pkgdir in the build() function. It should be used only in the package() function which uses the fakeroot environment to place the files in the right places with the proper permissions.
With that being said, that won't work with this project:
make: *** No rule to make target 'install'. Stop.
Pinned Comments
robertfoster commented on 2021-11-02 20:41 (UTC) (edited on 2022-04-19 18:45 (UTC) by robertfoster)
This provides splitted extra voices (Polish dub by professional actors) and extra-fonts for CJK dialogues.
set your Language code within
.local/share/diasurgical/devilution/diablo.iniAs example