Package Details: dkimproxy 1.4.1-6

Git Clone URL: (read-only)
Package Base: dkimproxy
Description: An SMTP-proxy that signs and/or verifies emails, using the Mail::DKIM module.
Upstream URL:
Licenses: GPL
Submitter: None
Maintainer: fcolista
Last Packager: fcolista
Votes: 5
Popularity: 0.004333
First Submitted: 2009-10-30 19:13
Last Updated: 2015-06-08 10:17

Required by (0)

Sources (3)

Latest Comments

fcolista commented on 2015-01-21 08:04

Thanks for the report wlhlm.
Now both the services are installed with 644 permission.
Let me know if further adjustemnt are needed.

wlhlm commented on 2015-01-20 22:07

The systemd unit files should not be installed with executable permission. systemd logs the following error:

Configuration file /usr/lib/systemd/system/dkimproxy_in.service is marked executable. Please remove executable permission bits. Proceeding anyway.
Configuration file /usr/lib/systemd/system/dkimproxy_out.service is marked executable. Please remove executable permission bits. Proceeding anyway.

Please fix to something more sensible like 644:

install -Dm644 ../ "$pkgdir"/usr/lib/systemd/system/dkimproxy_in.service

fcolista commented on 2014-04-21 13:24

OK Kyrias.
I removed the || return 1, and the /pkg left (you were right).
I also quoted the directory variables.

Kyrias commented on 2014-04-20 16:29

Also just noticed that the second install command, the one installing the out service, accidentally got /pkg left into the start of the path. So easy to make those and so hard to notice >.<

Kyrias commented on 2014-04-20 16:01

Even tho the extraneous `|| return 1` is unnecessary and distracting it doesn't do any harm I guess other than making it look outdated, but you really do *need* to quote all the directory variables.

Anyone could have the PKGBUILD itself or just the variables for srcdir et.c. in a directory whose path contains a space, and if they do it currently won't work due to bash splitting the words at the space so for example `cd` will only see the bit before the space.

Another small note: For a while now all the functions has started in $srcdir so you don't need it in the `cd` invocations.

Kyrias commented on 2014-02-17 09:21

That hasn't been needed for almost as long time.

fcolista commented on 2014-02-16 18:44

Hi Kyrias.
First of all, would be nice if you learn to be more polite when you asking.

Then, would be also nice if you explain:
1 - Why "|| return 1" is mad.
IMHO if something goes wrong the compilation should be interrupted.
If you have another idea, or i'm missing something, please explain it.
Politely. So i can learn.

2 - I've read now from the wiki that "$startdir" is deprecated.
Gotta check the packages more often, since is not touched from the
2013-06-11. At that time "startdir" probably was not deprecated.
But, again, is fine if the more experienced packager teach something, rather than having an approach like yours.
My two cents.

BTW: today i will update the PKGBUILD.


Kyrias commented on 2014-02-15 21:16

Also stop using $startdir since it's deprecated and is an internal makepkg variable that should never be used in PKGBUILDs.

Kyrias commented on 2014-02-15 21:15

Could you like remove the mad `|| return 1`'s?

fcolista commented on 2013-06-11 12:03

Sounds good.
Done, thanks.

All comments