Package Details: dnschanger-desktop 2.3.2-1

Git Clone URL: https://aur.archlinux.org/dnschanger-desktop.git (read-only, click to copy)
Package Base: dnschanger-desktop
Description: DNS Changer for Windows, Mac and Linux operating systems
Upstream URL: https://dnschanger.github.io
Keywords: dns-changer
Licenses: MIT
Submitter: h3li0p4us3
Maintainer: mhdi
Last Packager: mhdi
Votes: 1
Popularity: 0.000949
First Submitted: 2024-01-01 20:58 (UTC)
Last Updated: 2024-12-25 11:36 (UTC)

Latest Comments

yochananmarqos commented on 2024-01-02 17:12 (UTC)

Please remove the groups() array, that's only for my modified PKGBUILDs and should not be used here.

Please also ask before adding someone as a Co-Maintainer. I was just bored, I don't use this program.

yochananmarqos commented on 2024-01-01 23:14 (UTC)

There are many things wrong here:

  • Don't invent a description, use the upstream description or at least base it on it
  • This is an Electron package, the architecture is not 'any' as it's built for specific architectures
  • MIT is not a common license and needs to be installed
  • npm is only required to build
  • Missing build dependency on libxcrypt-compat
  • This builds an rpm by default and is missing whatever rpm package it needs, however, we don't need to
  • rsync is missing from makedepends(), however it's unnecessary
  • It does not depend on nodejs and is missing all dependencies including polkit
  • No need to cd into the $srcdir, that's where it already starts
  • The linux-unpacked directory is not an AppImage and one cannot dump a directory into /usr/bin/. It should be installed to /opt/, however we don't need another copy of Electron on our system since we have the system package
  • Use install -d in the package() function to use 0755 permissions, not mkdir -p
  • What is your clean() function? Nothing calls it and it's pointless

See also Node.js & Electron package guidelines

Improved PKGBUILD using the system Electron