Arch Linux User Repository

Please change the source download protocol from git:// to git+https://.
Otherwise download will fail with a timeout due to changes at github.com.

Regards!

Hi dreieck,

first of all thanks for basically doing the work for me, I incorporated your changes.

To be honest I forgot I submitted this package and have not really used it in the meantime or maintained any other packages so wasn't up to date on the guidelines. So I'd be glad to add you as co-maintainer or hand it over completely if you actively use it and wouldn't mind maintaining.

Please add

provides=("dnslookup=${pkgver}")
conflicts=("dnslookup")

(the =${pkgver} only if pkgver() has been changed to provide official version number.)

Regards and thanks for maintaining!

Actually, there is an official version information available:

git describe --tags currently produces v1.9.2-1-g5be7339.

According to the Arch Linux VCS packaging guidelines, official version numbers should be used as the first part of $pkgver if available (and leading v stripped off).

So, e.g. the following pkgver() could be used:

pkgver() {
  cd "${srcdir}/dnslookup"

  _ver="$(git describe  --tags | sed 's|^[vV]||' | sed 's|-g[0-9a-fA-F]*$||' | tr '-' '+')"
  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Version could not be determined."
    return 1
  else
    printf '%s' "${_ver}.r${_rev}.${_date}.${_hash}"
  fi
}

which currently produces 1.9.2+1.r73.20230814.

Regards!

You have arch=('any'), but you build a binary.

Please specify proper arch entries!, e.g.

arch=(
  'aarch64'
  'armv6h'
  'armv7h'
  'i686'
  'x86_64'
)

Regards and thanks for maintaining!

After correcting the source download protocol error, build succeeds and package() fails with

==> Starting package()...
install: cannot stat '/tmp/makepkg/build/dnslookup-git/src/gopath/bin/dnslookup': No such file or directory

It turns out that go did place the built binary into "$GOBIN", which I have defined in my /etc/makepkg.conf to be /tmp/makepkg/.go/bin.

The following new package() function would take care of that:

package(){
    mkdir -p "${pkgdir}/usr/bin"

    if [ -v GOBIN ]; then
      _binpath="${GOBIN}"
    else
      _binpath="${srcdir}/gopath/bin"
    fi
    install "${_binpath}/dnslookup" "${pkgdir}/usr/bin/dnslookup"
}

Regards!

You need to change the source download protocol from git:// to git+https:// due to changes at github.com.

Currently, download fails:

  -> Cloning dnslookup git repo...
Cloning into bare repository '/tmp/makepkg/sources/dnslookup'...
fatal: unable to connect to github.com:
github.com[0: 140.82.121.4]: errno=Connection timed out

==> ERROR: Failure while downloading dnslookup git repo

Regards!