Arch Linux User Repository

Scott Alfter <scott@alfter.us> would fit the format used for the other credits. :)

@salfter Thank you so much! :) I tested your patch and it works! You are a champ!

I gave you credit as "salfter" in the PKGBUILD. I did not use any names, since I'm not sure if you would be fine with that. If you want me to, I can add it and bump the pkgel.

I was able to compile dvdisaster manually by fixing scripts/bash-based-configure to #include <stdio.h> in one of the tests where it was missing.

I've put the fixes to this repo up here.

@salfer Looks like an update to glib2 is responsible.

Rolling back to glib2 version 2.80.0 (via a Btrfs snapshot) and then rebooting, I'm able to build it.

But on the latest updates, including glib2 version 2.80.2, it errors with the same message you posted. :(

It's a new install of Arch, and as I mentioned earlier, neither makepkg nor yay are working. I've had other packages build with yay without issue, so the tools to build from source should all be present (otherwise yay itself won't install IIRC).

@salfter: I just built it with only the PKGBUILD, using makepkg, on two different computers.

There might be something else responsible for it not building on your system?

I'm not sure if this is the right place for a bug report, but this package isn't currently building. I've tried building it through yay and more directly with makepkg, and I get the same result. It appears to be failing during configure:

Looking for includes and libraries:

/* *** REQUIRE_GLIB2 */

/usr/bin/gcc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/tmp/dvdisaster/src=/usr/src/debug/dvdisaster -flto=auto -fcommon -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I.  -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-6 -pthread conftest.c -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now          -Wl,-z,pack-relative-relocs -flto=auto    -lglib-2.0 -lm -o conftest
#include <glib.h>
int main(int argc, char *argv[])
{ g_malloc(1024);

  printf("%d.%d.%d\n",GLIB_MAJOR_VERSION,GLIB_MINOR_VERSION,GLIB_MICRO_VERSION);
  return 0;
}
conftest.c: In function ‘main’:
conftest.c:5:3: error: implicit declaration of function ‘printf’ [-Wimplicit-function-declaration]
    5 |   printf("%d.%d.%d\n",GLIB_MAJOR_VERSION,GLIB_MINOR_VERSION,GLIB_MICRO_VERSION);
      |   ^~~~~~
conftest.c:2:1: note: include ‘<stdio.h>’ or provide a declaration of ‘printf’
    1 | #include <glib.h>
  +++ |+#include <stdio.h>
    2 | int main(int argc, char *argv[])
conftest.c:5:3: warning: incompatible implicit declaration of built-in function ‘printf’ [-Wbuiltin-declaration-mismatch]
    5 |   printf("%d.%d.%d\n",GLIB_MAJOR_VERSION,GLIB_MINOR_VERSION,GLIB_MICRO_VERSION);
      |   ^~~~~~
conftest.c:5:3: note: include ‘<stdio.h>’ or provide a declaration of ‘printf’

Update: Thought it might be an undeclared dependency, but pacman -Ss glib2 indicates that core/glib2 2.80.2-2 is installed. I chrooted into a Gentoo install on the same computer (thinking of migrating from Gentoo to Arch) and unpacked and configured the same tarball without issue.

@C2D6:

I applied all the changes that you suggested, with the one exception about the signature.

1) I removed the prepare() function, since as you noted they fixed the name of their .desktop file upstream.

2) Since the developers only publish the MD5 hashes on their upstream website, I switched from SHA1 to MD5. (Even though MD5 is "less secure".)

3) I removed the .gpg/sig file from the source array and removed the validpgpkeys array entirely for a few reasons: (a) this entire time for the PKGBUILD's history, it appears that no such verification was being done in the first place; (b) the derivative PKGBUILDs, among other PKGBUILDs in the AUR, don't make use of verifying signed source files (with the exception of notable software); and (3) it simplifies the PKGBUILD in whole.

I left a comment on the top of the PKGBUILD for those interested in doing the extra steps for verification. :)

@C2D6:

Shall apply these when I get to the computer in which I have the PKGBUILD files.

I adopted this PKGBUILD because I am a user of dvdisaster, as well as an ardent believer in archiving data for the long-term. (Mostly on M-Discs). ;)

I left the PKGBUILD as close to the original design as possible, but I will implement the suggestions once I get back home to my computer. :)

I have a couple of suggestions on the PKGBUILD.

The prepare() function is completely obsolete because the .desktop file no longer needs to be adjusted in version 0.79.10

The PKGBUILD uses sha1 hash sums. Better to follow upstream and use MD5 sums.

The PGP Key '12B31535AF903ADE9E73BA7E5A590EFEF5F6C46C' in the validpgpkeys array is deprecated. Instead, 'E3AFE70396CCC0D9E5D8381CB0DBCA7D64F770B2' should be used from upstream. https://dvdisaster.jcea.es/misc.html

The extension of ${pkgname}-${pkgver}.tar.bz2.gpg from the source array should be renamed to *.sig when downloading, so that makepkg also recognizes this as a signature and actually carries out a check.

source=(${pkgname}-${pkgver}.tar.bz2::${url}/downloads/${pkgname}-${pkgver}.tar.bz2
    ${pkgname}-${pkgver}.tar.bz2.sig::${url}/downloads/${pkgname}-${pkgver}.tar.bz2.gpg)