Package Details: echoplay 0.1-1

Git Clone URL: https://aur.archlinux.org/echoplay.git (read-only)
Package Base: echoplay
Description: Uses the echonest api to play and download music and videos
Upstream URL: http://freeactive.net/echoplay
Licenses: BSD
Submitter: realitygaps
Maintainer: realitygaps
Last Packager: realitygaps
Votes: 2
Popularity: 0.000000
First Submitted: 2010-04-25 12:29
Last Updated: 2015-07-06 14:53

Required by (0)

Sources (1)

Latest Comments

dreieck commented on 2018-05-02 12:51

Your executable has bugs.

First, it is python2 syntax, so the shabeng line should be changed from #!/usr/bin/env python to #!/usr/bin/env python2.

Second, when doing that change, the needed module pyechonest cannot be found anymore:

Traceback (most recent call last):
  File "/sbin/echoplay", line 3, in <module>
    from pyechonest import artist,config
ImportError: No module named pyechonest

Third, when converting echoplay to python3-syntax (either manually or using 2to3, it will complain with

  File "./echoplay", line 48
    for sim in alist[0].similar():
                                 ^
TabError: inconsistent use of tabs and spaces in indentation

Looking into the file, you have a mixup of tab and space indentation. Which you never should do. And not at every position it was clear which indentation level you intended (and for python syntax it is important).

Fourth: Fixing the indentation issue, the module util cannot be loaded:

Traceback (most recent call last):
  File "./echoplay", line 3, in <module>
    from pyechonest import artist,config
  File "/usr/lib/python3.6/site-packages/pyechonest/artist.py", line 11, in <module>
    import util
ModuleNotFoundError: No module named 'util'

.. Your script needs a complete rework. Please make your script working again. I will be flagging this package out of date until then.

dreieck commented on 2018-05-02 12:41

.. I made a working PKGBUILD (with some other fixes, too):

http://ix.io/19ee

Feel free to use it to correct your AUR package.

dreieck commented on 2018-05-02 12:35

The PKGBUILD misses the package()-function. Also, the url-variable should not be an array.

Build fails:

==> Building and installing package
==> ERROR: Missing package() function in /var/tmp/yaourt-tmp-felics/aur-echoplay/./PKGBUILD
==> ERROR: url should not be an array

==> ERROR: An unknown error has occurred. Exiting...

Please fix.