Arch Linux User Repository

@rfvgyhn thanks for the patch, applied!

As for the .sh script - a symlink would work in that case, but it doesn't work for every package, you should make sure it's running in a proper directory, and it's more of a convention to have an actual file as your executable.

@NeoTheFox Yep, that works too. Though I'm still not sure why the extra script is needed. Would a symlink be equivalent without needing the extra file? /usr/bin/edmarketconnector -> /usr/lib/edmarketconnector/EDMarketConnector.py. I've never not used a DE so maybe I'm missing something.

No binaries in git is a good policy. Here's an SVG if you'd still like to provide an icon. https://gist.github.com/rfvgyhn/88e552cffcd68297121f56cffab28952

In any case, I appreciate you keeping this package up to date. :)

rfvgyhn, thanks for sharing the patch. Me and some other people don't use a DE, and as such only having a .desktop file makes it inconvenient to use in such case. I've changed the .sh script so that it should not act as a wrapper anymore, this should solve your issue with signals. As for the icon - I prefer keeping binaries out of git, if possible. Let me know if that helped.

I wrote a patch for myself that:

• Directly launches the app so it can receive signals (e.g. SIGTERM) instead of using a shell wrapper. This makes it so min-ed-launcher can properly close it

• Adds an icon

Feel free to merge if you'd like. https://gist.github.com/rfvgyhn/41f984aaa766533b783afe38f0eb3f3b

On my system, dependency python-psutil was needed before successful first run

There's a new release available that should fix the problem mentioned in my earlier comment:

https://github.com/EDCD/EDMarketConnector/releases/tag/Release%2F5.11.1

There seems to be a problem with 5.11.0 on linux, EDMC seems to try to write to its install location which obviously fails on linux without root. See this GitHub issue

Additionally, edmarketconnector.desktop has a Category that doesn't work; it should be "Game", not Games, see the spec

5.10 is out for some time, and seems to include a change to the included FDevIDs files. To avoid a popup asking for manual intervention, we could switch the downloaded artifact to one that includes them. Proposed PKGBUILD diff for 5.10.1:

diff --git a/PKGBUILD b/PKGBUILD
index 71d8d5c..0e0c3cc 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,7 +2,7 @@
 # Maintainer: Henry Graham <henry)dot(arch)at(hgrahamcs)dot(com(>

 pkgname=edmarketconnector
-pkgver=5.9.5
+pkgver=5.10.1
 pkgrel=1
 pkgdesc='Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools'
 arch=('x86_64')
@@ -11,10 +11,10 @@ license=('GPL2')
 provides=('edmarketconnector')
 conflicts=('edmarketconnector')
 depends=('tk' 'python-certifi' 'python-requests' 'python-watchdog' 'python-semantic-version')
-source=("https://github.com/EDCD/EDMarketConnector/archive/Release/${pkgver}.tar.gz"
+source=("https://github.com/EDCD/EDMarketConnector/releases/download/Release%2F${pkgver}/EDMarketConnector-release-${pkgver}.tar.gz"
         "edmarketconnector.sh"
        "edmarketconnector.desktop")
-sha256sums=('f73d2466114ef6396b0edc06305e7b84d968f1f4688bcd854e89c2ca6d1af90a'
+sha256sums=('c52e1cc1f0ae3ac00ba3774cc901293ad09a0267c258f314b70f1d0266ef9fdd'
             '7be0528d56edfcb444c4a7ba7a18e85296571e7558906c90fe6520c03206242c'
             'fa797932630e7b5e7cc42b0f0f4b20126b5af67661c636885b5486008cb1b13a')

@@ -22,7 +22,7 @@ package() {
    mkdir -p ${pkgdir}/usr/lib/edmarketconnector
    mkdir -p ${pkgdir}/usr/bin/
    mkdir -p ${pkgdir}/usr/share/applications
-   cp ${srcdir}/EDMarketConnector-Release-${pkgver}/* ${pkgdir}/usr/lib/edmarketconnector -r
+   cp ${srcdir}/EDMarketConnector/* ${pkgdir}/usr/lib/edmarketconnector -r
    install -m755 edmarketconnector.sh ${pkgdir}/usr/bin/edmarketconnector.sh
    install -m644 edmarketconnector.desktop ${pkgdir}/usr/share/applications/edmarketconnector.desktop
 }

With these two changes you can build the latest version

pkgver=5.9.5

sha256sums=('f73d2466114ef6396b0edc06305e7b84d968f1f4688bcd854e89c2ca6d1af90a'
            '7be0528d56edfcb444c4a7ba7a18e85296571e7558906c90fe6520c03206242c'
            'fa797932630e7b5e7cc42b0f0f4b20126b5af67661c636885b5486008cb1b13a')