Arch Linux User Repository

Regarding versioning: upstream doesn't change the version number on release, but some time before, so I don't think pkgver() should change in that regard. I'm updating the regex to deal with a capital V though. (Side note: V2.5 < 2.7 in version sorting ;))

I think libcue and libchardet should be dependencies

You're right, I already made those changes locally, but apparently never pushed them.

I see that the source directory contains also a creative commons "CC0" license (COPYING.CC0). Should that be part of licenses?

No. CC0 applies to the demo files shipped in the repository (see commit 20d1c05), but they're not included in the package.

I worked a bit with that package and made my own PKGBUILD adaptions; I share them with you in case you are interested:

[→ PKGBUILD].

I see that the source directory contains also a creative commons "CC0" license (COPYING.CC0). Should that be part of licenses?

Regards!

I think libcue and libchardet should be dependencies:

namcap:
ffmpegfs-git E: Dependency libchardet detected and not included (libraries ['usr/lib/libchardet.so.1'] needed in files ['usr/bin/ffmpegfs'])
ffmpegfs-git E: Dependency libcue detected and not included (libraries ['usr/lib/libcue.so.2'] needed in files ['usr/bin/ffmpegfs'])

Regards!

git describe and git describe --tags, which is used in pkgver(), do not provide correct version information.

Currently, version of the latest git checkout is at 2.7 (ffmpegfs --version says so), but the git describe commands yield:

• git describe: v0.91-2093-g8bf2856f
• git describe --tags: V2.5-56-g8bf2856f

(Also note that once the v is small letter, once it is capital letter, and your pkgver() would strip away only the small letter.)

So I suggest to use another version source in pkgver().

configure.ac contains the line AC_INIT([FFMPEGFS], [2.7]), from which it could be extracted -- seems to me that this will bring in the 2.7 to the rest of the software during configuration and compilation.

So the following snipped would I think give a more correct version:
grep -E '^[[:space:]]*AC_INIT' configure.ac | sed 's|#.*||' | grep -i FFMPEGFS | tail -n1 | sed -E 's|AC_INIT[[:space:]]*\(([^\)]*)\)|\1|' | awk -F, '{print $2}' | tr -d '[[:space:]]\[\]'
(that's much longer then essentially needed in how configure.ac looks now, but might capture also other formatting cases and duplications.)

Based on that, I created the following pkgver():

pkgver() {
  cd "${srcdir}/${_pkgname}"

  _ver="$(grep -E '^[[:space:]]*AC_INIT' configure.ac | sed 's|#.*||' | grep -i FFMPEGFS | tail -n1 | sed -E 's|AC_INIT[[:space:]]*\(([^\)]*)\)|\1|' | awk -F, '{print $2}' | tr -d '[[:space:]]\[\]')"
  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Version could not be determined."
    return 1
  else
    printf '%s' "${_ver}+r${_rev}.${_date}.${_hash}"
  fi
}

(I also need to increment $epoch becase otherwise V2.5 > 2.7 in version sorting)

Then, you can also add =${pkgver} to the provides entry.

Btw. a sidenote: I have reported the version tag thing upstream: → here.

Regards and thanks for maintaining!