Package Details: fgallery 1.8.2-3

Git Clone URL: https://aur.archlinux.org/fgallery.git (read-only)
Package Base: fgallery
Description: a modern, minimalist javascript photo gallery
Upstream URL: https://www.thregr.org/~wavexx/software/fgallery/
Licenses: GPL2
Submitter: tjaart
Maintainer: tjaart
Last Packager: tjaart
Votes: 3
Popularity: 0.177044
First Submitted: 2016-03-11 15:41
Last Updated: 2016-10-24 13:07

Dependencies (12)

Required by (0)

Sources (1)

Latest Comments

tjaart commented on 2016-10-24 13:10

Thank rakoo for packaging facedetect.

I added facedetect-git as a optional dependency.

rakoo commented on 2016-10-23 16:07

Hey tjaart,

Thanks for maintaining fgallery package, it makes using fgallery easier.

I just packaged facedetect at https://aur.archlinux.org/packages/facedetect-git/ for more ease of use. I don't really intend to maintain it on the long term, I just wanted to make things simpler. Feel free to add it as optdepends.

tjaart commented on 2016-09-25 04:34

Thanks zorun,

I have made the changes as you suggested. I have not used `install` before, so I learned something new.

I added you as a contributor in the PKGBUILD, hope that is OK.

zorun commented on 2016-09-24 15:55

Hi tjaart,

I have improved your PKGBUILD a bit, the result is here: http://paste.aliens-lyon.fr/Ynt

Here is a summary of the changes:

- use `install` instead of cp/mkdir
- don't copy useless files
- use a symlink for `fgallery` instead of a wrapper script
- install man page and desktop file to proper locations
- fix arch
- fix optional dependencies

tjaart commented on 2016-05-23 15:22

@zorun: After reading though the packaging standards, I agree with you on the directories, and I have updated it accordingly.

zorun commented on 2016-05-22 20:24

The perl-json-xs isssue is fixed upstream, it should be available in the next release, see https://github.com/wavexx/fgallery/issues/48

Regarding directories, you should have a look at https://wiki.archlinux.org/index.php/Arch_packaging_standards#Directories

Using /opt is kind of OK: I think it would be better in /usr/share/fgallery, but you are the maintainer :) On the other hand, installing binaries in /usr/local/bin is clearly a bad idea, they should go to /usr/bin.

Good catch for the manpage, I hadn't realised that! Note that it should go to /usr/share/man/man1/, not /usr/local/man/man.1/

tjaart commented on 2016-05-22 16:59

@zorun, thank you for your very constructive comments, I really appreciate the feedback. I try to deal with each of your comments below:

> For some reason, the script fails when perl-json-xs is installed.
I am not sure why this is. Maybe this is something the author of fgallery could help with? If you think it is worth it we could add it to the `conflicts` array.

> I think you should use a release tarball (e.g. https://github.com/wavexx/fgallery/archive/fgallery-1.8.1.tar.gz) instead of using the git HEAD.
Yeah, now that I read the code I don't know what I was thinking. I have updated it to download the released version.

> Also, it would probably be better to install in e.g. /usr/share/fgallery instead of /opt/.
I am not so convinced on this point. Many of the AUR packages I download installs to /opt and then link their binaries to /usr/local/bin. I am open to be convinced though. What I have done so far is to replace the hard coded paths with variables to make it easy to change the install location.

> There also seems to be a man page (/opt/fgallery/fgallery.1) that should go in /usr/share/man/man1.
The man page is in `master` but is not in any release yet. I have added code in `PKGBUILD` to deal with the file, but left it commented out for now.

zorun commented on 2016-05-21 15:32

For some reason, the script fails when perl-json-xs is installed. See https://github.com/wavexx/fgallery/issues/48

zorun commented on 2016-05-21 11:17

Thanks for maintaining this package.

I think you should use a release tarball (e.g. https://github.com/wavexx/fgallery/archive/fgallery-1.8.1.tar.gz) instead of using the git HEAD.

Also, it would probably be better to install in e.g. /usr/share/fgallery instead of /opt/. There also seems to be a man page (/opt/fgallery/fgallery.1) that should go in /usr/share/man/man1.