Arch Linux User Repository

package fixed and updated for GCC 9.1

gcc9 brokes some mozilla code...

https://bugzilla.mozilla.org/show_bug.cgi?id=1514781

Try to add:

export CXXFLAGS="-Wno-error=class-memaccess -Wno-error=format-overflow -Wno-error=stringop-truncation -Wno-stringop-overflow -Wno-error=attributes -Wno-error=deprecated-copy -Wno-error=pessimizing-move -Wno-error=type-limits -Wno-error=deprecated"
export CFLAGS="-Wno-error=class-memaccess -Wno-error=format-overflow -Wno-error=stringop-truncation -Wno-stringop-overflow -Wno-error=type-limits  -Wno-error=deprecated"

Edit: doesn't work... but the problem seems GCC9. GCC8 works fine.

I get the same error as Vrakfall. The actual error seems to happen at an earlier point:

22:37.11 In file included from /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/js/xpconnect/src/Unified_cpp_js_xpconnect_src1.cpp:38:
22:37.11 /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/js/xpconnect/src/XPCWrappedNative.cpp: In member function ‘char* XPCWrappedNative::ToString(XPCWrappedNativeTearOff*) const’:
22:37.11 /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/js/xpconnect/src/XPCWrappedNative.cpp:2221:41: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
22:37.11  2221 |                 name = JS_sprintf_append(name, fmt,
22:37.11       |                        ~~~~~~~~~~~~~~~~~^~~~~~~~~~~
22:37.11  2222 |                                          array[i]->GetNameString());
22:37.11       |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~
22:40.02 cc1plus: some warnings being treated as errors
22:40.59 
22:40.59 In the directory  /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/js/xpconnect/src
22:40.59 The following command failed to execute properly:
22:40.59 /usr/bin/g++ -std=gnu++11 -o Unified_cpp_js_xpconnect_src1.o -c -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/dist/stl_wrappers -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/dist/system_wrappers -include /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/js/xpconnect/src -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/js/xpconnect/src -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/ipc/chromium/src -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/ipc/glue -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/js/xpconnect/loader -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/js/xpconnect/wrappers -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/caps -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/dom/base -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/dom/html -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/dom/svg -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/dom/workers -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/layout/base -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/layout/style -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/xpcom/reflect/xptinfo -I/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/dist/include -I/usr/include/nspr -I/usr/include/nss -I/usr/include/pixman-1 -fPIC -DMOZILLA_CLIENT -include /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_js_xpconnect_src1.o.pp -D_FORTIFY_SOURCE=2 -O2 -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wc++1z-compat -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-lifetime-dse -march=native -O2 -pipe -fstack-protector-strong -fno-plt -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -Wno-shadow -Werror=format /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/obj-x86_64-pc-linux-gnu/js/xpconnect/src/Unified_cpp_js_xpconnect_src1.cpp
22:40.59 make[5]: *** [/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/config/rules.mk:953: Unified_cpp_js_xpconnect_src1.o] Error 1
22:40.59 make[4]: *** [/tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/config/recurse.mk:71: js/xpconnect/src/target] Error 2

Searching for this brought me to this thread in the Pale Moon (a Firefox fork) forum. There it was suggested that the issue may be that Pale Moon/Firefox may not be compatible with GCC9. And in fact, on my machine the update from GCC8 to GCC9 happened after the last time I built firefox-esr52.

Using the patch in the last comment seems to resolve this instance of the error. But compilation will still fail, as the same "error" is then found in another file:

33:24.72 /tmp/makepkg/firefox-esr52/src/firefox-52.9.0esr/js/src/jsapi-tests/testPrintf.cpp:58:20: error: ‘%s’ directive argument is null [-Werror=format-overflow=]

Unfortunately, I do not know enough about C++ or the GCC in order to write any patches myself or get GCC to ignore these errors. I tried adding Wno-error=format-overflow to the CPPFLAGS in the PKGBUILD, but it does not seem to have any effect.

I get this error when trying to build:

22:41.78 libecc.a.desc                                                                     
22:41.92 make[3]: *** [/home/vrakfall/Coding/AUR/build/firefox-esr52/src/firefox-52.9.0esr/config/recurse.mk:33: compile] Error 2
22:41.92 make[2]: *** [/home/vrakfall/Coding/AUR/build/firefox-esr52/src/firefox-52.9.0esr/config/rules.mk:523: default] Error 2
22:41.92 make[1]: *** [/home/vrakfall/Coding/AUR/build/firefox-esr52/src/firefox-52.9.0esr/client.mk:415: realbuild] Error 2
22:41.92 make: *** [client.mk:170: build] Error 2

I don't know where to get more logs about this.

That firefox-esr52 would not fall on the pages with the error:

[Parent 3487] WARNING: pipe error (42): The connection was broken by the other side: file /builds-pkg/firefox-esr52/src/firefox-52.9.0esr/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 322

to file:

~ / .mozilla / firefox / *. default / prefs.js

add line:

user_pref ("privacy.trackingprotection.enabled", true);

For some sites, the problem still remains, for example:

https://comments.ua/politics/624633-privatbank-izmenil-nazvanie.html

Does not help:

browser.tabs.remote.autostart = false
browser.tabs.remote.autostart.2 = false

Who knows the solution to the problem?

@ddifof: You actually have to rebuild packages that depend on icu every time its soname links get changed. This is true for all the soname links, afaik. Some maintainers update the pkgrel variable so AUR helpers actually notice the package should be rebuilt, some others don't or simply don't notice the update (You know, being in IT makes you being busy all the time :P).

With the defaults compilation options, I didn't succeed to connect to my work using jre (the firefox tab crashes before launching the jar). I tried to compile using the same options as Debian's, because I know the connection works with Debian package (firefox-esr 52.9), and now it works !

CFLAGS+='-fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks -fno-schedule-insns'

Latest icu package updates broke library dependencies, I simply recompiled the package and all is good.

local/icu 63.1-2

local/lib32-icu 63.1-2

I don't know what update scanner is but currently the firefox-esr52 package is built without the firefox updater because there's no point in keeping it enabled as it's currently heavily out of date

There is a problem with firefox-esr52 (but not with the original firefox-52.9) and the addon "update scanner 3.3.2", if you want to use it: systemd-coredump[942]: Process 32470 (firefox) of user 1000 dumped core. Stack trace of thread 32470: #0 0x00007f17819d225f raise (libpthread.so.0) #1 0x00007f17784fe3ce n/a (libxul.so)

libxul.so from firefox-esr52 file size is 81567K and libxul.so from firefox-52.9: 65618K