Package Details: firefox-pwa 2.12.1-1

Git Clone URL: https://aur.archlinux.org/firefox-pwa.git (read-only, click to copy)
Package Base: firefox-pwa
Description: A tool to install, manage and use Progressive Web Apps (PWAs) in Mozilla Firefox (native component)
Upstream URL: https://pwasforfirefox.filips.si/
Keywords: firefox firefoxpwa pwa pwas-for-firefox
Licenses: MPL2
Submitter: petercxy
Maintainer: petercxy (filips)
Last Packager: filips
Votes: 17
Popularity: 0.78
First Submitted: 2021-07-07 09:05 (UTC)
Last Updated: 2024-05-25 17:29 (UTC)

Latest Comments

1 2 Next › Last »

filips commented on 2024-05-03 10:11 (UTC)

Well, but I would still like LTO to work :)

Appearently, this might be because CC is set to gcc instead of clang. So, maybe it's possible to detect when LTO is requested and set the correct CC and RUSTFLAGS to make it build properly. zstd crate also has fat-lto and thin-lto features, so maybe they also need to be set correctly, but I haven't tested this yet.

Also, I'm still curious why this happens only on Arch, and specifically with zstd crate, as other dependencies (even the ones that are also bindings to C libraries) seem to work fine without any additional configuration...

Antiz commented on 2024-05-02 09:09 (UTC) (edited on 2024-05-02 09:45 (UTC) by Antiz)

It seems Rust zstd crate sometimes has linking problems 0, often caused by LTO

Nice find! So you can actually just disable the LTO option in the PKGBUILD instead:

diff --git a/PKGBUILD b/PKGBUILD
index ace4fbe..01df0c9 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -18,6 +18,7 @@ license=("MPL2")

 makedepends=("rust" "cargo")
 optdepends=("firefox: Support for browser extension")
+options=('!lto')
 install=package.install

 source=("$pkgname-$pkgver.tar.gz::https://github.com/filips123/PWAsForFirefox/archive/refs/tags/v$pkgver.tar.gz")
@@ -33,9 +34,6 @@ prepare() {

     # We don't use libexec on Arch
     sed -i "s@/usr/libexec/firefoxpwa-connector@/usr/lib/firefoxpwa/firefoxpwa-connector@g" manifests/linux.json
-
-    # Disable zstd feature (which currently makes the build fails on Arch)
-    sed -i "s/\"zstd\",//g" Cargo.toml
 }

 build() {

Tested successfully on my side ;)

filips commented on 2024-05-02 08:47 (UTC) (edited on 2024-05-02 08:47 (UTC) by filips)

Thanks, I've added these lines to PKGBUILD in 2.12.0-2. It seems Rust zstd crate sometimes has linking problems (issues), often caused by LTO, but I don't know why it happens here specifically on Arch.

So, I'm not sure how to fix this properly. I will try to test it locally on Arch, but I probably won't have time soon.

Antiz commented on 2024-05-02 07:23 (UTC)

Hi, thanks for the info!

Installing zstd didn't helped, so I added the following to the prepare() function in the PKGBUILD in the mean time:

    # Disable zstd feature (which currently makes the build fails on Arch)
    sed -i "s/\"zstd\",//g" Cargo.toml

filips commented on 2024-05-01 21:39 (UTC)

It looks like zstd failed to link for some reason. It has been added as a dependency in 2.12.0 because I enabled zstd support for the HTTP client.

I don't know why it happens, as zstd-sys crate should statically link the vendored zstd library. It works fine for me locally (on Ubuntu) and on CI, so it appears to be an Arch-specific issue. Unfortunately, I currently can't test it on Arch...

You can try to install zstd libraries and build firefoxpwa again, maybe that will help link the library correctly. Or, you can also remove zstd feature from Cargo.toml (in line 42) to disable it.

Antiz commented on 2024-05-01 20:17 (UTC)

Version 2.12.0-1 fails to build with:

          collect2: error: ld returned 1 exit status

  = note: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#rustc-link-lib)

error: could not compile `firefoxpwa` (bin "firefoxpwa") due to 1 previous error
==> ERROR: A failure occurred in build().
    Aborting...

Full build log: https://bpa.st/VWZA

filips commented on 2024-02-03 20:29 (UTC)

ali.molaei, do firefoxpwa and firefoxpwa-connector themselves depend on dbus-glib, or does only Firefox runtime? Because I think these executables do not directly use any D-Bus functionalities, but Firefox does use D-Bus.

So, I'm not sure if it's appropriate to add D-Bus (and other Firefox-specific dependencies) to the firefox-pwa (and firefox-pwa-bin) package, because users might also use a different browser for runtime (like WaterFox, LibreWolf, etc.), which might have different dependencies. So, maybe adding them as optional dependencies would be better, but considering that Firefox is already listed as an optional dependency, I don't think that's really needed.

ali.molaei commented on 2024-02-03 14:01 (UTC)

Looks like this package now needs dbus-glib

filips commented on 2023-07-17 09:52 (UTC)

This has been fixed now.

rabidpug commented on 2023-07-17 01:25 (UTC)

Last 2 lines of package() are missing $pkgdir in the destination path