Package Details: flyctl-bin 0.2.39-1

Git Clone URL: https://aur.archlinux.org/flyctl-bin.git (read-only, click to copy)
Package Base: flyctl-bin
Description: Command line tools for fly.io services
Upstream URL: https://fly.io
Licenses: Apache
Conflicts: flyctl
Provides: flyctl
Submitter: jeromegn
Maintainer: jeromegn
Last Packager: jeromegn
Votes: 9
Popularity: 0.22
First Submitted: 2020-04-16 22:15 (UTC)
Last Updated: 2024-04-19 00:17 (UTC)

Dependencies (0)

Required by (0)

Sources (1)

Latest Comments

samhclark commented on 2023-02-24 20:11 (UTC)

@jeromeg Well this version worked! It'll be the next one that has the nice diff, but this time I do see pkgver in the source URL, so I expect it will be great. Thanks for working with me on this.

jeromegn commented on 2023-02-24 18:35 (UTC)

@samhclark thanks for the PR and the fix! Looks like we released since then, did it work? :)

samhclark commented on 2023-02-24 00:57 (UTC)

@jeromegn: Thanks for linking those files, that's exactly right. I think only the pkgver= line needs to be changed in the PKGBUILD, so the pkgver variable in the workflow needs to be renamed. Naming things is hard, but if you like the idea of calling the first thing "tag" and the second thing "version" then I have a PR for you https://github.com/superfly/flyctl/pull/1773

Hope that helps make things easier for you, and forgive me if that repo doesn't like outside contributions, or if there is something more I need to do to test a change like that.

jeromegn commented on 2023-02-23 13:33 (UTC)

@samhclark: Ah, this is all because we use envsubst and that variable is exported so it's being replaced in the source property.

The "template" for our PKGBUILD is here: https://github.com/superfly/flyctl/blob/54be5ae84bbd400c66f8c23fba3e90af0816946c/aur/PKGBUILD

and the variable is exported here: https://github.com/superfly/flyctl/blob/54be5ae84bbd400c66f8c23fba3e90af0816946c/.github/workflows/ci.yml#L223

It sounds like we need to rename the pkgver variable in the workflow and then match that in the template where pkgver=... so we only change that one?

samhclark commented on 2023-02-23 02:01 (UTC)

Hey, this is a silly thing, but could you change the PKGBUILD so that the version is a parameter in the source? Right now, it's the slightest of inconvenience to review each diff, because I have to look at the whole URL and make sure that the version is really all that changed. See below:

diff --git a/PKGBUILD b/PKGBUILD
index 2561980..bcc34c5 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,7 +1,7 @@
 # Maintainer: Jerome Gravel-Niquet <jeromegn@gmail.com>

 pkgname="flyctl-bin"
-pkgver="0.0.463"
+pkgver="0.0.464"
 pkgrel="1"
 pkgdesc="Command line tools for fly.io services"
 arch=("x86_64")
@@ -10,8 +10,8 @@ license=("Apache")
 depends=()
 provides=("flyctl")
 conflicts=("flyctl")
-source=("$pkgname-0.0.463.tgz::https://github.com/superfly/flyctl/releases/download/v0.0.463/flyctl_0.0.463_Linux_x86_64.tar.gz")
-sha256sums=('d7247539b588cbdf0ca0a62b5244a1aba052887a4d603e19a4ce9a4f6b95b398')
+source=("$pkgname-0.0.464.tgz::https://github.com/superfly/flyctl/releases/download/v0.0.464/flyctl_0.0.464_Linux_x86_64.tar.gz")
+sha256sums=('8254ad2c9cdb908713b4ea8294cb4035e87afcb2672da632e4fedde92bff3a40')

 package() {
     mkdir -p "$pkgdir/usr/bin"

To be clear, I'm asking to change the source line in PKGBUILD like this:

source=("$pkgname-$pkgver.tgz::https://github.com/superfly/flyctl/releases/download/v$pkgver/flyctl_${pkgver}_Linux_x86_64.tar.gz")

Then when it's just a pkgver change and a hash change it's painless to review.

With that change, mkpkg still works and makepkg --printsrcinfo > .SRCINFO doesn't change .SRCINFO at all so I think it means it's a safe change.

I would send this in the form of a PR/MR/patch but I don't really know how to do that with AUR things...

jeromegn commented on 2021-11-08 21:47 (UTC)

@qqwy: Good point. I just pushed a change in our repo to add a symlink. Hopefully it works on the next release! https://github.com/superfly/flyctl/commit/042fa0127a601c84c73e03b610f8d91011d80491

qqwy commented on 2021-11-03 10:02 (UTC)

The installation works great.

However, it seems that Fly nowadays both exposes the executable as flyctl and as fly. A lot of the documentation pages have been modified to use fly as name for the executable.

Should this package maybe be updated to add a fly alias as well?

jeromegn commented on 2021-02-04 15:11 (UTC)

@unixfox: this should be fixed now. Our envsubst call was replacing too many variables that looked like env vars

unixfox commented on 2021-02-04 09:19 (UTC) (edited on 2021-02-04 09:21 (UTC) by unixfox)

For some unknown reason it doesn't want to build anymore:

:: Starting the build:
==> Making package: flyctl-bin 0.0.172-1 (Thu 04 Feb 2021 10:18:46 AM CET)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Downloading -0.0.172.tgz...
Warning: The file name argument '-0.0.172.tgz.part' looks like a flag.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   642  100   642    0     0   2147      0 --:--:-- --:--:-- --:--:--  2147
100 13.7M  100 13.7M    0     0  4832k      0  0:00:02  0:00:02 --:--:-- 5538k
==> Validating source files with sha256sums...
    -0.0.172.tgz ... Passed
==> Extracting sources...
  -> Extracting -0.0.172.tgz with bsdtar
==> Entering fakeroot environment...
==> Starting package()...
install: cannot create regular file '/usr/bin/flyctl': Permission denied
==> ERROR: A failure occurred in package().

EDIT: I found the issue you need to add $pkgdir before /usr/bin. You removed it in commit 87d6a7c036e1

jeromegn commented on 2021-02-03 14:07 (UTC)

I've made this a part of our release workflow. It shouldn't get outdated as often anymore.