Arch Linux User Repository

@frozen actually, that was correct, and already fixed in https://github.com/fenugrec/freediag/commit/55f9a7e95c4a4d3471350eee9f85e20168576975

I should probably make a release for that and some other build fixes.

In the meantime, you can use freediag-git which I just tested and should build properly.

thanks @frozen. I opened https://github.com/fenugrec/freediag/issues/82 to track that. [edit] I just confirmed it's cppcheck complaining about that area. Will check later, I don't think the correct fix is to remove that section.

Version 1.09 seems to fail to build due to a duplicated timeout check, here is a patch I made to remove the redundant one:

freediag-1.09-saej1850-request-fix.patch

diff --color -u -r freediag-1.09-src.orig/scantool/diag_l2_saej1850.c freediag-1.09-src.new/scantool/diag_l2_saej1850.c
--- freediag-1.09-src.orig/scantool/diag_l2_saej1850.c  2021-05-30 03:37:48.000000000 +0200
+++ freediag-1.09-src.new/scantool/diag_l2_saej1850.c   2023-02-06 00:40:43.733688655 +0100
@@ -421,11 +421,6 @@
                return NULL;
        }

-       /* Return the message to user, who is responsible for freeing it */
-       if (!d_l2_conn->diag_msg) {
-               //no response, but no error either
-               *errval = DIAG_ERR_TIMEOUT;
-       }
        rmsg = d_l2_conn->diag_msg;
        d_l2_conn->diag_msg = NULL;
        return rmsg;

and entries in PKGBUILD:

source=("http://downloads.sourceforge.net/project/$pkgname/$pkgname/1.0/$pkgname-$pkgver-src.tar.gz" "freediag-1.09-saej1850-request-fix.patch")
sha256sums=('23a12f417303361aebc08e931a9543d041169ba329b4c5569765de7a93de9bbc' 'ae02c1e937e5f7c9ef83e8dcdc586ca2b3aee1e8510d943fa002682274dbb819')

prepare() {
  cd "$pkgname-$pkgver-src"
  patch -Np1 -i "${srcdir}/freediag-1.09-saej1850-request-fix.patch"
}

Well scangui hasn't been updated since 2004, and it's not required to run freediag... so fltk should be an "optional dep". I tried just changing the PKGBUILD line to "optdepends('fltk: build scangui front-end')" and it seemed to work fine here (no fltk); the scangui/CMakeLists.txt checks for FLTK and does nothing if it's absent. Note: I released 1.05 recently and it will also need a minor patch for scangui... Thanks for maintaining the build on AUR !

what about scangui ?

Hi, given the state of scangui, fltk should probably be an optional dependency instead ?

thanks, fixed

arch=(i686, x86_64) should be arch=('i686' 'x86_64')