Arch Linux User Repository

my bad, they fixed the problem a day later within the pnpm-workspace.yaml:

* * Update pnpm to add youtubei.js to minimumReleaseAgeExclude

Odd, I'm not getting that error when compiling with the current PKGBUILD and latest freetube commit.

strict pnpm v11 building policies strike again:

[ERR_PNPM_MINIMUM_RELEASE_AGE_VIOLATION] 3 lockfile entries failed verification

Fixed it by adding this line to prepare():

sed -i "6i minimumReleaseAge: 0" "$srcdir/$_pkgname/pnpm-workspace.yaml"

seems like since pnpm v11 dependencies within build scripts are handled more strict and freetube uses more unapproved packages than just '@parcel/watcher'...

I deactivated the strict approval rule by adding this line to build():

export PNPM_CONFIG_STRICT_DEP_BUILDS=false

I found it necessary to add this line to build(): pnpm approve-builds @parcel/watcher

Thanks for the _electron idea, that'll help with forgetting to change all instances of it. We aren't developing freetube, so I'm not too bothered with running linters and making sure they pass.

Hi,

The freetube.sh file still contains "electron41", and so does in the sed command.

Hi!

I will explain in parts:

1) _electron: I've created this variable to make it easier to change `electron` versions;
2) depends: I checked the `namcap` errors and added the dependencies accordingly;
3) makedepends: with `pnpm` you don't need `npm` anymore;
4) prepare(): I've changed the `sed` commands a little bit, so it can conform with `pnpm run lint`;
5) build(): I've changed to `pnpm run ci`, `pnpm run lint` and `pnpm run build` so we could be as close to upstream as possible. See https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml

UPDATE: I've checked the namcap again and the dependencies are not necessary, only electron.

What's the reasoning behind those other changes?

Hi! FreeTube has bumped electron to version 42.

In addition to that, could you consider this change?

❯ git diff PKGBUILD PKGBUILD-mod
diff --git a/PKGBUILD b/PKGBUILD-mod
index 1e73b5b..981d528 100644
--- a/PKGBUILD
+++ b/PKGBUILD-mod
@@ -2,14 +2,15 @@

 pkgname=freetube-git
 _pkgname=FreeTube
+_electron=electron42
 pkgver=0.24.0.beta.r10160.b55e623
 pkgrel=1
 pkgdesc='An open source desktop YouTube player built with privacy in mind - built from git source tree.'
 arch=('x86_64' 'i686' 'arm' 'armv6h' 'armv7h' 'aarch64')
 url="https://freetubeapp.io"
 license=('AGPL-3.0-or-later')
-depends=('electron41')
-makedepends=('git' 'npm' 'pnpm')
+depends=($_electron 'alsa-lib' 'gtk3' 'nss' 'libxss' 'libxtst' 'libnm')
+makedepends=('git' 'pnpm')
 provides=('freetube')
 conflicts=('freetube')
 source=(git+https://github.com/FreeTubeApp/FreeTube
@@ -18,18 +19,20 @@ source=(git+https://github.com/FreeTubeApp/FreeTube
 sha256sums=(SKIP SKIP SKIP)

 pkgver() {
-  cd "$srcdir/$_pkgname"
+  cd "$_pkgname"
   printf "%s.r%s.%s" "$(git tag --sort=committerdate | tail -1 | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g')" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
 }

 prepare() {
-  sed -i "5i electronDist: '/usr/lib/electron41'," "$srcdir/$_pkgname/_scripts/ebuilder.config.mjs"
-  sed -i "s/targets = Platform.LINUX.*/targets = Platform.LINUX.createTarget(['dir'], arch)/" "$srcdir/$_pkgname/_scripts/build.mjs"
+  cd "$_pkgname"
+  sed -i "5i \  electronDist: '/usr/lib/$_electron'," "_scripts/ebuilder.config.mjs"
+  sed -i "s/targets = Platform.LINUX.*/targets = Platform.LINUX.createTarget(['dir'], arch)/" "_scripts/build.mjs"
 }

 build() {
-  cd "$srcdir/$_pkgname"
-  pnpm install
+  cd "$_pkgname"
+  pnpm run ci
+  pnpm run lint
   pnpm run build
 }