Arch Linux User Repository

Thanks for the _electron idea, that'll help with forgetting to change all instances of it. We aren't developing freetube, so I'm not too bothered with running linters and making sure they pass.

Hi,

The freetube.sh file still contains "electron41", and so does in the sed command.

Hi!

I will explain in parts:

1) _electron: I've created this variable to make it easier to change `electron` versions;
2) depends: I checked the `namcap` errors and added the dependencies accordingly;
3) makedepends: with `pnpm` you don't need `npm` anymore;
4) prepare(): I've changed the `sed` commands a little bit, so it can conform with `pnpm run lint`;
5) build(): I've changed to `pnpm run ci`, `pnpm run lint` and `pnpm run build` so we could be as close to upstream as possible. See https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml

UPDATE: I've checked the namcap again and the dependencies are not necessary, only electron.

What's the reasoning behind those other changes?

Hi! FreeTube has bumped electron to version 42.

In addition to that, could you consider this change?

❯ git diff PKGBUILD PKGBUILD-mod
diff --git a/PKGBUILD b/PKGBUILD-mod
index 1e73b5b..981d528 100644
--- a/PKGBUILD
+++ b/PKGBUILD-mod
@@ -2,14 +2,15 @@

 pkgname=freetube-git
 _pkgname=FreeTube
+_electron=electron42
 pkgver=0.24.0.beta.r10160.b55e623
 pkgrel=1
 pkgdesc='An open source desktop YouTube player built with privacy in mind - built from git source tree.'
 arch=('x86_64' 'i686' 'arm' 'armv6h' 'armv7h' 'aarch64')
 url="https://freetubeapp.io"
 license=('AGPL-3.0-or-later')
-depends=('electron41')
-makedepends=('git' 'npm' 'pnpm')
+depends=($_electron 'alsa-lib' 'gtk3' 'nss' 'libxss' 'libxtst' 'libnm')
+makedepends=('git' 'pnpm')
 provides=('freetube')
 conflicts=('freetube')
 source=(git+https://github.com/FreeTubeApp/FreeTube
@@ -18,18 +19,20 @@ source=(git+https://github.com/FreeTubeApp/FreeTube
 sha256sums=(SKIP SKIP SKIP)

 pkgver() {
-  cd "$srcdir/$_pkgname"
+  cd "$_pkgname"
   printf "%s.r%s.%s" "$(git tag --sort=committerdate | tail -1 | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g')" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
 }

 prepare() {
-  sed -i "5i electronDist: '/usr/lib/electron41'," "$srcdir/$_pkgname/_scripts/ebuilder.config.mjs"
-  sed -i "s/targets = Platform.LINUX.*/targets = Platform.LINUX.createTarget(['dir'], arch)/" "$srcdir/$_pkgname/_scripts/build.mjs"
+  cd "$_pkgname"
+  sed -i "5i \  electronDist: '/usr/lib/$_electron'," "_scripts/ebuilder.config.mjs"
+  sed -i "s/targets = Platform.LINUX.*/targets = Platform.LINUX.createTarget(['dir'], arch)/" "_scripts/build.mjs"
 }

 build() {
-  cd "$srcdir/$_pkgname"
-  pnpm install
+  cd "$_pkgname"
+  pnpm run ci
+  pnpm run lint
   pnpm run build
 }

FreeTube switched from yarn to pnpm a few hours ago as the project's dependency manager

Build fails with this:

yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
warning autolinker@4.1.5: The engine "pnpm" appears to be invalid.
[3/4] Linking dependencies...
warning " > @intlify/eslint-plugin-vue-i18n@4.3.0" has unmet peer dependency "jsonc-eslint-parser@^2.3.0 || ^3.0.0".
warning " > @intlify/eslint-plugin-vue-i18n@4.3.0" has unmet peer dependency "yaml-eslint-parser@^1.2.2".
warning "electron-builder > app-builder-lib@26.8.1" has unmet peer dependency "electron-builder-squirrel-windows@26.8.1".
warning "eslint-plugin-n > ts-declaration-location@1.0.7" has unmet peer dependency "typescript@>=4.0.0".
warning " > eslint-plugin-promise@7.2.1" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0 || ^9.0.0".
warning " > stylelint-use-logical-spec@5.0.1" has incorrect peer dependency "stylelint@>=11 < 17".
[4/4] Building fresh packages...
[1/3] ⠁ electron
[2/3] ⠁ unrs-resolver

Looks like you are using nodejs-lts-iron (version 20 of nodejs) and the oldest version that freetube supports is version 22.

I'm trying to build this package, but I run into an error

==> Beginne build()...
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
warning autolinker@4.1.5: The engine "pnpm" appears to be invalid.
error @electron/rebuild@4.0.3: The engine "node" is incompatible with this module. Expected version ">=22.12.0". Got "20.20.1"
error Found incompatible module.

Is there some incorrect dependency on my system? I have npm 11.11.1-1 and yarn 1.22.22-2.

Just a heads-up for those experiencing an overexposed web view after the Electron 40 update when moving the window between HDR and SDR displays or on SDR screens at 100% brightness (Wayland-only):

A workaround for this is passing --disable-features=WaylandWpColorManagerV1

Upstream bug: https://github.com/electron/electron/issues/49566