Package Details: github-cli 0.5.5-3

Git Clone URL: https://aur.archlinux.org/github-cli.git (read-only, click to copy)
Package Base: github-cli
Description: The GitHub CLI
Upstream URL: https://github.com/cli/cli
Keywords: github
Licenses: MIT
Submitter: bradfier
Maintainer: bradfier
Last Packager: bradfier
Votes: 9
Popularity: 7.93
First Submitted: 2020-02-04 17:13
Last Updated: 2020-02-18 16:21

Dependencies (3)

Required by (0)

Sources (1)

Latest Comments

1 2 Next › Last »

FFY00 commented on 2020-02-19 15:47

No, this should have a makedepends on go-pie. The binary should be built with PIE support.

bradfier commented on 2020-02-18 16:19

It seems that explicitly depending on go-pie is unnecessary, both go and go-pie provide go from the perspective of makedepends.

This is a bit confusing because unlike Java, where the java-runtime package is explicitly a virtual package for which there are many implementations available, go and go-pie are just split builds of the same PKGBUILD.

For now, I'll change the PKGBUILD back to depending on go rather than explicitly on go-pie, and leave it up to the user which version they want to compile with.

dahankzter commented on 2020-02-18 11:15

Isn't it possible to have a user choice of go-pie or go?

bradfier commented on 2020-02-17 08:00

@Biswa96: The use of arch=('any') implies that the package once built is architecture independent. Since it's a compiled binary that's not the case.

I can however add armv7 and aarch64 to the arch=(..) array if you've tested that they work, or can provide me with access to a system so I can check it myself.

@dahankzter: I changed to use go-pie as that's the recommendation made on the wiki. I agree that it would make a lot more sense if the go-pie and go packages were interchangeable from the perspective of Pacman.

All packages should preferably be built towards go-pie as this enables us to deliver secure binaries.

dahankzter commented on 2020-02-17 07:21

Why did you switch to go-pie from go? Can't it be either of them? I really don't want to uninstall and reinstall go all the time.

Biswa96 commented on 2020-02-16 19:39

Questions: 1. Is it possible to use arch=('any')? Because I have compiled this in armv7 and aarch64 without any error. 2. There is a test command go test ./..., can it be added in check() function?

Svenstaro commented on 2020-02-16 13:50

I'm afraid all of the example PKGBUILDs are rather dated and should ironically not be used for reference.

bradfier commented on 2020-02-16 13:36

Thanks @Svenstaro:

I addressed your style comments, one thing I noticed is the example PKGBUILD at /usr/share/pacman/PKGBUILD.proto seems to use tabs instead of spaces, I based mine on that, which explains how the extra tab characters ended up in there.

Regardless, I've changed this to use only spaces.

Svenstaro commented on 2020-02-15 23:10

The PKGBUILD has improved somewhat but I have more comments:

1) You're currently mixing tabs and spaces. Prefer spaces in indentations of 2. 2) You don't need to list things in depends as makedepends too. 3) You don't need # Source build of the official GitHub CLI as that's obvious, being a PKGBUILD. 4) In package(), since you do cd "cli-$pkgver", you don't need to prepend this path in all of your installs.

bradfier commented on 2020-02-14 10:01

@caleb thanks, and there I was manually running sha256sum on the tarball and updating the file manually...

If they keep doing releases so far outside my time zone I'll certainly take you up on that offer!