Hello, this secret could do with some improvements.
- Use SDPX
license()
header. - Set
noextract=("$pkgname-v$pkgver.zip")
- Add
glib2
tomakedepends()
, as that's whereglib-compile-schemas
comes from - Since the PKGBUILD currently uses
bsdtar
to unzip a zip file, there are problems generated with the user and owner status of the files, as indicated by a quicknamcap
check. Therefore, please usebsdunzip
instead, which is also a part of thelibarchive
package. - Change
extdir
to_extdir
, as it is a user variable.
diff --git a/PKGBUILD b/PKGBUILD
index 3b7c396..341cfe3 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,23 +1,25 @@
# Maintainer: Sebastian Kremiec <sebastian.kremiec at gmail dot com>
pkgname=gnome-shell-extension-quick-settings-audio-panel
-pkgver=86
+pkgver=91
pkgrel=1
pkgdesc='Quick Settings Audio Panel GNOME Extension'
arch=('any')
url=https://github.com/Rayzeq/quick-settings-audio-panel
-license=('GPL3')
+license=('GPL-3.0-or-later')
_uuid=quick-settings-audio-panel@rayzeq.github.io
source=("$pkgname-v$pkgver.zip::$url/releases/download/v$pkgver/$_uuid.shell-extension.zip")
-sha256sums=('310eb80477f3a9ddc22a3cc9470a8a9aba5e1ba7276bc33dc6577c5848436ddb')
+noextract=("$pkgname-v$pkgver.zip")
+sha256sums=('5846bb65aebc03464d280172e4fefde9525b7d38e8d802caf5bef25217b714fd')
depends=('gnome-shell')
+makedepends=('glib2')
package() {
- local extdir=$pkgdir/usr/share/gnome-shell/extensions/$_uuid
+ local _extdir="$pkgdir/usr/share/gnome-shell/extensions/$_uuid"
- install -d $extdir
- bsdtar -xf $pkgname-v$pkgver.zip -C $extdir
- glib-compile-schemas $extdir/schemas
+ install -d $_extdir
+ bsdunzip -q -d $_extdir $pkgname-v$pkgver.zip
+ glib-compile-schemas $_extdir/schemas
- find $extdir -type f -exec chmod 644 {} +
- find $extdir -type d -exec chmod 755 {} +
+ find $_extdir -type f -exec chmod 644 {} +
+ find $_extdir -type d -exec chmod 755 {} +
}
Pinned Comments
skremiec commented on 2024-03-03 20:41 (UTC)
Please note, that this extension is released with two different version numbers, depending on the Gnome Shell version.
E.g., the v45 version is just a backport (for Gnome Shell 43/44) of the v44 version (for Gnome Shell 45).