Package Details: gnome-terminal-fedora 3.45.90-2

Git Clone URL: https://aur.archlinux.org/gnome-terminal-fedora.git (read-only, click to copy)
Package Base: gnome-terminal-fedora
Description: The GNOME Terminal Emulator with Fedora patches
Upstream URL: https://wiki.gnome.org/Apps/Terminal
Keywords: dark gnome notifications notify patched terminal transparency transparent
Licenses: GPL
Conflicts: gnome-terminal
Provides: gnome-terminal
Submitter: BerelTarMaciltur
Maintainer: mydongistiny
Last Packager: mydongistiny
Votes: 62
Popularity: 0.047788
First Submitted: 2015-03-29 22:28 (UTC)
Last Updated: 2022-11-13 03:17 (UTC)

Required by (11)

Sources (4)

Pinned Comments

Latest Comments

1 2 3 4 5 6 .. 11 Next › Last »

mydongistiny commented on 2022-11-13 03:19 (UTC) (edited on 2022-11-13 03:19 (UTC) by mydongistiny)

@xfzfflm Fixed now. Install update to vte3-notification too first.

xfzfflm commented on 2022-11-13 02:46 (UTC)

gnome-terminal/meson.build:336:2: ERROR: Dependency "libnautilus-extension" not found, tried pkgconfig and make

I have libnautilus from pacman installed. on the latest install. It seems due to libnautilus's update.

hoschi commented on 2022-01-23 23:09 (UTC)

Thanks. Me too.

mydongistiny commented on 2022-01-18 15:41 (UTC)

@hoschi I've updated the PKGBUILD to include a fix so if your system is up to date with the latest meson it will build.

hoschi commented on 2022-01-16 22:41 (UTC) (edited on 2022-01-16 22:43 (UTC) by hoschi)

Thanks for caring!
The fedora patch [16/16] relies upon a revert which is in the gnome-41 branch but not master. As you already said, you need to wait for 3.42.3.

gardotd426 commented on 2022-01-15 09:34 (UTC) (edited on 2022-01-15 09:35 (UTC) by gardotd426)

@hoschi unfortunately, there's nothing that can be done on this end.

Upstream gnome-terminal has already fixed the issue. Obviously it hasn't hit a release yet, but the issue is indeed fixed. I just built gnome-terminal without the fedora patch using this PKGBUILD (just modifying it to not use the fedora patches).

It compiles fine.

But when trying to use the current fedora patch, it fails to apply because of some changes to po/cs.po. So, I fixed that section of the patchset, so the patches all apply cleanly (that was the only failure).

But when actually patching the gnome-terminal source, and then trying to build, it fails:

[179/201] Compiling C++ object src/gnome-terminal-server.p/terminal-window.cc.o
../src/terminal-window.cc: In function ‘void action_set_title_cb(GSimpleAction*, GVariant*, gpointer)’:
../src/terminal-window.cc:845:56: warning: cast between incompatible function types from ‘void (*)(GtkWidget*)’ {aka ‘void (*)(_GtkWidget*)’} to ‘GtkCallback’ {aka ‘void (*)(_GtkWidget*, void*)’} [-Wcast-function-type]
  845 |   gtk_container_foreach (GTK_CONTAINER (message_area), (GtkCallback) gtk_widget_hide, nullptr);
      |                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
                 from /usr/include/gtk-3.0/gdk/gdk.h:32,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from ../src/terminal-window.cc:28:
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:38:59: warning: ‘GType gtk_misc_get_type()’ is deprecated [-Wdeprecated-declarations]
   38 | #define GTK_TYPE_MISC                  (gtk_misc_get_type ())
      |                                         ~~~~~~~~~~~~~~~~~~^~
/usr/include/glib-2.0/gobject/gtype.h:2417:61: note: in definition of macro ‘_G_TYPE_CIC’
 2417 |     ((ct*) g_type_check_instance_cast ((GTypeInstance*) ip, gt))
      |                                                             ^~
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:39:41: note: in expansion of macro ‘G_TYPE_CHECK_INSTANCE_CAST’
   39 | #define GTK_MISC(obj)                  (G_TYPE_CHECK_INSTANCE_CAST ((obj), GTK_TYPE_MISC, GtkMisc))
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:39:76: note: in expansion of macro ‘GTK_TYPE_MISC’
   39 | #define GTK_MISC(obj)                  (G_TYPE_CHECK_INSTANCE_CAST ((obj), GTK_TYPE_MISC, GtkMisc))
      |                                                                            ^~~~~~~~~~~~~
../src/terminal-window.cc:851:27: note: in expansion of macro ‘GTK_MISC’
  851 |   gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
      |                           ^~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtklabel.h:32,
                 from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
                 from /usr/include/gtk-3.0/gtk/gtk.h:33,
                 from ../src/terminal-window.cc:28:
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:70:9: note: declared here
   70 | GType   gtk_misc_get_type      (void) G_GNUC_CONST;
      |         ^~~~~~~~~~~~~~~~~
../src/terminal-window.cc:851:26: warning: ‘void gtk_misc_set_alignment(GtkMisc*, gfloat, gfloat)’ is deprecated [-Wdeprecated-declarations]
  851 |   gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
      |   ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtklabel.h:32,
                 from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
                 from /usr/include/gtk-3.0/gtk/gtk.h:33,
                 from ../src/terminal-window.cc:28:
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:9: note: declared here
   72 | void    gtk_misc_set_alignment (GtkMisc *misc,
      |         ^~~~~~~~~~~~~~~~~~~~~~
[200/201] Compiling C++ object src/gnome-terminal-server.p/terminal-screen.cc.o
FAILED: src/gnome-terminal-server.p/terminal-screen.cc.o 
ccache c++ -Isrc/gnome-terminal-server.p -Isrc -I../src -I. -I.. -I/usr/include/dconf -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/lzo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gsettings-desktop-schemas -I/usr/include/uuid -I/usr/include/vte-2.91 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -std=gnu++14 -Waggregate-return -Wall -Wcast-align -Wendif-labels -Werror=init-self -Werror=missing-include-dirs -Werror=pointer-arith -Wextra -Wfloat-equal -Wformat-signedness -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wshadow -Wsign-compare -Wstrict-aliasing=2 -Wundef -Wuninitialized -Wunsafe-loop-optimizations -Wvla -Wwrite-strings -fdiagnostics-show-option -fno-common -fstack-protector -fstack-protector-strong -fvisibility=hidden -fno-strict-aliasing -Wimplicit-fallthrough=5 -Wnon-virtual-dtor -Wstrict-null-sentinel -fvisibility-inlines-hidden -fvisibility=hidden -fPIE -pthread -DTERMINAL_COMPILATION -DVTE_DISABLE_DEPRECATION_WARNINGS '-DTERM_LOCALEDIR="/usr/share/locale"' '-DTERM_PKGLIBDIR="/usr/lib/gnome-terminal"' -MD -MQ src/gnome-terminal-server.p/terminal-screen.cc.o -MF src/gnome-terminal-server.p/terminal-screen.cc.o.d -o src/gnome-terminal-server.p/terminal-screen.cc.o -c ../src/terminal-screen.cc
In file included from /usr/lib/glib-2.0/include/glibconfig.h:9,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from ../src/terminal-screen.hh:22,
                 from ../src/terminal-screen.cc:23:
../src/terminal-screen.cc: In function ‘gboolean terminal_screen_reexec_from_screen_with_override_command(TerminalScreen*, TerminalScreen*, char**, GCancellable*, GError**)’:
../src/terminal-screen.cc:891:29: error: ‘data’ was not declared in this scope
  891 |       g_return_val_if_fail (data != nullptr, FALSE);
      |                             ^~~~
/usr/include/glib-2.0/glib/gmacros.h:1090:25: note: in definition of macro ‘G_LIKELY’
 1090 | #define G_LIKELY(expr) (expr)
      |                         ^~~~
../src/terminal-screen.cc:891:7: note: in expansion of macro ‘g_return_val_if_fail’
  891 |       g_return_val_if_fail (data != nullptr, FALSE);
      |       ^~~~~~~~~~~~~~~~~~~~
../src/terminal-screen.cc:893:19: error: ‘data’ was not declared in this scope
  893 |       g_strfreev (data->argv);
      |                   ^~~~
ninja: build stopped: subcommand failed.

So unfortunately, it will have to wait until either the Fedora package maintainer updates his patchset, or 3.42.3 comes out.

hoschi commented on 2022-01-14 18:15 (UTC)

Hello!
I'm afraid the package won't build anymore, looks like meson >= 0.61 is much more strict regarding undefined behavior:
https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/7886
May you want help me there a little :)

mydongistiny commented on 2021-12-11 01:36 (UTC)

@yochananmarqos so have I. Only locally.

yochananmarqos commented on 2021-12-11 01:33 (UTC)

@mydongistiny: FYI, I updated both vte-notification and gnome-terminal to the current Arch versions with no issues with the same patches.

mydongistiny commented on 2021-12-11 01:24 (UTC)

@fl4co please don't mark the package out of date if it isn't. This is based on the Fedora source. Not just upstream. It's not out of date if it's the same version as Fedora.