Package Details: google-cloud-cli 474.0.0-1

Git Clone URL: https://aur.archlinux.org/google-cloud-cli.git (read-only, click to copy)
Package Base: google-cloud-cli
Description: A set of command-line tools for the Google Cloud Platform. Includes gcloud (with beta and alpha commands), gsutil, and bq.
Upstream URL: https://cloud.google.com/cli/
Keywords: cloud gcloud gcp google sdk
Licenses: Apache-2.0
Conflicts: google-cloud-sdk
Provides: google-cloud-sdk
Replaces: google-cloud-sdk
Submitter: PolarianDev
Maintainer: jvybihal
Last Packager: jvybihal
Votes: 188
Popularity: 0.92
First Submitted: 2023-03-08 09:33 (UTC)
Last Updated: 2024-05-01 09:55 (UTC)

Dependencies (2)

Required by (15)

Sources (3)

Pinned Comments

Latest Comments

« First ‹ Previous 1 .. 25 26 27 28 29 30

giniu commented on 2014-06-14 14:11 (UTC)

Better with every version - though there are still some comments... sorry for that, I just want to help you get it right :) In short, use namcap - https://wiki.archlinux.org/index.php/namcap - architecture of this package isn't "any", there are different libraries installed for 32 and 64 bits (look at stuff listed during install on stdout) - you miss "!strip" option, it causes lots of errors during compilation like: "strip: ...: Unable to recognise the format of file" - this is common issue related to how "go" works - most go related packages in repos have this: https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/liteide#n18 - consider downloading tar.gz instead of .zip - google provides both, but tar and gzip are in base, while unzip is not - also, if you switch you might not need to change permissions anymore (guess) - when downloading, consider changing the name of stored file to include version number (see my example with double :: in name, that's how you change name) - it will help build automation scripts (if someone uses those) to get correct sources - add maintainer tag so your name will be in it: [giniu@raven3 google-cloud-sdk]$ namcap PKGBUILD PKGBUILD (google-cloud-sdk) W: Missing Maintainer tag - some other issues found with namcap: 1) your script to rename python into python2 does other things, there is no such thing as python22.5, probably it was legacy script for python2.5 google-cloud-sdk W: Referenced library 'python22.5' is an uninstalled dependency google-cloud-sdk W: Referenced library 'python22.4' is an uninstalled dependency 2) and in other place it looks like it is cutting something out google-cloud-sdk W: Referenced library 'bin' is an uninstalled dependency 3) there are empty directories and no correct flag package options: google-cloud-sdk W: Directory (opt/google-cloud-sdk/platform/gsutil/third_party/gcs-oauth2-boto-plugin/third_party/retry-decorator) is empty 4) still LOT more files miss correct python version - you actually need to change python3 to python after changing python to python2, as it seems, and maybe add python as optional dependency. It needs looking into after you deal with python->python2 rename. google-cloud-sdk E: Dependency python detected and not included (programs ['python', 'python3'] needed in scripts ['opt/google-cloud-sdk/platform/google_appengine/google/net/proto2/pytho n/public/reflection.py', 'opt/google-cloud-sdk/platform/google_appengine/google/appengine/ext/mapreduce/api/map_job/datastore_input_reader.py', 'opt/google-cloud-sdk/platform/google_appe ngine/google/appengine/cron/GrocParser.py', 'opt/google-cloud-sdk/platform/google_appengine/google/appengine/ext/db/djangoforms.py', 'opt/google-cloud-sdk/platform/gsutil/third_party/bot o/boto/services/bs.py', 'opt/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/__init__.py', ........

numkem commented on 2014-06-12 13:04 (UTC)

I've made changes related to your comment. I've also used the new method of using mkaurball instead of makepkg -S

giniu commented on 2014-06-12 06:46 (UTC)

Hi, now it looks little better, but still some comments: - you are using unquoted $pkgdir and $srcdir - if someone builds in dir with spaces, things can go wrong. Use "$pkgdir" and "$srcdir" instead. - by using $pkgdir/opt/google-cloud-sdk/install.sh you are using "python" as interpreter - this script does nothing more than selecting python and running it with correct path, that's why in my example there was python2 instead of install.sh. If you want to use install.sh you should patch it or set environment variables to select python2 instead of python - not everywhere /usr/bin/env python is used, sometimes it is /usr/bin/python - you need to change those as well - not all python scripts have .py extension, you need to look for /usr/bin/python and /usr/bin/env python inside them as well - You have "--path-update true --bash-completion true" while those could be false, then this fake bashrc file will not be created - You don't have to "mkdir -p $pkgdir/etc/profile.d/" if you use -D in install command, it will create directories Keep up good work, I will review this package again after more changes. As as I said, try to run: namcap PKGBUILD namcap (resulting file) it will give you a lot of useful information.

numkem commented on 2014-06-11 14:04 (UTC)

I'm good with that. Need to use it for some project I'm looking into. Still fighting with zsh/bash completions and paths but I'm making progress. Thanks.

barnybug commented on 2014-06-11 13:46 (UTC)

Hey, I could hand the package over to one of you, this was just a first attempt, and sounds like it'd be in better hands..

numkem commented on 2014-06-11 13:35 (UTC)

I believe I've fixed most issues: http://pastebin.com/RyQ2bBVM

giniu commented on 2014-06-11 13:01 (UTC)

Hello, I plan to move this package to community as last optional dependency of python-pandas, but this needs some clean-up and testing before I can make the move. I have some comments: - you install SDK so number should match SDK version number, not gcutil version number (the SDK is numbered 0.9.26). - you depend on python2 but use python everywhere, interpreter needs to be changed in libraries and correct environment variable needs to be set - you modify .bashrc in home directory of someone who builds this package, not installs it - correct way is to place scripts in /etc/profile.d and /etc/bash_completion.d - you don't have to create symlinks to binaries, if path will be set correctly - man pages are installed in wrong place - file ownership of some files is wrong This is a long list, but I've prepared for you a version of this package that has some of it fixed (not all): - http://pastebin.com/HA2DWvsK (PKGBUILD) - http://pastebin.com/0SmxF4kA (profile.sh) Try downloading this version and building, then use "namcap" command on resulting package to see list of remaining issues. You won't be able to fix those .jar issues, because namcap does not see virtual dependency (java-environment, which can point to many versions of java JDK), but it should be enough as a hint of how to proceed. Will you be able to update this? Cheers, Andrzej.

« First ‹ Previous 1 .. 25 26 27 28 29 30