Package Details: googleplaymusic 1.1.5-4

Git Clone URL: https://aur.archlinux.org/googleplaymusic.git (read-only)
Package Base: googleplaymusic
Description: Google Play Music is a unofficial client to play your music.
Upstream URL: https://gitlab.com/coreybruce/GooglePlayMusic
Licenses: GPL
Provides: googleplaymusic
Submitter: gameslayer
Maintainer: gameslayer
Last Packager: gameslayer
Votes: 0
Popularity: 0.000000
First Submitted: 2019-09-05 14:58
Last Updated: 2019-09-15 05:49

Latest Comments

1 2 Next › Last »

eschwartz commented on 2019-09-09 15:33

The "electron" package in community already depends on those, BTW. One of the advantages of using the system electron package.

yochananmarqos commented on 2019-09-09 13:42

Yes, those are common dependencies for electron applications.

gameslayer commented on 2019-09-09 07:38

"Depends as namcap sees them: depends=(nss gtk3 libxss)"

Dependency I need to add?

yochananmarqos commented on 2019-09-06 15:07

Depends as namcap sees them: depends=(nss gtk3 libxss)

eschwartz commented on 2019-09-05 17:34

https://wiki.archlinux.org/index.php/Electron_package_guidelines#Using_the_system_electron

It is sufficient to not call npm in any way, shape or form. Just cp the index.html and main.js and other relevant files into "${pkgdir}"/usr/share/appname

The trusted electron package already has a working sandbox which works with both userns and setuid methods.

As for modifying $HOME, that is simply a violation of the terms of service for the AUR. The rules of submission by which all AUR packages must abide states that packages must follow the Arch package guidelines, and the package guidelines forbid several directories including /home. It is permissible to emit install messages which suggest the user do something; it is not permissible to have a package installation do it for them (neither in package() nor in an install script).

Alad commented on 2019-09-05 15:41

The difference is that you're not automatically modifying files in the user's personal environment. With an install message, people can just make up their own mind, which is an obvious thing to expect for your own personal working environment ($HOME).

community/electron, as I pointed out, doesn't require the sysctl hack you're mandating.

gameslayer commented on 2019-09-05 15:40

Something I will need to learn but what is the difference with it doing something so minor in the makepkg and the .install message?

Isn't electron in npm and community/electron the same?

gameslayer commented on 2019-09-05 15:40

Something I will need to learn but what is the difference with it doing something so minor in the makepkg and the .install message?

Isn't electron in npm and community/electron the same?

Alad commented on 2019-09-05 15:37

Also, you don't need to enable userns_clone if you just use community/electron.

Alad commented on 2019-09-05 15:36

Alad, the modification is for it's own config file it will create in .configs anyways for login convenience for other Google apps I have so you don't have to login multiple times in different desktop Google apps I have made but not yet submitted that use the same folder.

That doesn't matter - there should no modification of files in $HOME, period. You can put an according instruction in an .install message, if you want.